From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#13692: mouse clicks in vc-dir buffers accidentally changing marks Date: Sat, 23 Jan 2021 03:43:19 +0200 Message-ID: <927a3c2e-bd77-df54-303c-e9c098f5d244@yandex.ru> References: <875z3suun0.fsf@gnus.org> <87o8hijql0.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4012"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 Cc: Glenn Morris , 13692@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jan 23 02:44:14 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l37yH-0000v2-PV for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 23 Jan 2021 02:44:13 +0100 Original-Received: from localhost ([::1]:41036 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l37yG-0003q2-5p for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 22 Jan 2021 20:44:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49536) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l37y6-0003pv-Sr for bug-gnu-emacs@gnu.org; Fri, 22 Jan 2021 20:44:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50153) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l37y6-0007iM-D8 for bug-gnu-emacs@gnu.org; Fri, 22 Jan 2021 20:44:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l37y6-000863-A3 for bug-gnu-emacs@gnu.org; Fri, 22 Jan 2021 20:44:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 23 Jan 2021 01:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13692 X-GNU-PR-Package: emacs Original-Received: via spool by 13692-submit@debbugs.gnu.org id=B13692.161136621231073 (code B ref 13692); Sat, 23 Jan 2021 01:44:02 +0000 Original-Received: (at 13692) by debbugs.gnu.org; 23 Jan 2021 01:43:32 +0000 Original-Received: from localhost ([127.0.0.1]:33466 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l37xb-000857-Nz for submit@debbugs.gnu.org; Fri, 22 Jan 2021 20:43:31 -0500 Original-Received: from mail-ed1-f43.google.com ([209.85.208.43]:33679) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l37xY-00084p-Kt for 13692@debbugs.gnu.org; Fri, 22 Jan 2021 20:43:30 -0500 Original-Received: by mail-ed1-f43.google.com with SMTP id c6so8698114ede.0 for <13692@debbugs.gnu.org>; Fri, 22 Jan 2021 17:43:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=R4yX46LJ9dEp2PlKYog5B/rWm1PT/fIhDP3Dgx/B0Xc=; b=lmOP2RGUYn//AH8nuOSh/m+L9d0q72cuysjjGvnf+cflprxr8CbOHAZT7GvfNV4dCD aHjYWMbCECTY5yDEMqWZ8DjYyzCWW0H/pj4+AwdToWo9SDPgut4CeKlcSHp09TUG9qsw DO2JaC1AsKyK6sflvbeK4xOO7uOMQ7Zl8YrLLiOT/plQ8kRItETk/b5Q5m126nBPvORw Fe52zNEJp/ZOzMjjqtjtNjO5Er4e8o1mnbobhnGnOsxP0ecWQ9LW573WVwpsNx2GJyoI 3cZkO34I5ynGfbEyJFQeVPuCgMYxhqWHWvrl14i+H8ui4f8q9G1A2wod/zEnepjZKlpV Torg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=R4yX46LJ9dEp2PlKYog5B/rWm1PT/fIhDP3Dgx/B0Xc=; b=U6YbI3icQIsyXXs8gIrMD9VwLNWsG9FpOBGLA5K9FMkG9HBdt1MPXV1hDExMpQPBK7 4A9PiSI3EGTwSobXS3R/LxmD1vrz/sMZE2Qqj3HR2ZxNLKRWNujEmSgS3P49G31qVLvM D+1+OFQID3NKUbHZC5aDXyM6gOHkg0xqZv+uy3nJaNtIvvOjTFp6goMdnFISx7ODYmWY BZd1REZ7rClFOEd1iX1CJiv4OSBCr8vZB/TXTcVqescv0W3Vek/ACtfJ7OdxJ7PN5dhT bi2/iVQvUU/ZTeVqquSxAyUh27BBIXl1U+AktNAWs7CRJCtVGUs9d0C+PiZzy3l06rpp JNdQ== X-Gm-Message-State: AOAM532qkJpTJQ/mtQ0rFlcafO1ys8xEezf1Jo/+rad1SpelEkx27Tad gsd+hePUdOO2tqdEvggb6aOAVyLmQ5c= X-Google-Smtp-Source: ABdhPJwVPjUsi+RmzfwnpTMdQAuaSKMRFLDKImaOSo9Gj8oDmLGPO9A/4YjJYIzl6jbUT0s0O5PNlQ== X-Received: by 2002:aa7:cfc3:: with SMTP id r3mr1826896edy.125.1611366202236; Fri, 22 Jan 2021 17:43:22 -0800 (PST) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id gt12sm5377878ejb.38.2021.01.22.17.43.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Jan 2021 17:43:21 -0800 (PST) In-Reply-To: <87o8hijql0.fsf@gnus.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:198417 Archived-At: On 21.01.2021 16:46, Lars Ingebrigtsen wrote: > Dmitry Gutov writes: > >> On 20.01.2021 05:58, Lars Ingebrigtsen wrote: >>> So the suggestion is to remove the `[mouse-2]' binding in >>> `vc-dir-mode'. >> >> I'm not sure, actually. Perhaps the complaint is about the mouse-1 >> effect on status buttons. >> >> But the rest of my email is on the assumption that we're talking about >> the mouse-2 binding. > > Depending on your settings, it's the same binding. I think the default > is that mouse-1 and mouse-2 will work the same here (because of the > > (define-key map [follow-link] 'mouse-face) > > thing)? We're talking about slightly different things. When I hear "mouse-2 binding", I think the global bidning in vc-dir-mode-map, which affects how mouse-2 works also when clicking outside of any buttons (on whitespace beside the buttons). And I think that behavior is relatively weird and could be removed. But we also have the behavior of mouse-1 and mouse-2 clicks on the "status" button. Which seem fairly sensible to me, but might be the cause of Glenn's annoyance in this report because it's relatively easy to click mouse-1 anywhere in the buffer by mistake. >> I don't have a strong opinion about this feature, but it seems like it >> was designed almost with the main goal of being non-discoverable. As >> such, I don't think it has many users. >> >> It only works when you click on an empty space; if you click on a file >> or directory name (which are highlighted as buttons and thus invite >> you to click on them), using mouse-1 or mouse-2, you get to visit the >> file instead. Only the "status" buttons work for that. > > It works on the status column, which normally has text like "edited " > in it (if you've edited something) -- the button extends to the end of > the column... Right. But if that is what is at issue here, I think the question becomes whether to remove the "buttons" from that column (and keep the mouse-2 binding globally) or whether to remove the mouse-2 binding, but set up the buttons to continue working. Or make mouse-1 stop working on the buttons but keep mouse-2 working everywhere (except the file names, I guess?).