From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: =?UTF-8?Q?Cl=C3=A9ment?= Pit-Claudel Newsgroups: gmane.emacs.bugs Subject: bug#5950: defvaralias after defvar should be warned in runtime Date: Thu, 2 Aug 2018 23:33:39 -0400 Message-ID: <926a0bc8-e1c2-91bc-3a88-a16fd149f79b@gmail.com> References: <4BC6A096.8030801@yahoo.co.jp> <87r5gu34ag.wl%irieshinsuke@yahoo.co.jp> <3keicu1h3v.fsf@fencepost.gnu.org> <874liufjfj.fsf@gmail.com> <871sdyezwl.fsf@gmail.com> <87vaaoxm1z.fsf@gmail.com> <8e11e15a-a806-777e-1b18-3db9000c77de@gmail.com> <775d0859-cb89-3f35-0455-1357461128d0@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1533267128 1723 195.159.176.226 (3 Aug 2018 03:32:08 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 3 Aug 2018 03:32:08 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 Cc: IRIE Shinsuke , 5950@debbugs.gnu.org, Noam Postavsky To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Aug 03 05:32:03 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1flQos-0000JU-Q7 for geb-bug-gnu-emacs@m.gmane.org; Fri, 03 Aug 2018 05:32:03 +0200 Original-Received: from localhost ([::1]:48754 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1flQqz-00052d-C4 for geb-bug-gnu-emacs@m.gmane.org; Thu, 02 Aug 2018 23:34:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53546) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1flQqs-00052J-RY for bug-gnu-emacs@gnu.org; Thu, 02 Aug 2018 23:34:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1flQqo-00073A-UD for bug-gnu-emacs@gnu.org; Thu, 02 Aug 2018 23:34:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:34383) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1flQqo-00072y-OW for bug-gnu-emacs@gnu.org; Thu, 02 Aug 2018 23:34:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1flQqo-0007tU-IY for bug-gnu-emacs@gnu.org; Thu, 02 Aug 2018 23:34:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Cl=C3=A9ment?= Pit-Claudel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 Aug 2018 03:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 5950 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed patch Original-Received: via spool by 5950-submit@debbugs.gnu.org id=B5950.153326722930324 (code B ref 5950); Fri, 03 Aug 2018 03:34:02 +0000 Original-Received: (at 5950) by debbugs.gnu.org; 3 Aug 2018 03:33:49 +0000 Original-Received: from localhost ([127.0.0.1]:39401 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1flQqb-0007t1-C6 for submit@debbugs.gnu.org; Thu, 02 Aug 2018 23:33:49 -0400 Original-Received: from mail-yw1-f49.google.com ([209.85.161.49]:39583) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1flQqZ-0007sn-PP for 5950@debbugs.gnu.org; Thu, 02 Aug 2018 23:33:48 -0400 Original-Received: by mail-yw1-f49.google.com with SMTP id r184-v6so475731ywg.6 for <5950@debbugs.gnu.org>; Thu, 02 Aug 2018 20:33:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=xtjGlSdkJHU/8uLi5KC6N89RVPLJO9wL64ItvG1/mno=; b=rcVRfQyAeyaRd7386dfGyUQwDm8+VEpWkGkpE3QX4oGMldRChhdW4N572uvMmOVLPj /jpWRv55khaYY7zE+jpEmblIrlek/R5DjuC7Zi3I7VKKUofD/VJ8smuHf0kxamHCiDrh eBE4m/UQdm95xakU+le7siIoDotC80dRo3cazIGnRxO/b/p4RyiSHzcQLUMhxshJrPOu Ap/JtOc9sU3P/VNHzVOZgUe1Rsvu5URWarSoqPcJaIaxnLm56vt2ZGtgHoOcnczE7UZC 4EUT0okqnplAbistfkhekbRXdXaNP/sSEqgsmzWGskgfYQzTQJGXlSacF2feRLyBmZwZ 2nJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=xtjGlSdkJHU/8uLi5KC6N89RVPLJO9wL64ItvG1/mno=; b=e83GEVtGM4UgiNJI2eZ7ixToweuSG/FXKZnRIMJtnX8aRZci46EI3s9m6AehgUJfVN oEUwt8ZPoLPJNWz76nQrUKBpjVQLsexCPTdu0WW2kr8Gerv7aBuu+z/+vgvCLiOAmXyo zon1FBs85I+7IBHBfSMy2Fq7quJyJ1wC8hQnwrXboRIhhPknbE6IrfqGtgVyvVoxRJ5l SngVZJD1unHG6rH5a/OMn/Sgljsl44KRregJyS2N53DXuhWdVVg1rgY9mpEfG6ccmFYp AYhRK6QbwxnkR7m9xeOZUTBUVP6J1/AN/9/T/Uig+0tNtWEXSfdYDEJXwyAs6X/OpZYu z/Uw== X-Gm-Message-State: AOUpUlErJDeyGRgp+byJ1N1Rg2NEmT4XEzPTD4/NQxRaPH5IwNbwYEjX qAbPuf+n/EDef7n/KIMxmfn29rqC X-Google-Smtp-Source: AAOMgpesk8IlrUwaUrveUI8QEGQ24F2mUwgollGQg8RLjpQ63zLi80fY7rmSk8FID8sMjcSeaSJBvA== X-Received: by 2002:a81:1791:: with SMTP id 139-v6mr1158426ywx.354.1533267222053; Thu, 02 Aug 2018 20:33:42 -0700 (PDT) Original-Received: from ?IPv6:2601:184:4180:66e7:6128:d6c2:8e05:f435? ([2601:184:4180:66e7:6128:d6c2:8e05:f435]) by smtp.gmail.com with ESMTPSA id g203-v6sm1284118ywb.69.2018.08.02.20.33.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 02 Aug 2018 20:33:41 -0700 (PDT) In-Reply-To: Content-Language: en-GB X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:149218 Archived-At: On 2018-08-02 13:03, Stefan Monnier wrote: >>> The typical failure case goes like this, user does this: >>> >>> (setq the-package-setting 'foo) >>> (require 'the-package) >>> >>> And the-package.el does this: >>> >>> (defvar the-package-real-setting 'bar) >>> ;; Oops! User's setting of `foo' is overwritten here: >>> (defvaralias 'the-package-setting 'the-package-real-setting) >> >> Thanks. Should the warning be disabled when both variables are >> already `defvar'd, then? > > Why? Replace `setq` with `defvar` in the above scenario and you have > the same problem. Do you? I thought the problem was that you were overwriting a user setting… if you change the first setq into a defvar, where's the user setting that you're overwriting?