From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#44854: [PATCH] Add lexical-binding cookie to autoload files Date: Tue, 24 Nov 2020 12:24:41 -0800 (PST) Message-ID: <925908cd-bc9d-4c57-9cec-d961c9dbad95@default> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22586"; mail-complaints-to="usenet@ciao.gmane.io" Cc: monnier@iro.umontreal.ca To: Stefan Kangas , 44854@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 24 21:27:09 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kheu4-0005lz-TO for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 24 Nov 2020 21:27:08 +0100 Original-Received: from localhost ([::1]:52334 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kheu4-0000eA-05 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 24 Nov 2020 15:27:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58446) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1khety-0000e4-Ks for bug-gnu-emacs@gnu.org; Tue, 24 Nov 2020 15:27:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49840) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1khety-0004Sw-4t for bug-gnu-emacs@gnu.org; Tue, 24 Nov 2020 15:27:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1khety-000203-0k for bug-gnu-emacs@gnu.org; Tue, 24 Nov 2020 15:27:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 24 Nov 2020 20:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44854 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 44854-submit@debbugs.gnu.org id=B44854.16062496157673 (code B ref 44854); Tue, 24 Nov 2020 20:27:01 +0000 Original-Received: (at 44854) by debbugs.gnu.org; 24 Nov 2020 20:26:55 +0000 Original-Received: from localhost ([127.0.0.1]:33153 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1khetr-0001zh-5H for submit@debbugs.gnu.org; Tue, 24 Nov 2020 15:26:55 -0500 Original-Received: from userp2130.oracle.com ([156.151.31.86]:37576) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1khetp-0001zU-3J for 44854@debbugs.gnu.org; Tue, 24 Nov 2020 15:26:53 -0500 Original-Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0AOKIRWo183177; Tue, 24 Nov 2020 20:26:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=fuqrNjp9sEIrkd5L1N0MZ5BxXCD8uAAzMMQ2f7PuWFQ=; b=ijm77vmquV6Ods25PG+hGRuQ9/NlAZioNX4TuKn1zNu7IyCSgtUxc14EqCFg95rDIUd1 sbK8NQM6ru6g8mRLPx4Y49zxnSzizPh/lgCTAHZAwYqdionXTDTKFu+GUxCxS11Rd2iX 1GAAnI4QVJM9vgMPJbb+KwJD/KBN4zLG748jiRBgnRxbGB4jV2SbL4tyccPt3ddqVFxK 1BBx1uV7thp6K4kUkBBl/LTk7mESq6+W87kdRleVQUeqItXqMmCGEuHdeBYXP6xXfSkl d5U3YcKSSj/Oa6LG3vBKsrVqFkBVx0cF9a+WDZsQM36IuauxbQ1BRrqDm27gOnGMLvDN Yg== Original-Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2130.oracle.com with ESMTP id 3514q8hfrx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 24 Nov 2020 20:26:47 +0000 Original-Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0AOKJx9j193103; Tue, 24 Nov 2020 20:24:46 GMT Original-Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserp3030.oracle.com with ESMTP id 34ycfnsyqf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 24 Nov 2020 20:24:46 +0000 Original-Received: from abhmp0002.oracle.com (abhmp0002.oracle.com [141.146.116.8]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 0AOKOg7C009955; Tue, 24 Nov 2020 20:24:43 GMT In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.5071.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9815 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxscore=0 spamscore=0 adultscore=0 bulkscore=0 suspectscore=0 malwarescore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2011240120 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9815 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 clxscore=1011 impostorscore=0 mlxscore=0 suspectscore=0 lowpriorityscore=0 phishscore=0 priorityscore=1501 malwarescore=0 adultscore=0 bulkscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2011240120 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:194117 Archived-At: > Does anyone have any objections to, or see any problems with adding the > lexical-binding cookie to autoload files, as in the attached patch? >=20 > I've tested it, and it works just fine here. Ouch! "It works just fine here." Please define "works", and "here". If I understand this right then yes, I object strongly. (It's possible I don't understand it right, however.) 1. What goes in an autoload should have nothing to do with whether `lexical-binding' gets turned on for a file to be autoloaded. No? 2. The code you've changed, IIUC, is used in multiple places, including user functions such as `update-directory-autoloads' and `autoload-generate-file-autoloads'. Why on earth would we assume that a user who wants to update her autoloads for a given user directory or file would necessarily want to force the code to use `lexical-binding'=3Dt? ___ Please back off with the eagerness to paint `lexical-binding' everywhere. Things like this should be handled case by case, carefully. Spray-painting this way is not TRT, IMO. Sprinkling can, not fire hose, please. We'll get to the CL approach to lexical & dynamic binding eventually, petit a petit.