From: Drew Adams <drew.adams@oracle.com>
To: Stefan Kangas <stefan@marxist.se>, 44854@debbugs.gnu.org
Cc: monnier@iro.umontreal.ca
Subject: bug#44854: [PATCH] Add lexical-binding cookie to autoload files
Date: Tue, 24 Nov 2020 12:24:41 -0800 (PST) [thread overview]
Message-ID: <925908cd-bc9d-4c57-9cec-d961c9dbad95@default> (raw)
In-Reply-To: <CADwFkm=yzGimcXmd3L-xZh1ToiJ6i8TX2DnNV=OzSUYmagy1Lg@mail.gmail.com>
> Does anyone have any objections to, or see any problems with adding the
> lexical-binding cookie to autoload files, as in the attached patch?
>
> I've tested it, and it works just fine here.
Ouch!
"It works just fine here." Please define "works",
and "here".
If I understand this right then yes, I object strongly.
(It's possible I don't understand it right, however.)
1. What goes in an autoload should have nothing to do
with whether `lexical-binding' gets turned on for a
file to be autoloaded. No?
2. The code you've changed, IIUC, is used in multiple
places, including user functions such as
`update-directory-autoloads' and
`autoload-generate-file-autoloads'.
Why on earth would we assume that a user who wants to
update her autoloads for a given user directory or
file would necessarily want to force the code to use
`lexical-binding'=t?
___
Please back off with the eagerness to paint
`lexical-binding' everywhere. Things like this should
be handled case by case, carefully. Spray-painting
this way is not TRT, IMO. Sprinkling can, not fire
hose, please. We'll get to the CL approach to lexical
& dynamic binding eventually, petit a petit.
next prev parent reply other threads:[~2020-11-24 20:24 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-24 19:34 bug#44854: [PATCH] Add lexical-binding cookie to autoload files Stefan Kangas
2020-11-24 20:21 ` Eli Zaretskii
2020-11-24 20:46 ` Stefan Kangas
2020-11-24 20:54 ` Drew Adams
2020-11-24 21:05 ` Stefan Kangas
2020-11-24 21:22 ` Drew Adams
2020-11-24 21:57 ` Stefan Monnier
2020-11-24 22:39 ` Drew Adams
2020-11-24 21:04 ` Eli Zaretskii
2020-11-24 21:35 ` Stefan Kangas
2020-11-24 21:43 ` Drew Adams
2020-11-25 7:23 ` Lars Ingebrigtsen
2020-11-25 15:02 ` Eli Zaretskii
2020-11-25 15:08 ` Lars Ingebrigtsen
2020-11-25 16:40 ` Stefan Monnier
2020-11-25 17:30 ` Eli Zaretskii
2020-11-25 17:54 ` Stefan Monnier
2020-11-25 18:22 ` Eli Zaretskii
2020-11-25 18:56 ` Stefan Monnier
2020-11-25 19:01 ` Philipp Stephani
2020-11-25 19:15 ` Eli Zaretskii
2020-11-25 19:12 ` Eli Zaretskii
2020-11-25 19:35 ` Philipp Stephani
2020-11-25 20:00 ` Eli Zaretskii
2020-11-25 20:06 ` Stefan Monnier
2020-11-25 20:27 ` Eli Zaretskii
2020-11-25 21:07 ` Stefan Kangas
2020-11-26 14:02 ` Eli Zaretskii
2020-11-27 22:39 ` Andy Moreton
2020-11-28 7:59 ` Eli Zaretskii
2020-11-29 10:30 ` Lars Ingebrigtsen
2020-12-02 13:51 ` Stefan Kangas
2020-11-25 20:53 ` Stefan Kangas
2020-11-24 20:24 ` Drew Adams [this message]
2020-11-24 21:05 ` Stefan Kangas
2020-11-24 21:28 ` Drew Adams
2020-11-24 21:58 ` Stefan Monnier
2020-12-31 5:39 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=925908cd-bc9d-4c57-9cec-d961c9dbad95@default \
--to=drew.adams@oracle.com \
--cc=44854@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=stefan@marxist.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).