* bug#14490: Error in specman-mode.el
@ 2013-05-28 15:56 Ethan Berger
2013-05-28 17:18 ` Stefan Monnier
0 siblings, 1 reply; 2+ messages in thread
From: Ethan Berger @ 2013-05-28 15:56 UTC (permalink / raw)
To: 14490
The following code appears in revision 1.23 of specman-mode.el:
(defvar emacs-kind nil)
;; emacs or xemacs
(if (or (string-match "Lucid" emacs-version)
(string-match "XEmacs" emacs-version))
(setq specman-emacs-kind 'xemacs)
(setq specman-emacs-kind 'emacs))
Elsewhere in the file there are references to emacs-kind, which is always nil, rather than to specman-emacs-kind. Naturally, this causes other problems.
^ permalink raw reply [flat|nested] 2+ messages in thread
* bug#14490: Error in specman-mode.el
2013-05-28 15:56 bug#14490: Error in specman-mode.el Ethan Berger
@ 2013-05-28 17:18 ` Stefan Monnier
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Monnier @ 2013-05-28 17:18 UTC (permalink / raw)
To: Ethan Berger; +Cc: 14490
> ;; emacs or xemacs
> (if (or (string-match "Lucid" emacs-version)
> (string-match "XEmacs" emacs-version))
> (setq specman-emacs-kind 'xemacs)
> (setq specman-emacs-kind 'emacs))
BTW, the standard recommended way to test is (featurep 'xemacs) and
rather than store the result in a variable, it's better to repeat the
test everywhere you need it, because the compiler will handle it more
efficiently (whereas if it's stored in a variable, the compiler won't be
able to tell that you'll never change the variable).
Stefan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-28 17:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-28 15:56 bug#14490: Error in specman-mode.el Ethan Berger
2013-05-28 17:18 ` Stefan Monnier
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).