From: Keith David Bershatsky <esq@lawlist.com>
To: Lars Ingebrigtsen <larsi@gnus.org>, Drew Adams <drew.adams@oracle.com>
Cc: 26432@debbugs.gnu.org
Subject: bug#26432: Acknowledgement (image-dired: Adding support for PDF thumbnails.)
Date: Sun, 29 Sep 2019 09:57:52 -0700 [thread overview]
Message-ID: <913E673A-FE93-4CCF-89A3-C1C07B99A9E7@lawlist.com> (raw)
In-Reply-To: <87k19rmhe5.fsf@gnus.org>
Thank you Lars and Glenn for looking into tracker #26432. I would be pleased to look at this again in the coming days and see what changes I made to the functions at issue to enable this particular feature. My guess is that I only added a few lines of code to existing functions.
Drew: I hope it is okay for me to add you to this discussion ..... In your dired+ adventures, have you already added support for displaying thumbnails of PDF files?
Keith
On Sep 29, 2019, at 5:11 AM, Lars Ingebrigtsen wrote:
> Glenn Morris <rgm@gnu.org> writes:
>
>> Thanks. You can increase the chances of this being applied by sending it
>> as a patch (preferably against the latest version of Emacs from git),
>> and including the necessary commit message.
>>
>> Please note that if the changes are more than about 10 lines, a
>> copyright assignment would be needed.
>>
>> See
>> https://www.gnu.org/software/emacs/manual/html_node/emacs/Contributing.html
>> and references therein for more information.
>
> Keith, did you look into sending the change as a patch, and doing
> copyright assignments? Otherwise it's unlikely that this feature is
> going to be added to Emacs.
>
> --
> (domestic pets only, the antidote for overdose, milk.)
> bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2019-09-29 16:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-10 14:32 bug#26432: image-dired: Adding support for PDF thumbnails Keith David Bershatsky
2017-04-11 4:01 ` bug#26432: Acknowledgement (image-dired: Adding support for PDF thumbnails.) Keith David Bershatsky
2017-04-11 18:05 ` Glenn Morris
2019-09-29 12:11 ` Lars Ingebrigtsen
2019-09-29 16:57 ` Keith David Bershatsky [this message]
2019-10-23 10:03 ` Lars Ingebrigtsen
2019-10-24 3:27 ` Keith David Bershatsky
2019-10-24 11:52 ` Lars Ingebrigtsen
2020-08-04 9:12 ` Lars Ingebrigtsen
2021-10-20 15:38 ` bug#26432: image-dired: Adding support for PDF thumbnails Stefan Kangas
2022-09-16 0:39 ` Stefan Kangas
2022-09-16 3:21 ` Keith David Bershatsky
2022-09-16 6:02 ` Eli Zaretskii
2022-09-16 20:52 ` Stefan Kangas
2022-09-21 14:06 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=913E673A-FE93-4CCF-89A3-C1C07B99A9E7@lawlist.com \
--to=esq@lawlist.com \
--cc=26432@debbugs.gnu.org \
--cc=drew.adams@oracle.com \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).