From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#30431: 27.0.50; "Work even if libpng is install in /usr/local" causes build failure Date: Mon, 12 Feb 2018 11:42:30 -0800 Organization: UCLA Computer Science Department Message-ID: <90f70518-cdff-d8b6-de82-6e406947d5d4@cs.ucla.edu> References: <87y3jypw87.fsf@cochranmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1518464486 27424 195.159.176.226 (12 Feb 2018 19:41:26 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 12 Feb 2018 19:41:26 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 Cc: 30431@debbugs.gnu.org To: Glenn Morris , Robert Cochran Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Feb 12 20:41:22 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1elJyQ-00069n-Vk for geb-bug-gnu-emacs@m.gmane.org; Mon, 12 Feb 2018 20:41:11 +0100 Original-Received: from localhost ([::1]:44665 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1elK0S-0003wW-NL for geb-bug-gnu-emacs@m.gmane.org; Mon, 12 Feb 2018 14:43:16 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58635) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1elK0J-0003uR-NC for bug-gnu-emacs@gnu.org; Mon, 12 Feb 2018 14:43:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1elK0E-0001H1-R3 for bug-gnu-emacs@gnu.org; Mon, 12 Feb 2018 14:43:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60395) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1elK0E-0001GW-My for bug-gnu-emacs@gnu.org; Mon, 12 Feb 2018 14:43:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1elK0E-0007GP-8s for bug-gnu-emacs@gnu.org; Mon, 12 Feb 2018 14:43:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Feb 2018 19:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30431 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30431-submit@debbugs.gnu.org id=B30431.151846456127894 (code B ref 30431); Mon, 12 Feb 2018 19:43:02 +0000 Original-Received: (at 30431) by debbugs.gnu.org; 12 Feb 2018 19:42:41 +0000 Original-Received: from localhost ([127.0.0.1]:40059 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1elJzs-0007Fq-WC for submit@debbugs.gnu.org; Mon, 12 Feb 2018 14:42:41 -0500 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:51858) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1elJzr-0007Fe-J2 for 30431@debbugs.gnu.org; Mon, 12 Feb 2018 14:42:39 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id F19AC1610A8; Mon, 12 Feb 2018 11:42:33 -0800 (PST) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id Gg5f2a9HCX53; Mon, 12 Feb 2018 11:42:30 -0800 (PST) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 4579C161126; Mon, 12 Feb 2018 11:42:30 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id HDxgagzigmVa; Mon, 12 Feb 2018 11:42:30 -0800 (PST) Original-Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 27C491610A8; Mon, 12 Feb 2018 11:42:30 -0800 (PST) In-Reply-To: Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:143220 Archived-At: On 02/12/2018 11:13 AM, Glenn Morris wrote: > AFAICS, the issue is that the CHECK_MODULES method sets PNG_LIBS (and > PNG_CFLAGS), whereas the old method sets LIBPNG (and PNG_CFLAGS). > > So revert the reversion, and then apply eg: > > --- a/configure.ac > +++ b/configure.ac > @@ -3613,7 +3613,9 @@ elif test "${with_png}" != no; then > AC_CHECK_HEADER([png.h], [HAVE_PNG=yes]) > elif test "${HAVE_X11}" = "yes" || test "${HAVE_W32}" = "yes"; then > EMACS_CHECK_MODULES([PNG], [libpng >= 1.0.0]) > - if test $HAVE_PNG = no; then > + if test $HAVE_PNG = yes; then > + LIBPNG="$PNG_LIBS" > + else > # Test old way in case pkg-config doesn't have it (older machines). > AC_MSG_CHECKING([for libpng not configured by pkg-config]) Thanks, Glenn. Werner, does that work for you?