From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#25106: 24.5; easy-menu doc strings Date: Sun, 28 Jul 2019 09:40:59 -0700 (PDT) Message-ID: <90eacb4e-822b-4af6-addb-e7d22b68310b@default> References: <45826813-d92b-4769-8ba1-a09c51349b3d@default> <87r26bittq.fsf@mouse.gnus.org> <7acd55b6-689a-45bb-917b-0b7cff901c28@default> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="191270"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 25106@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jul 28 18:42:09 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hrmFN-000ncc-6z for geb-bug-gnu-emacs@m.gmane.org; Sun, 28 Jul 2019 18:42:09 +0200 Original-Received: from localhost ([::1]:46068 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hrmFL-00054d-Pt for geb-bug-gnu-emacs@m.gmane.org; Sun, 28 Jul 2019 12:42:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40528) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hrmFH-00054X-Gy for bug-gnu-emacs@gnu.org; Sun, 28 Jul 2019 12:42:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hrmFG-0007we-In for bug-gnu-emacs@gnu.org; Sun, 28 Jul 2019 12:42:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38237) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hrmFG-0007uC-0w for bug-gnu-emacs@gnu.org; Sun, 28 Jul 2019 12:42:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hrmFF-0005TD-R5 for bug-gnu-emacs@gnu.org; Sun, 28 Jul 2019 12:42:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 28 Jul 2019 16:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25106 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: wontfix Original-Received: via spool by 25106-submit@debbugs.gnu.org id=B25106.156433207320954 (code B ref 25106); Sun, 28 Jul 2019 16:42:01 +0000 Original-Received: (at 25106) by debbugs.gnu.org; 28 Jul 2019 16:41:13 +0000 Original-Received: from localhost ([127.0.0.1]:47058 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hrmET-0005Ru-36 for submit@debbugs.gnu.org; Sun, 28 Jul 2019 12:41:13 -0400 Original-Received: from aserp2120.oracle.com ([141.146.126.78]:49188) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hrmER-0005Rg-Du for 25106@debbugs.gnu.org; Sun, 28 Jul 2019 12:41:11 -0400 Original-Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x6SGe1LG182292; Sun, 28 Jul 2019 16:41:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=Myoawid7squOVjFkgW8VQ+ZD/rIZAEvyvOtlYaxFFVs=; b=DJpjHkMhKRHYX/gFl2TrmLUipUMZxpR7HBpKh7uGKqDKUEmv8Szl4yhhP1yGEUWMeiSq UK8VIGQ+2zutfX72yDsyW0h6zJ9zqmILgv6h0briLuOHNpMbPFK4m4r7/WNyy921TN2x ho+VxLRqTIWCEbbYxKauBN8zHnY8VgOCnScsWIBkrTvMGqnFDzNMpNCN/eL0uUzXjChR 5mmt0YcJt1K931Xnl80Pq7rmZorgv/9+ZAUWSfPT5aHzTmVFcorrfJg8Y5JcbMPb2PtF sAF7XXV8qNNyFbG98/2gm9yidMLPqz1ftCEU2wHC1uewMwOyavSHQuu2soNhY2DaisAZ eQ== Original-Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by aserp2120.oracle.com with ESMTP id 2u0ejp3r40-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 28 Jul 2019 16:41:02 +0000 Original-Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x6SGc0Sp066130; Sun, 28 Jul 2019 16:41:01 GMT Original-Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userp3020.oracle.com with ESMTP id 2u0dxp2a2y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 28 Jul 2019 16:41:01 +0000 Original-Received: from abhmp0008.oracle.com (abhmp0008.oracle.com [141.146.116.14]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x6SGexPn025154; Sun, 28 Jul 2019 16:41:00 GMT In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4873.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9332 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=686 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1907280208 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9332 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=743 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1907280208 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:163980 Archived-At: > > Dunno - that was 3 years ago. Maybe take a look > > at the easy-menu doc strings? ;-) >=20 > I skimmed a few, and nothing really jumped stood out. Closing this bug > report; if somebody has a specific enhancement request in this area > they can open a new one. OK, looking quickly at `easy-mmode.el': 1. Doc string of `easy-mmode-defmap' says it defines a constant whose value has the form of the return value of `easy-mmode-define-keymap'. Doc string of `easy-mmode-define-keymap' does not specify the form of the keymap it returns. (And keymaps can have very different kinds of entries.) 2. (Emacs 24.5, which is where the bug was filed, did the same thing for `define-minor-mode': referred to the form of what `easy-mmode-define-keymap' returns. That's since been removed.) Please have the doc string of `easy-mmode-define-keymap' make clear just what the form of the keymap is that it returns. Easy-menu returns a specific kind of keymap, and that's not clear from the doc.