From: Drew Adams <drew.adams@oracle.com>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 25106@debbugs.gnu.org
Subject: bug#25106: 24.5; easy-menu doc strings
Date: Sun, 28 Jul 2019 09:40:59 -0700 (PDT) [thread overview]
Message-ID: <90eacb4e-822b-4af6-addb-e7d22b68310b@default> (raw)
In-Reply-To: <m3mugy5vpv.fsf@gnus.org>
> > Dunno - that was 3 years ago. Maybe take a look
> > at the easy-menu doc strings? ;-)
>
> I skimmed a few, and nothing really jumped stood out. Closing this bug
> report; if somebody has a specific enhancement request in this area
> they can open a new one.
OK, looking quickly at `easy-mmode.el':
1. Doc string of `easy-mmode-defmap' says it defines
a constant whose value has the form of the return
value of `easy-mmode-define-keymap'. Doc string
of `easy-mmode-define-keymap' does not specify the
form of the keymap it returns. (And keymaps can
have very different kinds of entries.)
2. (Emacs 24.5, which is where the bug was filed, did
the same thing for `define-minor-mode': referred
to the form of what `easy-mmode-define-keymap'
returns. That's since been removed.)
Please have the doc string of `easy-mmode-define-keymap'
make clear just what the form of the keymap is that
it returns. Easy-menu returns a specific kind of
keymap, and that's not clear from the doc.
next prev parent reply other threads:[~2019-07-28 16:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-04 17:06 bug#25106: 24.5; easy-menu doc strings Drew Adams
2019-07-27 11:46 ` Lars Ingebrigtsen
2019-07-27 17:06 ` Drew Adams
2019-07-28 9:55 ` Lars Ingebrigtsen
2019-07-28 16:40 ` Drew Adams [this message]
2019-07-28 17:01 ` Eli Zaretskii
[not found] <<45826813-d92b-4769-8ba1-a09c51349b3d@default>
[not found] ` <<87r26bittq.fsf@mouse.gnus.org>
[not found] ` <<7acd55b6-689a-45bb-917b-0b7cff901c28@default>
[not found] ` <<m3mugy5vpv.fsf@gnus.org>
[not found] ` <<90eacb4e-822b-4af6-addb-e7d22b68310b@default>
[not found] ` <<835znmks9v.fsf@gnu.org>
2019-07-28 18:04 ` Drew Adams
2019-07-29 14:51 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90eacb4e-822b-4af6-addb-e7d22b68310b@default \
--to=drew.adams@oracle.com \
--cc=25106@debbugs.gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).