* bug#22339: 25.1.50; Shouldn't `abbrev-expand-function' be a user option? @ 2016-01-09 18:06 Drew Adams 2016-02-16 7:05 ` Lars Ingebrigtsen 0 siblings, 1 reply; 3+ messages in thread From: Drew Adams @ 2016-01-09 18:06 UTC (permalink / raw) To: 22339 Subject line says it all. Presumably this is a variable intended for users to customize/set to a function of their liking. In GNU Emacs 25.1.50.1 (i686-pc-mingw32) of 2015-12-10 Repository revision: 6148555ee5a3d0139ae517803718b3e0357933c7 Windowing system distributor 'Microsoft Corp.', version 6.1.7601 Configured using: 'configure --prefix=/c/Devel/emacs/snapshot/trunk --enable-checking=yes --enable-check-lisp-object-type --without-compress-install 'CFLAGS=-Og -ggdb3' LDFLAGS=-Lc:/Devel/emacs/lib 'CPPFLAGS=-DGC_MCHECK=1 -Ic:/Devel/emacs/include'' ^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#22339: 25.1.50; Shouldn't `abbrev-expand-function' be a user option? 2016-01-09 18:06 bug#22339: 25.1.50; Shouldn't `abbrev-expand-function' be a user option? Drew Adams @ 2016-02-16 7:05 ` Lars Ingebrigtsen 2016-02-16 14:38 ` Drew Adams 0 siblings, 1 reply; 3+ messages in thread From: Lars Ingebrigtsen @ 2016-02-16 7:05 UTC (permalink / raw) To: Drew Adams; +Cc: 22339-done Drew Adams <drew.adams@oracle.com> writes: > Subject line says it all. Presumably this is a variable intended for > users to customize/set to a function of their liking. No, it looks more like something for programmers, and not users. Closing. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no ^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#22339: 25.1.50; Shouldn't `abbrev-expand-function' be a user option? 2016-02-16 7:05 ` Lars Ingebrigtsen @ 2016-02-16 14:38 ` Drew Adams 0 siblings, 0 replies; 3+ messages in thread From: Drew Adams @ 2016-02-16 14:38 UTC (permalink / raw) To: Lars Ingebrigtsen; +Cc: 22339-done > > Subject line says it all. Presumably this is a variable intended for > > users to customize/set to a function of their liking. > > No, it looks more like something for programmers, and not users. Closing. Why do you think that? Command `expand-abbrev' is user-facing. Its doc string says that it: Calls `abbrev-expand-function' with no argument to do the work, and returns whatever it does. (This should be the abbrev symbol if expansion occurred, else nil.) That tells users that they can set `abbrev-expand-function' to a function that has the behavior they want and return value described. There would be no reason to tell users about this if they were not expected to customize the value to a function of their choice. In that case, it would just be part of the internal implementation of the command. What's more, it used to be a user option, `pre-abbrev-expand-hook'. It is still is, but is replaced (deprecated) by `abbrev-expand-function'. There is nothing in NEWS about replacing this user option by an internal variable. The most that appears in NEWS, AFAICT, is that in Emacs 23 `pre-abbrev-expand-hook' was deprecated in favor of `abbrev-expand-functions', and that has now be deprecated in favor of `abbrev-expand-function'. Nothing in NEWS about this no longer being a user-customizable feature (option). The judgment that this variable "looks more like something for programmers, and not users" makes little sense, to me. What makes it look that way, to you? Why should users not set this variable? And if they should not, why tell them about it in the command's doc? ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-02-16 14:38 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-01-09 18:06 bug#22339: 25.1.50; Shouldn't `abbrev-expand-function' be a user option? Drew Adams 2016-02-16 7:05 ` Lars Ingebrigtsen 2016-02-16 14:38 ` Drew Adams
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).