From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Adrian Robert Newsgroups: gmane.emacs.bugs Subject: bug#3303: delete-frame raises old (invisible) frame Date: Mon, 18 May 2009 08:16:22 +0700 Message-ID: <90E34251-C034-4169-91FE-22A28C94901F@gmail.com> References: <2C87549A-2553-4477-BF77-6258A1CC32BE@gmail.com> <6A510E91-6262-44CF-AA62-315DECB52EF6@gmail.com> Reply-To: Adrian Robert , 3303@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 (Apple Message framework v753.1) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1242610337 10785 80.91.229.12 (18 May 2009 01:32:17 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 18 May 2009 01:32:17 +0000 (UTC) Cc: David Reitter , 3303@emacsbugs.donarmstrong.com To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon May 18 03:32:10 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1M5ri4-0006XT-AL for geb-bug-gnu-emacs@m.gmane.org; Mon, 18 May 2009 03:32:08 +0200 Original-Received: from localhost ([127.0.0.1]:55370 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M5ri3-0006kZ-L4 for geb-bug-gnu-emacs@m.gmane.org; Sun, 17 May 2009 21:32:07 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M5rhz-0006jp-CI for bug-gnu-emacs@gnu.org; Sun, 17 May 2009 21:32:03 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M5rhv-0006jF-Vk for bug-gnu-emacs@gnu.org; Sun, 17 May 2009 21:32:03 -0400 Original-Received: from [199.232.76.173] (port=41863 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M5rhv-0006jA-Mo for bug-gnu-emacs@gnu.org; Sun, 17 May 2009 21:31:59 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:50746) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1M5rhv-0002yP-7b for bug-gnu-emacs@gnu.org; Sun, 17 May 2009 21:31:59 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n4I1Vu3o018654; Sun, 17 May 2009 18:31:56 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n4I1P6E0016246; Sun, 17 May 2009 18:25:06 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Adrian Robert Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Mon, 18 May 2009 01:25:06 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 3303 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 3303-submit@emacsbugs.donarmstrong.com id=B3303.124260938514647 (code B ref 3303); Mon, 18 May 2009 01:25:06 +0000 Original-Received: (at 3303) by emacsbugs.donarmstrong.com; 18 May 2009 01:16:25 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from mail-px0-f108.google.com (mail-px0-f108.google.com [209.85.216.108]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n4I1GMaj014641 for <3303@emacsbugs.donarmstrong.com>; Sun, 17 May 2009 18:16:23 -0700 Original-Received: by pxi6 with SMTP id 6so1654187pxi.19 for <3303@emacsbugs.donarmstrong.com>; Sun, 17 May 2009 18:16:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:in-reply-to:references :mime-version:content-type:message-id:cc:content-transfer-encoding :from:subject:date:to:x-mailer; bh=XOfqjhdoBwGCbXAs8U3Uwv17/lvBJCO02AuQQ9br5mA=; b=lxr+RjYYTKXnBWnrymA7fhe+HIE8YqFqE6eFVaJtuGjYdOExqQ9zN1QflQKKBSZ4Rg r5PVeVnu520btP0Dq4YdE/j2wrazFrYW8wvtVk7tlyLSMIct/n11wT8zbJZEdUFl5cNk MR6LEJ9Jj4l1V3v87hzcTZCFBiAKdYwKW3nSc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=in-reply-to:references:mime-version:content-type:message-id:cc :content-transfer-encoding:from:subject:date:to:x-mailer; b=kRXQhbZe1uvH0x1PT44hx2p/TDpVlfYLNVwqCqDpPvdB+fIlTSMeJI6qtlTlw/6/UB Fnk8tgdK/bqDp1a6KXhHrputj2s3CLRGOjztkdN586ZoIs6tikUydRoeglxqvqInr21N iIZNr3bVOgqt5xULfK038L9TSo9HuLnY6aUs4= Original-Received: by 10.115.19.16 with SMTP id w16mr10152773wai.51.1242609376980; Sun, 17 May 2009 18:16:16 -0700 (PDT) Original-Received: from ?10.174.11.32? ([203.146.63.182]) by mx.google.com with ESMTPS id j39sm4238740waf.45.2009.05.17.18.16.12 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sun, 17 May 2009 18:16:16 -0700 (PDT) In-Reply-To: X-Mailer: Apple Mail (2.753.1) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Sun, 17 May 2009 21:32:03 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:27949 Archived-At: On May 18, 2009, at 3:43 AM, Stefan Monnier wrote: >>> in frame.c looks plain wrong and should probably just be deleted: >>> frame-selection is never intended to raise (or lower) any frame. >>> If this `raise' is really necessary, then it needs a much more >>> extensive >>> comment justifying its presence. >>> Adrian, could you remove this code, or justify clearly why it's >>> here? > >> I think it is there because we need to raise another (visible) >> frame when >> a frame is deleted. This is standard behavior (and sensible). > > This is a behavior which depends on the window-management policy, so > it's the responsibility of the window-manager (which may even decide > that the focus should return to some other application, which would > make > a lot of sense if the frame was created via $EDITOR=emacsclient). > > So, I'd still want to know what undesirable behavior would happen > under > NS if we don't call Fraise_frame here (and also, why it needs to be > called here rather than elsewhere). The behavior that arose was that no other frame would be selected or have focus after a frame was deleted. NS is click-to-focus, and the user would have to click another one manually, which is wrong on this platform. There is no behavior built into the NS window manager to choose another application window to be active after the active one has been removed -- this is left to application code. This can be put in the comment if it would clarify -- the thing is I did not and don't understand why other terms, W32 at least, don't need it as well.