From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.bugs Subject: bug#7533: 24.0.50; `dired-mark-pop-up': delete frame afterwards if `pop-up-frames' Date: Thu, 2 Dec 2010 10:35:41 -0800 Message-ID: <90E09641E9264B37932D2315E5E7E2EA@us.oracle.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1291315535 20532 80.91.229.12 (2 Dec 2010 18:45:35 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 2 Dec 2010 18:45:35 +0000 (UTC) To: 7533@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Dec 02 19:45:31 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1POE9p-0000sy-P9 for geb-bug-gnu-emacs@m.gmane.org; Thu, 02 Dec 2010 19:45:30 +0100 Original-Received: from localhost ([127.0.0.1]:56158 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1POE9p-0006f0-5W for geb-bug-gnu-emacs@m.gmane.org; Thu, 02 Dec 2010 13:45:29 -0500 Original-Received: from [140.186.70.92] (port=33578 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1POE9e-0006Oq-EF for bug-gnu-emacs@gnu.org; Thu, 02 Dec 2010 13:45:24 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1POE9X-0007H8-J3 for bug-gnu-emacs@gnu.org; Thu, 02 Dec 2010 13:45:18 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:35658) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1POE9X-0007Gw-HI for bug-gnu-emacs@gnu.org; Thu, 02 Dec 2010 13:45:11 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1PODwn-0002Xr-MX; Thu, 02 Dec 2010 13:32:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 Dec 2010 18:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 7533 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: Original-Received: via spool by submit@debbugs.gnu.org id=B.12913146629713 (code B ref -1); Thu, 02 Dec 2010 18:32:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 2 Dec 2010 18:31:02 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PODvq-0002Wc-27 for submit@debbugs.gnu.org; Thu, 02 Dec 2010 13:31:02 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PODvo-0002W9-Ci for submit@debbugs.gnu.org; Thu, 02 Dec 2010 13:31:00 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1POE1J-0004GP-Pk for submit@debbugs.gnu.org; Thu, 02 Dec 2010 13:36:42 -0500 Original-Received: from lists.gnu.org ([199.232.76.165]:52338) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1POE1J-0004GC-LC for submit@debbugs.gnu.org; Thu, 02 Dec 2010 13:36:41 -0500 Original-Received: from [140.186.70.92] (port=36404 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1POE1D-000173-D1 for bug-gnu-emacs@gnu.org; Thu, 02 Dec 2010 13:36:36 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1POE1C-0004Dp-5X for bug-gnu-emacs@gnu.org; Thu, 02 Dec 2010 13:36:35 -0500 Original-Received: from rcsinet10.oracle.com ([148.87.113.121]:34232) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1POE1B-0004Cv-U2 for bug-gnu-emacs@gnu.org; Thu, 02 Dec 2010 13:36:34 -0500 Original-Received: from acsinet15.oracle.com (acsinet15.oracle.com [141.146.126.227]) by rcsinet10.oracle.com (Switch-3.4.2/Switch-3.4.2) with ESMTP id oB2IaRiq001529 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 2 Dec 2010 18:36:28 GMT Original-Received: from acsmt353.oracle.com (acsmt353.oracle.com [141.146.40.153]) by acsinet15.oracle.com (Switch-3.4.2/Switch-3.4.1) with ESMTP id oB2D2PZe009505 for ; Thu, 2 Dec 2010 18:36:25 GMT Original-Received: from abhmt015.oracle.com by acsmt353.oracle.com with ESMTP id 821754871291314941; Thu, 02 Dec 2010 10:35:41 -0800 Original-Received: from dradamslap1 (/130.35.178.194) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 02 Dec 2010 10:35:40 -0800 X-Mailer: Microsoft Office Outlook 11 Thread-Index: AcuST7jZ+vG5eHSuQGaLE6rmmo1WQQ== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5994 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Thu, 02 Dec 2010 13:32:01 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:42083 Archived-At: This is another one of those annoyances that come from not testing with non-nil `pop-up-frames' (just a guess). emacs -Q M-x set-variable RET pop-up-frames RET t RET In Dired, flag several files for deletion, then hit `x'. Answer `yes' or `no'. When you hit `x' buffer *Deletions* pops up in its own frame, as it should. When you type `yes' or `no', the frame should disappear. It should be deleted. The last part of `dired-mark-pop-up' should be something like this: (save-window-excursion (dired-pop-to-buffer bufname) (apply function args) (if (one-window-p) (delete-frame) (delete-window))) ; <===== NEW If you don't think the `delete-window' is needed, then just use (when (one-window-p) (delete-frame)). The important thing, for me, is that the frame that was created just to show the files that will be deleted (or whatever) goes away. It should be only a _temporary_ frame because its only raison d'etre is as part of the deletion etc. _dialog_. [Martin will explain that a different test from `one-window-p' is more appropriate. ;-) IIRC, he generally prefers something like this to (one-window-p win): (eq win (frame-root-window (window-frame win))).] In GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600) of 2010-11-30 on 3249CTO Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (4.4) --no-opt --cflags -Ic:/imagesupport/include'