Solaris 8 patches 108652-51 and 108919-14 break `make install'

Solaris 8 patches 108652-51 and 108919-14 break `make install'

[Rabbe Fogelholm]

In GNU Emacs 21.2.1 (sparc-sun-solaris2.8, X toolkit)
 of 2002-04-17 on mandolin...

When setting up a Solaris 8 machine yesterday I noticed that a recent
Solaris patch (or a pair of patches, from the Recommended & Security
bundle dated April 12, 2002) breaks the `make install' target when
building Emacs.

The console output from the failing `make install' command looks as
follows:

> if [ ! -f /usr/local/bootenv/emacs/emacs-21.2/lisp/abbrev.elc ]; then \
>   make  bootstrap; \
> fi
> cd lib-src; make all  \
>   CC='gcc' CFLAGS='-g -O2 ' CPPFLAGS='' \
>   LDFLAGS='-L/usr/openwin/lib' MAKE='make'
> make[1]: Entering directory `/usr/local/bootenv/emacs/emacs-21.2/lib-src'
> make[1]: Nothing to be done for `all'.
> make[1]: Leaving directory `/usr/local/bootenv/emacs/emacs-21.2/lib-src'
> cd src; make all  \
>   CC='gcc' CFLAGS='-g -O2 ' CPPFLAGS='' \
>   LDFLAGS='-L/usr/openwin/lib' MAKE='make'
> make[1]: Entering directory `/usr/local/bootenv/emacs/emacs-21.2/src'
> cd ../lwlib/; make -w       CC='gcc' CFLAGS='-g -O2 ' MAKE='make'     "C_SWITCH_X_SITE=-I/usr/openwin/include "     "C_SWITCH_X_MACHINE="     "C_SWITCH_X_SYSTEM=-I/usr/dt/include "     "C_SWITCH_SITE="     "C_SWITCH_MACHINE="     "C_SWITCH_SYSTEM="
> make[2]: Entering directory `/usr/local/bootenv/emacs/emacs-21.2/lwlib'
> gcc -c   -I/usr/openwin/include  -I/usr/dt/include    -g -O2  -DEMACS_BITMAP_FILES -DHAVE_CONFIG_H -Demacs -I. -I../src -I/usr/local/bootenv/emacs/emacs-21.2/lwlib -I/usr/local/bootenv/emacs/emacs-21.2/lwlib/../src xlwmenu.c
> In file included from /usr/openwin/include/X11/Xos.h:81,
>                  from xlwmenu.c:32:
> /usr/include/strings.h:25: conflicting types for `memmove'
> /usr/include/iso/string_iso.h:62: previous declaration of `memmove'
> /usr/include/strings.h:26: parse error before `0'
> /usr/include/strings.h:26: warning: conflicting types for built-in function `memset'
> make[2]: *** [xlwmenu.o] Error 1
> make[2]: Leaving directory `/usr/local/bootenv/emacs/emacs-21.2/lwlib'
> make[1]: *** [really-lwlib] Error 2
> make[1]: Leaving directory `/usr/local/bootenv/emacs/emacs-21.2/src'
> make: *** [src] Error 2

A workaround is to back out the 108652-51 patch, which requires that
108919-14 is backed out first. After doing this the `make install'
target succeeds.

--Rabbe Fogelholm, Stockholm, Sweden

Re: Solaris 8 patches 108652-51 and 108919-14 break `make install'

[Eli Zaretskii]

> From: Rabbe Fogelholm <eubrafo@operamail.com>
> Newsgroups: gnu.emacs.bug
> Date: Wed, 17 Apr 2002 13:53:53 +0200
> 
> > make[2]: Entering directory `/usr/local/bootenv/emacs/emacs-21.2/lwlib'
> > gcc -c   -I/usr/openwin/include  -I/usr/dt/include    -g -O2  -DEMACS_BITMAP_FILES -DHAVE_CONFIG_H -Demacs -I. -I../src -I/usr/local/bootenv/emacs/emacs-21.2/lwlib -I/usr/local/bootenv/emacs/emacs-21.2/lwlib/../src xlwmenu.c
> > In file included from /usr/openwin/include/X11/Xos.h:81,
> >                  from xlwmenu.c:32:
> > /usr/include/strings.h:25: conflicting types for `memmove'
> > /usr/include/iso/string_iso.h:62: previous declaration of `memmove'
> > /usr/include/strings.h:26: parse error before `0'
> > /usr/include/strings.h:26: warning: conflicting types for built-in function `memset'
> > make[2]: *** [xlwmenu.o] Error 1
> > make[2]: Leaving directory `/usr/local/bootenv/emacs/emacs-21.2/lwlib'
> > make[1]: *** [really-lwlib] Error 2
> > make[1]: Leaving directory `/usr/local/bootenv/emacs/emacs-21.2/src'
> > make: *** [src] Error 2
> 
> A workaround is to back out the 108652-51 patch, which requires that
> 108919-14 is backed out first. After doing this the `make install'
> target succeeds.

Thanks for this important information.  However, in the hope that it's
possible to make Emacs build even with the recent patches, could you
please post the offending lines from the header files about which the
compiler complains, as well as any other lines (such as macro
definitions etc.) which are involved in this?  Maybe we can make a
change in Emacs to work around those problems.

TIA

Re: Solaris 8 patches 108652-51 and 108919-14 break `make install'

[Rabbe Fogelholm]

Eli Zaretskii wrote:
> 
> > From: Rabbe Fogelholm <eubrafo@operamail.com>
> > Newsgroups: gnu.emacs.bug
> > Date: Wed, 17 Apr 2002 13:53:53 +0200
> >
> > > make[2]: Entering directory `/usr/local/bootenv/emacs/emacs-21.2/lwlib'
> > > gcc -c   -I/usr/openwin/include  -I/usr/dt/include    -g -O2  -DEMACS_BITMAP_FILES -DHAVE_CONFIG_H -Demacs -I. -I../src -I/usr/local/bootenv/emacs/emacs-21.2/lwlib -I/usr/local/bootenv/emacs/emacs-21.2/lwlib/../src xlwmenu.c
> > > In file included from /usr/openwin/include/X11/Xos.h:81,
> > >                  from xlwmenu.c:32:
> > > /usr/include/strings.h:25: conflicting types for `memmove'
> > > /usr/include/iso/string_iso.h:62: previous declaration of `memmove'
> > > /usr/include/strings.h:26: parse error before `0'
> > > /usr/include/strings.h:26: warning: conflicting types for built-in function `memset'
> > > make[2]: *** [xlwmenu.o] Error 1
> > > make[2]: Leaving directory `/usr/local/bootenv/emacs/emacs-21.2/lwlib'
> > > make[1]: *** [really-lwlib] Error 2
> > > make[1]: Leaving directory `/usr/local/bootenv/emacs/emacs-21.2/src'
> > > make: *** [src] Error 2
> >
> > A workaround is to back out the 108652-51 patch, which requires that
> > 108919-14 is backed out first. After doing this the `make install'
> > target succeeds.
> 
> Thanks for this important information.  However, in the hope that it's
> possible to make Emacs build even with the recent patches, could you
> please post the offending lines from the header files about which the
> compiler complains, as well as any other lines (such as macro
> definitions etc.) which are involved in this?  Maybe we can make a
> change in Emacs to work around those problems.
> 
> TIA

I'm not too sure about which parts of the files that are relevant. I
have mailed them in "before" and "after" condition to you Eli, hopefully
you can sort out what is worth posting. Let me know if you need more
files.

--Rabbe

Re: Solaris 8 patches 108652-51 and 108919-14 break `make install'

[Eli Zaretskii]

> From: Rabbe Fogelholm <Rabbe.Fogelholm@era-t.ericsson.se>
> Newsgroups: gnu.emacs.bug
> Date: Wed, 17 Apr 2002 18:07:26 +0200
> 
> > > > In file included from /usr/openwin/include/X11/Xos.h:81,
> > > >                  from xlwmenu.c:32:
> > > > /usr/include/strings.h:25: conflicting types for `memmove'
> > > > /usr/include/iso/string_iso.h:62: previous declaration of `memmove'
> > > > /usr/include/strings.h:26: parse error before `0'
> > > > /usr/include/strings.h:26: warning: conflicting types for built-in function `memset'
> > > > make[2]: *** [xlwmenu.o] Error 1
> > > > make[2]: Leaving directory `/usr/local/bootenv/emacs/emacs-21.2/lwlib'
> > > > make[1]: *** [really-lwlib] Error 2
> > > > make[1]: Leaving directory `/usr/local/bootenv/emacs/emacs-21.2/src'
> > > > make: *** [src] Error 2
> > >
> > > A workaround is to back out the 108652-51 patch, which requires that
> > > 108919-14 is backed out first. After doing this the `make install'
> > > target succeeds.

Thanks for the files you sent.  Could you please try the patch below,
both with and without the Solaris patches, and see if Emacs builds in
both cases?  Thanks.

Index: src/s/sol2-5.h
===================================================================
RCS file: /cvs/emacs/src/s/sol2-5.h,v
retrieving revision 1.13
diff -c -r1.13 sol2-5.h
*** src/s/sol2-5.h	22 Nov 2000 10:37:31 -0000	1.13
--- src/s/sol2-5.h	17 Apr 2002 18:00:03 -0000
***************
*** 24,29 ****
--- 24,38 ----
  
  #undef USE_MMAP_FOR_BUFFERS
  
+ #ifdef HAVE_BCOPY
+ #undef bcopy
+ #undef bzero
+ #undef bcmp
+ #ifndef NOT_C_CODE
+ #include <strings.h>
+ #endif
+ #endif
+ 
  #if 0 /* A recent patch in unexelf.c should eliminate the need for this.  */
  /* Don't use the shared libraries for -lXt and -lXaw,
     to work around a linker bug in Solaris 2.5.

Re: Solaris 8 patches 108652-51 and 108919-14 break `make install'

[Viktor Haag]

eliz@fencepost.gnu.org (Eli Zaretskii) writes:

> Thanks for the files you sent.  Could you please try the patch
> below, both with and without the Solaris patches, and see if
> Emacs builds in both cases?  Thanks.
> 
> Index: src/s/sol2-5.h
> ===================================================================
> RCS file: /cvs/emacs/src/s/sol2-5.h,v
> retrieving revision 1.13
> diff -c -r1.13 sol2-5.h
> *** src/s/sol2-5.h	22 Nov 2000 10:37:31 -0000	1.13
> --- src/s/sol2-5.h	17 Apr 2002 18:00:03 -0000
> ***************
> *** 24,29 ****
> --- 24,38 ----
>   
>   #undef USE_MMAP_FOR_BUFFERS
>   
> + #ifdef HAVE_BCOPY
> + #undef bcopy
> + #undef bzero
> + #undef bcmp
> + #ifndef NOT_C_CODE
> + #include <strings.h>
> + #endif
> + #endif
> + 
>   #if 0 /* A recent patch in unexelf.c should eliminate the need for this.  */
>   /* Don't use the shared libraries for -lXt and -lXaw,
>      to work around a linker bug in Solaris 2.5.

I put in this patch, and my Emacs 21.2 now builds and (seems to)
run on Solaris 8. I also have installed the patches mentioned in
the subject line.

-- 
Viktor Haag : Software & Information Design : Research In Motion
                              +--+
"Yeah--I'm going to need a firm mattress, and a night light, and
                some peaches. Oh yeah! Peaches!"

Re: Solaris 8 patches 108652-51 and 108919-14 break `make install'

[Eli Zaretskii]

> Date: Thu, 18 Apr 2002 17:53:53 +0200
> From: Rabbe Fogelholm <Rabbe.Fogelholm@era-t.ericsson.se>
> 
> I have now tried out all four combinations. It turns out that building
> Emacs works in all cases except when the Solaris patches are installed
> and the sol2-5.h patch is not.

Thanks, I installed the change you tested for the next release.

Re: Solaris 8 patches 108652-51 and 108919-14 break `make install'

[Eli Zaretskii]

> Newsgroups: gnu.emacs.bug
> From: Viktor Haag <vhaag@rim.net>
> Date: 18 Apr 2002 15:00:56 -0400
> 
> I put in this patch, and my Emacs 21.2 now builds and (seems to)
> run on Solaris 8. I also have installed the patches mentioned in
> the subject line.

Thanks, this patch will be in the next release.