unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#13092: 24.3.50; regression: `icomplete-mode' does not echo key bindings
@ 2012-12-05 22:08 Drew Adams
  2014-02-10  7:33 ` Lars Ingebrigtsen
  0 siblings, 1 reply; 8+ messages in thread
From: Drew Adams @ 2012-12-05 22:08 UTC (permalink / raw)
  To: 13092

Please restore the key-binding echoes to icomplete-mode.

In GNU Emacs 24.3.50.1 (i386-mingw-nt5.1.2600)
 of 2012-12-03 on MS-W7-DANI
Bzr revision: 111077
agustin.martin@hispalinux.es-20121203172342-ifsebjmhksk28qa9
Windowing system distributor `Microsoft Corp.', version 5.1.2600
Configured using:
 `configure --with-gcc (4.7) --no-opt --enable-checking --cflags
 -Ic:/emacs/libs/libXpm-3.5.10/include -Ic:/emacs/libs/libXpm-3.5.10/src
 -Ic:/emacs/libs/libpng-1.2.37-lib/include -Ic:/emacs/libs/zlib-1.2.5
 -Ic:/emacs/libs/giflib-4.1.4-1-lib/include
 -Ic:/emacs/libs/jpeg-6b-4-lib/include
 -Ic:/emacs/libs/tiff-3.8.2-1-lib/include
 -Ic:/emacs/libs/libxml2-2.7.8-w32-bin/include/libxml2
 -Ic:/emacs/libs/gnutls-3.0.9-w32-bin/include
 -Ic:/emacs/libs/libiconv-1.9.2-1-lib/include'
 






^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#13092: 24.3.50; regression: `icomplete-mode' does not echo key bindings
  2012-12-05 22:08 bug#13092: 24.3.50; regression: `icomplete-mode' does not echo key bindings Drew Adams
@ 2014-02-10  7:33 ` Lars Ingebrigtsen
  2014-02-10 18:50   ` Drew Adams
  0 siblings, 1 reply; 8+ messages in thread
From: Lars Ingebrigtsen @ 2014-02-10  7:33 UTC (permalink / raw)
  To: Drew Adams; +Cc: 13092

"Drew Adams" <drew.adams@oracle.com> writes:

> Please restore the key-binding echoes to icomplete-mode.

This was a kinda cryptic error message.  What did you expect to see, and
what are you seeing?

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/





^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#13092: 24.3.50; regression: `icomplete-mode' does not echo key bindings
  2014-02-10  7:33 ` Lars Ingebrigtsen
@ 2014-02-10 18:50   ` Drew Adams
  2014-02-11  3:40     ` Stefan Monnier
  0 siblings, 1 reply; 8+ messages in thread
From: Drew Adams @ 2014-02-10 18:50 UTC (permalink / raw)
  To: Lars Ingebrigtsen; +Cc: 13092

> > Please restore the key-binding echoes to icomplete-mode.
> 
> This was a kinda cryptic error message.  What did you expect to see,
> and what are you seeing?

Icomplete mode used to echo the keys bound to commands matching
your input as you type the command name.  This useful feature was removed - a regression.  Please restore the feature.  Thx.





^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#13092: 24.3.50; regression: `icomplete-mode' does not echo key bindings
  2014-02-10 18:50   ` Drew Adams
@ 2014-02-11  3:40     ` Stefan Monnier
  2014-02-11  6:35       ` Drew Adams
  0 siblings, 1 reply; 8+ messages in thread
From: Stefan Monnier @ 2014-02-11  3:40 UTC (permalink / raw)
  To: Drew Adams; +Cc: Lars Ingebrigtsen, 13092

> Icomplete mode used to echo the keys bound to commands matching
> your input as you type the command name.  This useful feature was
> removed - a regression.  Please restore the feature.  Thx.

Yes, it was useful but it was completely broken, echoing this info
regardless if the minibuffer input was actually meant to represent
a command name or not.

So, to have it back, someone will have to write it in the right way,
such that the echo is only performed for M-x completion and not (for
example) for buffer name completion.


        Stefan





^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#13092: 24.3.50; regression: `icomplete-mode' does not echo key bindings
  2014-02-11  3:40     ` Stefan Monnier
@ 2014-02-11  6:35       ` Drew Adams
  2014-02-11 17:52         ` Stefan Monnier
  0 siblings, 1 reply; 8+ messages in thread
From: Drew Adams @ 2014-02-11  6:35 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: Lars Ingebrigtsen, 13092

> > Icomplete mode used to echo the keys bound to commands matching
> > your input as you type the command name.  This useful feature was
> > removed - a regression.  Please restore the feature.  Thx.
> 
> Yes, it was useful but it was completely broken, echoing this info
> regardless if the minibuffer input was actually meant to represent
> a command name or not.
> 
> So, to have it back, someone will have to write it in the right way,
> such that the echo is only performed for M-x completion and not (for
> example) for buffer name completion.

I see.  FWIW, I show the key in icomplete+.el still, and I have
never see it try to show a key for buffer-name completion (or any
other kind of completion besides command completion).

Could you give me a recipe that might show the problem?  Was there
perhaps an Emacs bug filed about that?  I'd be curious, so I can see
what happens with icomplete+.el in this regard.





^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#13092: 24.3.50; regression: `icomplete-mode' does not echo key bindings
  2014-02-11  6:35       ` Drew Adams
@ 2014-02-11 17:52         ` Stefan Monnier
  2014-02-11 18:06           ` Drew Adams
  2020-12-04 11:04           ` Lars Ingebrigtsen
  0 siblings, 2 replies; 8+ messages in thread
From: Stefan Monnier @ 2014-02-11 17:52 UTC (permalink / raw)
  To: Drew Adams; +Cc: Lars Ingebrigtsen, 13092

> Could you give me a recipe that might show the problem?

M-x icomplete-mode RET
C-x b left-char RET RET
C-x b RET
C-x b left-char

The first left-char does not output the key-binding (because the code is
only triggered for matches), but the second does (in 24.3).


        Stefan





^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#13092: 24.3.50; regression: `icomplete-mode' does not echo key bindings
  2014-02-11 17:52         ` Stefan Monnier
@ 2014-02-11 18:06           ` Drew Adams
  2020-12-04 11:04           ` Lars Ingebrigtsen
  1 sibling, 0 replies; 8+ messages in thread
From: Drew Adams @ 2014-02-11 18:06 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: Lars Ingebrigtsen, 13092

> > Could you give me a recipe that might show the problem?
> 
> M-x icomplete-mode RET
> C-x b left-char RET RET
> C-x b RET
> C-x b left-char
> 
> The first left-char does not output the key-binding (because the
> code is only triggered for matches), but the second does (in 24.3).

Got it.  Thx.  Yes, same thing with Icomplete+: key <left> is echoed.

Personally, this (rare, I would guess) minor nuisance is outweighed
by the positive help provided by showing keys for sole-match commands.

As a different user, you might feel differently about the relative
value.

The important thing is that if you restore this fine feature then
you simply give individual _users_ the choice: there was already a
user option for whether to show key bindings,
`icomplete-show-key-bindings'.  Restoring that option is of course
part of fixing the regression.





^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#13092: 24.3.50; regression: `icomplete-mode' does not echo key bindings
  2014-02-11 17:52         ` Stefan Monnier
  2014-02-11 18:06           ` Drew Adams
@ 2020-12-04 11:04           ` Lars Ingebrigtsen
  1 sibling, 0 replies; 8+ messages in thread
From: Lars Ingebrigtsen @ 2020-12-04 11:04 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: 13092

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> Could you give me a recipe that might show the problem?
>
> M-x icomplete-mode RET
> C-x b left-char RET RET
> C-x b RET
> C-x b left-char
>
> The first left-char does not output the key-binding (because the code is
> only triggered for matches), but the second does (in 24.3).

So I think this works as designed now, and I'm closing this bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2020-12-04 11:04 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-05 22:08 bug#13092: 24.3.50; regression: `icomplete-mode' does not echo key bindings Drew Adams
2014-02-10  7:33 ` Lars Ingebrigtsen
2014-02-10 18:50   ` Drew Adams
2014-02-11  3:40     ` Stefan Monnier
2014-02-11  6:35       ` Drew Adams
2014-02-11 17:52         ` Stefan Monnier
2014-02-11 18:06           ` Drew Adams
2020-12-04 11:04           ` Lars Ingebrigtsen

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).