bug#20337: authors.el needs updating before 25.1

bug#20337: authors.el needs updating before 25.1

[Glenn Morris]

Package: emacs
Version: 25.0.50

authors.el will need updating before the next release.
There's a FIXME comment, but I doubt that will get any attention.

I suspect the main problem is going be that was previously eg "files.el"
in the ChangeLog is now "lisp/files.el", which is going to make
authors.el think it refers to two separate files. Things like
authors-renamed-files-alist are set up on the basis of file names being
relative to the old per-directory C'logs. The fact that old and
new-style entries are mixed in the top-level ChangeLog.1 file is
probably going to be especially problematic.

bug#20337: authors.el needs updating before 25.1

[Glenn Morris]

Since authors.el is getting some attention of late, I just wanted to
remind about the following.

Glenn Morris wrote:

> authors.el will need updating before the next release.
> There's a FIXME comment, but I doubt that will get any attention.
>
> I suspect the main problem is going be that was previously eg "files.el"
> in the ChangeLog is now "lisp/files.el", which is going to make
> authors.el think it refers to two separate files. Things like
> authors-renamed-files-alist are set up on the basis of file names being
> relative to the old per-directory C'logs.

[...]

> The fact that old and new-style entries are mixed in the top-level
> ChangeLog.1 file is probably going to be especially problematic.

This last point no longer applies.

bug#20337: authors.el needs updating before 25.1

[Nicolas Petton]

[-- Attachment #1: Type: text/plain, Size: 209 bytes --]

Glenn Morris <rgm@gnu.org> writes:

> Since authors.el is getting some attention of late, I just wanted to
> remind about the following.

Thanks, I'll be careful about this and fix authors.el if needed.

Nico

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 512 bytes --]

bug#20337: authors.el needs updating before 25.1

[Glenn Morris]

Thanks, it's good of you to look at this. (I'm not sure how easy it will be...)

bug#20337: authors.el needs updating before 25.1

[Nicolas Petton]

[-- Attachment #1: Type: text/plain, Size: 498 bytes --]

Glenn Morris <rgm@gnu.org> writes:

>> authors.el will need updating before the next release.
>> There's a FIXME comment, but I doubt that will get any attention.
>>
>> I suspect the main problem is going be that was previously eg "files.el"
>> in the ChangeLog is now "lisp/files.el", which is going to make
>> authors.el think it refers to two separate files.

I updated etc/AUTHORS last week with authors.el, and double-checked
this, but I couldn't find any issue with the generated file.

Nico

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 512 bytes --]

bug#20337: authors.el needs updating before 25.1

[Glenn Morris]

Nicolas Petton wrote:

> Glenn Morris <rgm@gnu.org> writes:
>
>>> I suspect the main problem is going be that was previously eg "files.el"
>>> in the ChangeLog is now "lisp/files.el", which is going to make
>>> authors.el think it refers to two separate files.
>
> I updated etc/AUTHORS last week with authors.el, and double-checked
> this, but I couldn't find any issue with the generated file.

I'm surprised, but maybe authors-canonical-file-name means it works
itself out? If a test with a dummy tree with only two separate
ChangeLogs, one in lisp/ containing an entry for "files.el", and
one in top-level with an entry for "lisp/files.el", results in an
AUTHORS file with just a single changed file, then maybe it all Just
Works...

bug#20337: authors.el needs updating before 25.1

[Nicolas Petton]

[-- Attachment #1: Type: text/plain, Size: 2098 bytes --]

Glenn Morris <rgm@gnu.org> writes:

> Nicolas Petton wrote:
>
>> Glenn Morris <rgm@gnu.org> writes:
>>
>>>> I suspect the main problem is going be that was previously eg "files.el"
>>>> in the ChangeLog is now "lisp/files.el", which is going to make
>>>> authors.el think it refers to two separate files.
>>
>> I updated etc/AUTHORS last week with authors.el, and double-checked
>> this, but I couldn't find any issue with the generated file.
>
> I'm surprised, but maybe authors-canonical-file-name means it works
> itself out? If a test with a dummy tree with only two separate
> ChangeLogs, one in lisp/ containing an entry for "files.el", and
> one in top-level with an entry for "lisp/files.el", results in an
> AUTHORS file with just a single changed file, then maybe it all Just
> Works...

It seems to be the case, for instance, in lisp/ChangeLog.17 contains:

    2015-04-05  Pete Williamson  <petewil@chromium.org>  (tiny-change)
    
    	Fix .emacs and .emacs.d/init file recursion problem for NaCl
    	* files.el (file-truename): Add NaCl to the exception list ms-dos uses.

and ChangeLog also has many references to lisp/files.el, like the
following one:

    2016-01-16  Artur Malabarba  <bruce.connor.am@gmail.com>

	* lisp/files.el (dir-locals--all-files): Respect absolute file-names

	* lisp/help-fns.el (describe-variable): Fix a left-over parenthesis


The resulting etc/AUTHORS file contains the following entries:

    Artur Malabarba: wrote character-fold-tests.el faces-tests.el
      isearch-tests.el let-alist.el simple-test.el sort-tests.el
      tabulated-list-test.el
    and changed package.el isearch.el character-fold.el files.el
      tabulated-list.el package-test.el faces.el files-x.el menu-bar.el
      replace.el align.el bytecomp.el help-fns.el cl-lib-tests.el custom.el
      custom.texi map.el simple.el subr-tests.el variables.texi bindings.el
      and 37 other files

   [...]
   
    Pete Williamson: changed configure.ac files.el leim/Makefile.in
      lib-src/Makefile.in lisp/Makefile.in

Nico

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 512 bytes --]

bug#20337: authors.el needs updating before 25.1

[Glenn Morris]

Well, I must have been worried about nothing.
Thank you for checking, and I'm sorry for the noise.