From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Randy Taylor Newsgroups: gmane.emacs.bugs Subject: bug#59445: 29.0.50; Tweak tree sitter faces in Java and TypeScript Date: Tue, 22 Nov 2022 22:31:47 +0000 Message-ID: <8jAFlf0dCG5QH3h6OnxdRHn-1Hn1n0MRxqOS7DZG5P9FvrZQyB58k5VuIzArBeOWtANYw44vWHXs_8VBbf-2a7Bo7GCjdwESAyMHT4uu9s4=@rjt.dev> References: <87a64k8pzu.fsf@thornhill.no> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10638"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59445@debbugs.gnu.org, Theodor Thornhill To: Yuan Fu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 22 23:32:42 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oxboo-0002ZP-65 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 22 Nov 2022 23:32:42 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oxboR-0007Ad-6k; Tue, 22 Nov 2022 17:32:19 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oxboD-00077P-KG for bug-gnu-emacs@gnu.org; Tue, 22 Nov 2022 17:32:06 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oxboC-0000OF-Ks for bug-gnu-emacs@gnu.org; Tue, 22 Nov 2022 17:32:05 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oxboC-0000j5-GU for bug-gnu-emacs@gnu.org; Tue, 22 Nov 2022 17:32:04 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Randy Taylor Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Nov 2022 22:32:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59445 X-GNU-PR-Package: emacs Original-Received: via spool by 59445-submit@debbugs.gnu.org id=B59445.16691563232783 (code B ref 59445); Tue, 22 Nov 2022 22:32:04 +0000 Original-Received: (at 59445) by debbugs.gnu.org; 22 Nov 2022 22:32:03 +0000 Original-Received: from localhost ([127.0.0.1]:52815 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxboB-0000ij-BL for submit@debbugs.gnu.org; Tue, 22 Nov 2022 17:32:03 -0500 Original-Received: from mail-4317.proton.ch ([185.70.43.17]:28905) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxbo8-0000i0-MS for 59445@debbugs.gnu.org; Tue, 22 Nov 2022 17:32:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail2; t=1669156313; x=1669415513; bh=f0KqoOcm5vSst2HLTfM055ippU+WovJtk/vqhrDaMpU=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=FZxs42/99rZJ/QP6dHuqZh33W7sOnaOxaxNJe9f4lywj8eYexUP0Y+mN1WXXxps2A 8INB807bpV+rCym6rTticu0b20XxHhhPtISnGg/VgepFcTJN/c2QTjndOr1n9SRjGe wew2hUdb4VKa7xWpnCgbVFPyk1LCIvgdo6Vw4pfw2ysYV1wTZseHwBx7vvmiTFB8HP IKjhhA2O9p2K8W7IMfZ0qVgwjTiv+ZbnMec583yDgu7Qr6HbgLSRhKVmzWtKPM0fU8 SBc8U7TlQ1IvJMVDvBSkJVeXYHpnrXmb3ysHU2WIC1srfJvXDQ2NHQChgMzoPs4SAA IXdWRpgl5Brgg== In-Reply-To: Feedback-ID: 44397038:user:proton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248687 Archived-At: On Tuesday, November 22nd, 2022 at 05:08, Yuan Fu via "Bug reports for GNU = Emacs, the Swiss army knife of text editors" wrote: >=20 > Randy Taylor dev@rjt.dev writes: >=20 > > On Monday, November 21st, 2022 at 07:13, Theodor Thornhill via "Bug > > reports for GNU Emacs, the Swiss army knife of text editors" > > bug-gnu-emacs@gnu.org wrote: > >=20 > > > Hi Yuan! > > >=20 > > > I tweaked Java and TypeScript a little. > > >=20 > > > Feel free to apply when you have the time :) > > >=20 > > > Theo >=20 >=20 > Thanks, I just applied this patch. >=20 > > Looks good. > >=20 > > For java-ts-mode.el can you show examples of what bracket and > > delimiter highlight with your changes? I couldn't get them to > > highlight anything when I tested and I had the exact same queries as > > you, hence why I left them out of my patch. Similar thing occurred > > with sh-script.el. >=20 >=20 > Have you tried using treesit-query-capture to "manually" capture these > nodes? I always use >=20 > (treesit-query-capture (treesit-buffer-root-node) (region-beginni= ng) (region-end)) >=20 >=20 > Yuan >=20 No, I've never tried that before. But I found out what the problem was: '(["(" ")" "[" "]" "{" "}"] @font-lock-bracket-face) The above query works fine for javascript and typescript, but not for java.= Java needs it to be (note the parens surrounding the brackets): '((["(" ")" "[" "]" "{" "}"]) @font-lock-bracket-face)