From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#35624: log-view-diff regression Date: Mon, 17 Jun 2019 16:48:55 +0300 Message-ID: <8fb39318-1416-582b-7fb6-6d5b20c9ec0a@yandex.ru> References: <87pnou2ak2.fsf@mail.linkov.net> <9e4ac5c6-af62-f907-dc30-a85a1ba6bd23@yandex.ru> <87y33a3x6k.fsf@mail.linkov.net> <87bm04vky9.fsf@mail.linkov.net> <5a4d3875-5cb5-bc84-c72e-d1840aa8d7c3@yandex.ru> <87lfz7o05l.fsf@mail.linkov.net> <8c724814-923f-351a-686c-9f9c11468187@yandex.ru> <878sv6jhdm.fsf@mail.linkov.net> <8736laqk5e.fsf@mail.linkov.net> <5d7923e8-d39c-61cb-f1a6-fd9076fafae6@yandex.ru> <87lfyzy3c1.fsf@mail.linkov.net> <87y32zv6i6.fsf@mail.linkov.net> <87r28o3mnm.fsf@mail.linkov.net> <6b924be6-770e-a011-79c7-8278ff76005a@yandex.ru> <87v9xzd948.fsf@mail.linkov.net> <3b1817fd-6b81-2673-921f-b1e7c411203e@yandex.ru> <87tvdfem02.fsf@mail.linkov.net> <2f46c05d-a656-b791-dcec-cb705f6bf955@yandex.ru> <87fto98e5q.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="3837"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 Cc: 35624@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jun 17 15:57:46 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hcs8n-0000t9-8q for geb-bug-gnu-emacs@m.gmane.org; Mon, 17 Jun 2019 15:57:45 +0200 Original-Received: from localhost ([::1]:47744 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hcs8m-0005kA-Ao for geb-bug-gnu-emacs@m.gmane.org; Mon, 17 Jun 2019 09:57:44 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34030) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hcs1L-0006sS-Fa for bug-gnu-emacs@gnu.org; Mon, 17 Jun 2019 09:50:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hcs1K-0003Iy-8o for bug-gnu-emacs@gnu.org; Mon, 17 Jun 2019 09:50:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56866) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hcs1K-0003Ik-3m for bug-gnu-emacs@gnu.org; Mon, 17 Jun 2019 09:50:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hcs1J-00063M-Us for bug-gnu-emacs@gnu.org; Mon, 17 Jun 2019 09:50:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 17 Jun 2019 13:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35624 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35624-submit@debbugs.gnu.org id=B35624.156077934623194 (code B ref 35624); Mon, 17 Jun 2019 13:50:01 +0000 Original-Received: (at 35624) by debbugs.gnu.org; 17 Jun 2019 13:49:06 +0000 Original-Received: from localhost ([127.0.0.1]:42177 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hcs0Q-000622-Ee for submit@debbugs.gnu.org; Mon, 17 Jun 2019 09:49:06 -0400 Original-Received: from mail-wm1-f48.google.com ([209.85.128.48]:51790) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hcs0P-00061Y-43 for 35624@debbugs.gnu.org; Mon, 17 Jun 2019 09:49:05 -0400 Original-Received: by mail-wm1-f48.google.com with SMTP id 207so9370168wma.1 for <35624@debbugs.gnu.org>; Mon, 17 Jun 2019 06:49:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Sm3DwBXfzlG1Rs8/yraXgpclQ2LfhCq04EMTv8d3j8k=; b=vM+rIFKfkqgaeCImmOahpMQWmPTXjSiAZLCN/TWJ6xUfYRL9z27mbjj9AMZE8UiDNC UVf3FJJfl3xXUbnDxTnl4n0k1ITiVNO8hu505HFb2bOY1WKsUurOkR9SXjxxsI9U0Bo1 tQIo8eHdxQpCFpZTYCiyDqbVpO3OdYO9vldZE+024P1TMuQPXo/MGee9DPVmItUlfFvA 4UHVFxFHBEhyVwanb5PHjeHcQimHffmOAMeOlkbAzrGDd8y/CEf5a375+lb+2JfOJgAn tGHNZOMHvAv/HgyLPpRtGelAMSg4+rlWRuWObUVnVu5ILpQFrKFjtEAFZpa3k4HSp08e r89g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Sm3DwBXfzlG1Rs8/yraXgpclQ2LfhCq04EMTv8d3j8k=; b=DcP46kpyl2lnBzyZigrxl10oTqT5j3jsIKqHDCBqxxuvXnRQB2SO90e/fYT58JG26y 8yID7N3TPgLKr/ESYIL+vxnXbZEiUIvNVAFsQXqeoiDsYaTJJ5WSC7fFVSVNP2bVsly6 QD8lqcpdw18Er/kar6l44jw0Zcb630QIQR2SrvxDJ3JPfpZP+rWzf36ALDMvlxlPGXwU wZe4iDgWUqLx0lsm/DkBYr5TJMaAkthL05B0VOy5Bdourg20WjfpKhOvXX7OTpKtyMqR YtNNrKVpabP1TdRaOz2y9FRgQbJ5ZR7uIQGrPQpirZAlFhrnIi4YMj842MCsJXAn65gd nV/Q== X-Gm-Message-State: APjAAAULltLjetjLRo4LznEq2JRaog7frYnBG2PW26JdPx+Nkio9CYBU lc4OwLtwhqnkz/M/bJKvHjgie4Z6Iuk= X-Google-Smtp-Source: APXvYqzcuRuESKg9OHe+6OPtI8kP182Ir3pF6pkLgY+7E7aYAhwNJl9OPwcfb7f+/KTU+S66osXRlA== X-Received: by 2002:a1c:b1d5:: with SMTP id a204mr10986997wmf.101.1560779338572; Mon, 17 Jun 2019 06:48:58 -0700 (PDT) Original-Received: from [192.168.1.3] ([185.105.174.23]) by smtp.googlemail.com with ESMTPSA id n3sm7595443wro.59.2019.06.17.06.48.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 17 Jun 2019 06:48:57 -0700 (PDT) In-Reply-To: <87fto98e5q.fsf@mail.linkov.net> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:160730 Archived-At: On 16.06.2019 23:13, Juri Linkov wrote: >> Speaking about this approach... What happens when the whole log buffer is >> shorter than the window it's displayed in? > > It was difficult for me to test this case because I rely heavily on ediff > for development, but ediff has been broken for a week in master. > It makes sense to revert changes that break some function completely > because currently ediff is unusable giving this error: That's unfortunate, but I never use it. Maybe file a bug? > But I tried to do ediff's work manually, and can confirm now that > when the whole log buffer is shorter than the window then the patch > from bug#35860 still works correctly hiding the first line initially. Great news. I wonder if it would still trip up people who use C-v/M-v sometimes. But a defcustom would solve that, anyway.