From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#60845: 30.0.50; [PATCH] Add tests for Eshell interactive completion (and fix a bug in it) Date: Sun, 29 Jan 2023 23:14:49 -0800 Message-ID: <8f725450-1158-67de-7a0f-d550d867e084@gmail.com> References: <2b75d4d4-0533-2182-6da8-413391577bf5@gmail.com> <40d31b3d-d429-5a48-02bc-a3c1e4a1d903@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34094"; mail-complaints-to="usenet@ciao.gmane.io" Cc: monnier@iro.umontreal.ca To: 60845@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jan 30 08:15:31 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pMOO3-0008hd-Dc for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 30 Jan 2023 08:15:31 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pMONi-0000o0-CN; Mon, 30 Jan 2023 02:15:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMONb-0000lr-5g for bug-gnu-emacs@gnu.org; Mon, 30 Jan 2023 02:15:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pMONa-0000un-Tc for bug-gnu-emacs@gnu.org; Mon, 30 Jan 2023 02:15:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pMONa-0001Rh-79; Mon, 30 Jan 2023 02:15:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: monnier@iro.umontreal.ca, bug-gnu-emacs@gnu.org Resent-Date: Mon, 30 Jan 2023 07:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60845 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-Xcc: monnier@iro.umontreal.ca Original-Received: via spool by 60845-submit@debbugs.gnu.org id=B60845.16750628995538 (code B ref 60845); Mon, 30 Jan 2023 07:15:02 +0000 Original-Received: (at 60845) by debbugs.gnu.org; 30 Jan 2023 07:14:59 +0000 Original-Received: from localhost ([127.0.0.1]:46187 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMONX-0001RF-7Q for submit@debbugs.gnu.org; Mon, 30 Jan 2023 02:14:59 -0500 Original-Received: from mail-pj1-f44.google.com ([209.85.216.44]:33356) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMONT-0001Qx-U1 for 60845@debbugs.gnu.org; Mon, 30 Jan 2023 02:14:57 -0500 Original-Received: by mail-pj1-f44.google.com with SMTP id v6-20020a17090ad58600b00229eec90a7fso12936310pju.0 for <60845@debbugs.gnu.org>; Sun, 29 Jan 2023 23:14:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:references:to:from :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=R/I9RMag2VQ05muD4bDRZ1tNy2ZNydrlwb9XPBUDtQo=; b=WmNlzN3s6gPR4ZeMlSR8RNhkaIRg6NqK75h5iipgibOxAmU/rbEGJddESl78bCz+SU DlzDoniJlX9v2M4T3OqP1nRVUTZYDDqN6hPylOBgknsmFxDsYVMxqGunshPTtZrvl9iL siB/5GeQOs3roxlHzZuaqbcOZ6HkNh+H0G9jzypldXVqj2/SWdPjXAJyJOSjLwghisCi L4EK1cfjlqXwiA3ut+5tG+1LXLi0HNw2opoapCTbdZ5WOp4fQmtWTGVGKp6jZG59cuBs JAh8NU7bF3bFRrUuVE4qYa03whSJ4JojD2xgGjd3O2M0FZEpmxZSn7xrRXtahcXmfMxc T4Qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:references:to:from :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=R/I9RMag2VQ05muD4bDRZ1tNy2ZNydrlwb9XPBUDtQo=; b=fdVa2GmiqcVsjGcD+eI8hcXYmOcpWzgZHJKRdgUcVvWK0Bs+pdjEnIaS0VpSf1qHV0 4grtfHMXTODPFnbQoqVjB26Qpci03apRsX6T1lcyeXdTTAHJO1s6djvJnKMBzyFQKbSN dBic/CcCkHU+XoaQJF3q7ZsDtNExT/F31/RcyzsQu3vvWvAUQHqNmctzCKzOoh1f+lCl zmYMBltDqH5xgYME/u2Zp26TZxtiG1VEqTvnOADrP0zm1CoWov7XmG8mvFj49WbrH/h1 ydaDv2m+GE9LlGDln1SGwfMyr0AMQOGSrPjipwoKU/Dqn6YfcBRIZlV82Q2ELpluhw1r uj1A== X-Gm-Message-State: AO0yUKUUaAIw3gT2Vxo3C4ll1E87WKgubbuNsRdHopT8v4LnxrsbrciB NH5F3r+YrjaThpPtF2Of3ucnq3mc8kvjSQ== X-Google-Smtp-Source: AK7set9zy7AkWVX+Bh/Z2X3KABm2zCtyfMqvnFWl0KEf0BRPALHCM8jl/eNN9l4ELeqkqTu9LNFUYQ== X-Received: by 2002:a17:90b:1c02:b0:22c:1bd4:1814 with SMTP id oc2-20020a17090b1c0200b0022c1bd41814mr17462158pjb.37.1675062890039; Sun, 29 Jan 2023 23:14:50 -0800 (PST) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id i130-20020a636d88000000b00477def759cbsm6173503pgc.58.2023.01.29.23.14.49 for <60845@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 29 Jan 2023 23:14:49 -0800 (PST) Content-Language: en-US In-Reply-To: <40d31b3d-d429-5a48-02bc-a3c1e4a1d903@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:254392 Archived-At: X-Debbugs-Cc: monnier@iro.umontreal.ca On 1/22/2023 1:35 PM, Jim Porter wrote: > On 1/22/2023 1:34 PM, Jim Porter wrote: >> The third patch in this series fixes this for the Eshell side, so we >> could probably remove the workaround in pcomplete.el for Emacs 30. Stefan, do you have any thoughts on these changes, especially the third patch? I did a bit of tinkering with pcomplete functions, and I think it should be ok for the Eshell side of things. Eshell-specific pcomplete functions can get the real value if they need by examining the 'pcomplete-arg-value' string property. For pcomplete functions that aren't Eshell-specific, they'll always get the string form of arguments by default, so things should Just Work there.