From: Jim Porter <jporterbugs@gmail.com>
To: 60845@debbugs.gnu.org
Cc: monnier@iro.umontreal.ca
Subject: bug#60845: 30.0.50; [PATCH] Add tests for Eshell interactive completion (and fix a bug in it)
Date: Sun, 29 Jan 2023 23:14:49 -0800 [thread overview]
Message-ID: <8f725450-1158-67de-7a0f-d550d867e084@gmail.com> (raw)
In-Reply-To: <40d31b3d-d429-5a48-02bc-a3c1e4a1d903@gmail.com>
X-Debbugs-Cc: monnier@iro.umontreal.ca
On 1/22/2023 1:35 PM, Jim Porter wrote:
> On 1/22/2023 1:34 PM, Jim Porter wrote:
>> The third patch in this series fixes this for the Eshell side, so we
>> could probably remove the workaround in pcomplete.el for Emacs 30.
Stefan, do you have any thoughts on these changes, especially the third
patch? I did a bit of tinkering with pcomplete functions, and I think it
should be ok for the Eshell side of things. Eshell-specific pcomplete
functions can get the real value if they need by examining the
'pcomplete-arg-value' string property.
For pcomplete functions that aren't Eshell-specific, they'll always get
the string form of arguments by default, so things should Just Work there.
next prev parent reply other threads:[~2023-01-30 7:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-16 1:50 bug#60845: 30.0.50; [PATCH] Add tests for Eshell interactive completion (and fix a bug in it) Jim Porter
2023-01-22 21:34 ` Jim Porter
2023-01-22 21:35 ` Jim Porter
2023-01-30 7:14 ` Jim Porter [this message]
2023-01-30 14:54 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-31 2:00 ` Jim Porter
2023-09-05 23:36 ` Stefan Kangas
2023-09-06 0:47 ` Jim Porter
2023-09-06 1:37 ` Jim Porter
2023-10-10 20:07 ` Jim Porter
2023-10-10 21:23 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f725450-1158-67de-7a0f-d550d867e084@gmail.com \
--to=jporterbugs@gmail.com \
--cc=60845@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).