From: Ovidiu Toader <ovi@phas.ubc.ca>
To: 42906@debbugs.gnu.org
Subject: bug#42906: [feature/native-comp] out-of-tree build process broken
Date: Mon, 17 Aug 2020 08:16:26 -0700 [thread overview]
Message-ID: <8f6a8257-6ecb-6c14-c41e-142ad9dfb441@phas.ubc.ca> (raw)
When feature/native-comp branch is built out-of-tree, emacs cannot find the .eln files during start.
The patch below fixes this issue. The problem is caused by the fact that during an out-of-tree build, default-directory points inside the build tree while the .eln files are found in the source tree and because of that the subsequent replace-regexp-in-string fails to adjust the file path of the compilation unit.
modified lisp/loadup.el
@@ -454,7 +454,7 @@
;; when installed or if the source directory got moved. This is set to be
;; a pair in the form: (rel-path-from-install-bin . rel-path-from-local-bin).
(let ((h (make-hash-table :test #'eq))
- (lisp-src-dir (expand-file-name (concat default-directory "../lisp")))
+ (lisp-src-dir (expand-file-name "lisp" source-directory))
(bin-dest-dir (cadr (member "--bin-dest" command-line-args)))
(lisp-dest-dir (cadr (member "--lisp-dest" command-line-args))))
(mapatoms (lambda (s)
next reply other threads:[~2020-08-17 15:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-17 15:16 Ovidiu Toader [this message]
2020-08-17 18:49 ` bug#42906: [feature/native-comp] out-of-tree build process broken Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-08-18 4:22 ` Ovidiu Toader
2020-08-18 7:24 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f6a8257-6ecb-6c14-c41e-142ad9dfb441@phas.ubc.ca \
--to=ovi@phas.ubc.ca \
--cc=42906@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).