From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#39452: [PATCH] vc-git-state fails for filenames with wildcards Date: Fri, 7 Feb 2020 11:43:36 +0300 Message-ID: <8f427281-510c-30c3-995f-364e22d9c1e2@yandex.ru> References: <83h802g77h.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="30769"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 Cc: 39452@debbugs.gnu.org, Wolfgang.Scherer@gmx.de To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Feb 07 09:44:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1izzFD-0007sw-Fr for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 07 Feb 2020 09:44:11 +0100 Original-Received: from localhost ([::1]:52374 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1izzFC-00033Z-BQ for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 07 Feb 2020 03:44:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52762) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1izzF5-00033Q-FW for bug-gnu-emacs@gnu.org; Fri, 07 Feb 2020 03:44:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1izzF4-0005wP-Fq for bug-gnu-emacs@gnu.org; Fri, 07 Feb 2020 03:44:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42903) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1izzF4-0005wL-CU for bug-gnu-emacs@gnu.org; Fri, 07 Feb 2020 03:44:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1izzF4-000879-8i for bug-gnu-emacs@gnu.org; Fri, 07 Feb 2020 03:44:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 07 Feb 2020 08:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39452 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 39452-submit@debbugs.gnu.org id=B39452.158106502731162 (code B ref 39452); Fri, 07 Feb 2020 08:44:02 +0000 Original-Received: (at 39452) by debbugs.gnu.org; 7 Feb 2020 08:43:47 +0000 Original-Received: from localhost ([127.0.0.1]:48876 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1izzEo-00086Y-KU for submit@debbugs.gnu.org; Fri, 07 Feb 2020 03:43:46 -0500 Original-Received: from mail-lf1-f65.google.com ([209.85.167.65]:43166) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1izzEm-00086J-L9 for 39452@debbugs.gnu.org; Fri, 07 Feb 2020 03:43:45 -0500 Original-Received: by mail-lf1-f65.google.com with SMTP id 9so974058lfq.10 for <39452@debbugs.gnu.org>; Fri, 07 Feb 2020 00:43:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=7gR4P6UdQFsdcord911udul5UZ6RvaWOiZ6KvhvHXUA=; b=P90sR5qvEDU5my/LvJEzPvwdSuUFadqfF3mMagwmiVwXF14ECAhBuFBOj3HDodS3pZ cAqYmR1PMF4tnqE73a3/wOFCAbHoSItuBLkXEj5wXDOwhrHq4KACxEXo56NeFEooGk5O CMzNOY0wZwduKH6PNMLRriB48+R002hLOBHH/TchoVCxiwZgx8TEOWP6w0Rw8BPEZ3Ge MkQlh9XMF75nI89Gq5RtfIpzvvE/BlWEAfwA3E8OE4KoiYdCIevba9JlHITK8fSV25MH 4ena/qdlYkxGcffZrXP+cV/3zDQKPDWYTZQCtjl/kiZ5D2inCuc0rB1k+u8FQ/+F4Svx 6pvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=7gR4P6UdQFsdcord911udul5UZ6RvaWOiZ6KvhvHXUA=; b=l9uKMIokH241qcEll1hYf/y0EANQgnyiLAQdYbG09F+yIK09fi5BXb5NxZxNI/Qyav JJzZ4eicKJqkebYQp0bHCfZNkhMo0zhgXkAMtYRbuKxIwaBZpPTOE4oz+tuQiHxUGq8d Ue4TkRmVsqIHZPhsbAmgoZ4MyJ94iuVtFOW1lT8fpWFV2YlNmeTorZv5Dm3lgwCG0JfX 5SOue+CDU7bqgVFGakkqtgjUQcFpv00iRy7T6Df1YFQ/vUCi+bKjIXUSl/pLzqIRVYYW KQMNzLootYFIc3RviCPFoARkbGxNoy86+6btzkYvzgxqVG3ErgzuST4nnYeMPTU3nFh2 v7/w== X-Gm-Message-State: APjAAAXQ56uJsB9D0qDURIrJsqkr9D67+SBgdPI/0QThFqY93Xv2GH9A sW+mYYO9lvorL9PxhNeR6WY= X-Google-Smtp-Source: APXvYqwS3eIsjMyozvDvZ4hcZ60RrVwBAQxPqpcH2rZ9oO4N0FxXWA4YF2/GvKCW/0iYAga1+0RfVw== X-Received: by 2002:ac2:52a3:: with SMTP id r3mr3978590lfm.189.1581065018515; Fri, 07 Feb 2020 00:43:38 -0800 (PST) Original-Received: from [192.168.1.142] ([178.252.127.239]) by smtp.googlemail.com with ESMTPSA id i20sm749188lfl.79.2020.02.07.00.43.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 07 Feb 2020 00:43:37 -0800 (PST) In-Reply-To: <83h802g77h.fsf@gnu.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:175740 Archived-At: On 07.02.2020 10:57, Eli Zaretskii wrote: >> From: Dmitry Gutov >> Date: Fri, 7 Feb 2020 02:00:38 +0300 >> >> I wonder how many other backends commands are broken for files like >> that: we basically never shell-quote file names. > > Whenever we run commands via the shell, the prudent thing is to always > quote file names (and in general any argument that might include > wildcard characters). One advantage of call-process is that you don't > have to do that. It's not so simple. FILE already goes through call-process. But Git expects a pathspec, not just a file name. So if it's a glob, it is expanded.