From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#22147: Obsolete search-forward-lax-whitespace Date: Sun, 15 May 2016 14:51:35 -0700 (PDT) Message-ID: <8e655300-1a72-4df6-87cf-91fd006cb3d7@default> References: <87wpsk7dcs.fsf@mail.linkov.net> <87d1ubz3w9.fsf@mail.linkov.net> <87r3ipoofk.fsf@mail.linkov.net> <87zixcblno.fsf@mail.linkov.net> <874mfjchp1.fsf@mail.linkov.net> <87r3d4z7uf.fsf@mail.linkov.net> <8ec0f5d4-a500-42c1-bab8-eaba00f0915c@default> <87shxjjb0h.fsf@mail.linkov.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1463349153 15055 80.91.229.3 (15 May 2016 21:52:33 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 15 May 2016 21:52:33 +0000 (UTC) Cc: 22147@debbugs.gnu.org, Artur Malabarba To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun May 15 23:52:16 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1b23xP-0005qv-Am for geb-bug-gnu-emacs@m.gmane.org; Sun, 15 May 2016 23:52:15 +0200 Original-Received: from localhost ([::1]:41553 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b23xL-00049Y-GF for geb-bug-gnu-emacs@m.gmane.org; Sun, 15 May 2016 17:52:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40762) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b23xH-00040v-Ib for bug-gnu-emacs@gnu.org; Sun, 15 May 2016 17:52:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b23xD-0000eo-8D for bug-gnu-emacs@gnu.org; Sun, 15 May 2016 17:52:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:40712) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b23xD-0000ei-2V for bug-gnu-emacs@gnu.org; Sun, 15 May 2016 17:52:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1b23xC-00027A-Tk for bug-gnu-emacs@gnu.org; Sun, 15 May 2016 17:52:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 15 May 2016 21:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22147 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 22147-submit@debbugs.gnu.org id=B22147.14633491138103 (code B ref 22147); Sun, 15 May 2016 21:52:02 +0000 Original-Received: (at 22147) by debbugs.gnu.org; 15 May 2016 21:51:53 +0000 Original-Received: from localhost ([127.0.0.1]:53048 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b23x3-00026d-6L for submit@debbugs.gnu.org; Sun, 15 May 2016 17:51:53 -0400 Original-Received: from userp1040.oracle.com ([156.151.31.81]:51754) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b23wx-00026I-9o for 22147@debbugs.gnu.org; Sun, 15 May 2016 17:51:51 -0400 Original-Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id u4FLpdkO028616 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 15 May 2016 21:51:40 GMT Original-Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserv0021.oracle.com (8.13.8/8.13.8) with ESMTP id u4FLpdO0024805 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 15 May 2016 21:51:39 GMT Original-Received: from abhmp0003.oracle.com (abhmp0003.oracle.com [141.146.116.9]) by aserv0122.oracle.com (8.13.8/8.13.8) with ESMTP id u4FLpa7Z013000; Sun, 15 May 2016 21:51:37 GMT In-Reply-To: <87shxjjb0h.fsf@mail.linkov.net> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6744.5000 (x86)] X-Source-IP: aserv0021.oracle.com [141.146.126.233] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:118270 Archived-At: > EmacsWiki is inaccessible to me due to its invalid server certificate. I see. I don't know anything about that. > But thanks for pointing to EmacsMirror - I found your code at > https://github.com/emacsmirror/character-fold-plus > https://github.com/emacsmirror/isearch-plus > which I hope is at the latest version. Yes, I just checked, and those are the latest versions. I don't know how often EmacsMirror is updated. For a while (a year or two ago, I think) I think it was not mirroring. You can always get my code from MELPA, which refreshes from EmacsWiki daily. > > 2. More importantly, what I wrote in `character-fold+.el' worked > > only at the time I wrote it and for a while thereafter, unfortunately. > > Not too long after that, Artur Malabarba rewrote `character-fold.el', > > so the code I wrote is no longer appropriate. >=20 > I see that you just moved the hard-coded alist to defcustom > char-fold-ad-hoc. Correct. You can see how I use it. I broke up some of the character-fold.el code (at the time), in order to use parts of it (a bit more modular). Mainly, I broke out `update-char-fold-table' so that it could be called in the :set functions of the two defcustoms. So as soon as a user made changes, they were reflected in the behavior. > I think that char-fold-ad-hoc is too ad-hoc naming. > Using more wide-spread naming convention with a data type suffix -alist > (like in display-buffer-alist, etc.) would provide a defcustom name > char-fold-alist. OK. FWIW, I'm not a fan of putting the type ("alist") in the option name, but I don't speak for what vanilla Emacs does. If all we can say about some value is that it takes the _form_ of an alist, that's too bad. Normally, we should be able to describe that value (content, not just form). It's better, IMO, if the name talks about what the value is (content, purpose - something specific about it), and not just say form it takes. Another consideration (for me, at least): I think (and hope) that eventually users will be able to have multiple such lists (sets) of char mappings that they can choose (and mix and match - sets of such sets, for different purposes/contexts). IOW, I don't see just a single set of ad-hoc char mappings. But this is anyway for the future. > Another thing we need to do is to allow customization to remove > default mappings. Maybe this is possible by using the same > defcustom with a rule like: remove default mappings when a char > is mapped to an empty list, e.g. >=20 > - adding more mappings for =E2=80=98`=E2=80=99: > (defcustom char-fold-ad-hoc '((?` "=E2=9D=9B" "=E2=80=98" "=E2=80=9B" "= =F3=A0=80=A2" "=E2=9D=AE" "=E2=80=B9")) >=20 > - removing default mappings for =E2=80=98`=E2=80=99: > (defcustom char-fold-ad-hoc '((?`)) Yes, I would think that would work (already). But I could be wrong. Thanks for taking a look at this.