From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#55696: 28.1; eshell fails to respect text-scale-increase Date: Thu, 9 Jun 2022 15:14:22 -0700 Message-ID: <8e4fc184-8ca1-8094-f37d-f77d0cbb337c@gmail.com> References: <37af046b-4257-6370-c765-9290eae73fd4@gmail.com> <831qw6dzra.fsf@gnu.org> <0278e759-237b-a32b-4b1f-fbdacf39c8ef@gmail.com> <83pmjpar0x.fsf@gnu.org> <9e8a8b42-2f42-3027-2ec0-97744bb91911@gmail.com> <83sfoja2xp.fsf@gnu.org> <34062848-8fe4-351c-df63-5cc341fefa57@gmail.com> <83sfoj7x6f.fsf@gnu.org> <83ee027yjc.fsf@gnu.org> <2b86123e-76c1-ec0c-c767-7d821473e5e1@gmx.at> <86a0c66e-86f9-6bd6-2010-eb1cf2d9f1e6@gmail.com> <83a6am47v6.fsf@gnu.org> <4abda9a0-7c34-cdad-fc9e-a6dc25e7c74b@gmail.com> <837d5p3hr7.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------395EB1FE85DAF701C4BB6449" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27230"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 55696@debbugs.gnu.org, jeff.kowalski@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jun 10 00:15:18 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nzQQw-0006yC-6A for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 10 Jun 2022 00:15:18 +0200 Original-Received: from localhost ([::1]:60202 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nzQQv-0005gA-4H for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 09 Jun 2022 18:15:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35308) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nzQQh-0005du-3H for bug-gnu-emacs@gnu.org; Thu, 09 Jun 2022 18:15:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54244) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nzQQg-0007lO-2a for bug-gnu-emacs@gnu.org; Thu, 09 Jun 2022 18:15:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nzQQf-000879-Nk for bug-gnu-emacs@gnu.org; Thu, 09 Jun 2022 18:15:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 09 Jun 2022 22:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55696 X-GNU-PR-Package: emacs Original-Received: via spool by 55696-submit@debbugs.gnu.org id=B55696.165481287331135 (code B ref 55696); Thu, 09 Jun 2022 22:15:01 +0000 Original-Received: (at 55696) by debbugs.gnu.org; 9 Jun 2022 22:14:33 +0000 Original-Received: from localhost ([127.0.0.1]:48141 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nzQQD-000867-6y for submit@debbugs.gnu.org; Thu, 09 Jun 2022 18:14:33 -0400 Original-Received: from mail-pj1-f48.google.com ([209.85.216.48]:38811) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nzQQA-00085l-5V for 55696@debbugs.gnu.org; Thu, 09 Jun 2022 18:14:31 -0400 Original-Received: by mail-pj1-f48.google.com with SMTP id v11-20020a17090a4ecb00b001e2c5b837ccso565578pjl.3 for <55696@debbugs.gnu.org>; Thu, 09 Jun 2022 15:14:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-language; bh=CW3lHKeI1jenEqnwFbraCpncDlIljd/vo5r6s4Ag87c=; b=CjJk4S3ZCNtmrmvBB1fGdQSFOFQewVgOZRjeTazq9yQBLiC7zT32cxBwvWfIAfhVSx 1HTIDLkx1Qgb7+FOkc+42hrPpm3lRbSrzaREl9VwTJtmctZ1oa9YxnPDk28vGM6sHZxx pH1nF9aN5BmTWz/gqHWr/Qd8Atf+n8G1e9LxgoSYRypqitQe9l+ixp9AJmunvxaPSwFJ otp8d549s0wDt4BcYZ7hjX/BYvZ04zWXaPVztOYxl0T4u/NYowMMM81RBHGmcuHJhBsq PGT3gkIU6JL5UuzqBrpMaFX4wXmdQ2aPH/YP3nFDqCHiDojzyTOgbGB5vXeWX4JEt50R uVOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-language; bh=CW3lHKeI1jenEqnwFbraCpncDlIljd/vo5r6s4Ag87c=; b=ZllwDFBsOvz5jw+H3QhKOM+lSsSlT0adVtd/C0tgqc5BVn9lgF9vTBUkTNo3yhCjBI iW2edSvx4e3JCE1gyNNwK2uo4ILjxzkmZ4lbRtqHFP+cNQjvAvyzqwgmcQ9mj6lPXzrP R/gmjiKo9Xdmg2IwTplgSjflPoFwW9GgKKQKEjaUGgp2pRPZyy+dFu9FkFltwymkShz5 4KxNBTnzfvgpSJHIvIF0Yqis86Hme2mXyx7pK7ZyK/n4Tw+Z9NZnTm30dBvkdN61z+AP TbH6m8dYFoWQY8hvVGeyn9mq7IZjOAhRlaAFKvaNke1w69fjskrx/Zde985qkRw9ktCK Y6lg== X-Gm-Message-State: AOAM533toCiwr5erZgRQsRi3l0A49ztLeRSJ9ZwgbxBSPMmS6FNh+lUT /7SpJx9q07ETcRp1VXO2J+w= X-Google-Smtp-Source: ABdhPJx9Mwj554R7AhXfm2qczk0Xd75H9I6f3GOQnZoayFuYOsRn1Q6Xo8rM6J1V205QOEA/d0SGiw== X-Received: by 2002:a17:902:ac8f:b0:163:fbb7:b057 with SMTP id h15-20020a170902ac8f00b00163fbb7b057mr42184624plr.67.1654812864167; Thu, 09 Jun 2022 15:14:24 -0700 (PDT) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id 12-20020a170902c10c00b001621c48d6c2sm10179724pli.221.2022.06.09.15.14.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Jun 2022 15:14:23 -0700 (PDT) In-Reply-To: <837d5p3hr7.fsf@gnu.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:234176 Archived-At: This is a multi-part message in MIME format. --------------395EB1FE85DAF701C4BB6449 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 6/9/2022 9:48 AM, Eli Zaretskii wrote: >> From: Jim Porter >> Date: Thu, 9 Jun 2022 08:55:36 -0700 >> >> Do the tests work if you replace "list" in those two functions with >> "listify"? (`eshell/listify' is a built-in Eshell alias function, which >> is the highest priority for Eshell commands, so it should always work.) > > If I make this replacement in 4 tests that use "list", then it doesn't > hang, but 2 tests fail: That makes sense. Those other tests that are now failing should stay unchanged. The difference is in the brace style of the commands. For `esh-var-test/interp-lisp-indices': the expansion is '$(list 1 2)', which means "evaluate '(list 1 2)' as a Lisp sexpr". This doesn't need to change. For `esh-var-test/interp-cmd-indices': the expansion is '${list 1 2}', which means "evaluate 'list 1 2' as a shell-like command". In this case, if there's an external program named 'list', it will call that; otherwise, it will call the Lisp function `list'. (If there were a Lisp function named `eshell/list', Eshell would always prefer that.) Here, we should use 'listify', since it's the preferred Eshell way to make a list using command-style syntax. Attached is a patch for this. --------------395EB1FE85DAF701C4BB6449 Content-Type: text/plain; charset=UTF-8; name="0001-Don-t-use-list-command-in-Eshell-command-forms.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="0001-Don-t-use-list-command-in-Eshell-command-forms.patch" RnJvbSA4MzRjYWQ1MDIxMDczNzFlZWE1ZGIzZWRhYzBlMWM2MjA4ZmNiZmE2IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFRodSwgOSBKdW4gMjAyMiAwOTo1MDoyMCAtMDcwMApTdWJqZWN0OiBbUEFU Q0hdIERvbid0IHVzZSAnbGlzdCcgY29tbWFuZCBpbiBFc2hlbGwgY29tbWFuZCBmb3JtcwoK V2hlbiBleGVjdXRlZCBsaWtlIGEgY29tbWFuZCwgJ2xpc3QnIGxvb2tzIGZvciBleHRlcm5h bCBwcm9ncmFtcyBuYW1lZAonbGlzdCcgZmlyc3QgYmVmb3JlIGZhbGxpbmcgYmFjayB0byB0 aGUgTGlzcCBmdW5jdGlvbiBvZiB0aGUgc2FtZQpuYW1lLiAgVGhpcyBjYXVzZXMgdW5leHBl Y3RlZCBiZWhhdmlvciwgc2luY2UgdGhlIExpc3AgZnVuY3Rpb24gaXMKd2hhdCB3ZSB3YW50 IGluIHRoZXNlIHRlc3RzLgoKKiB0ZXN0L2xpc3AvZXNoZWxsL2VzaC12YXItdGVzdHMuZWwg KGVzaC12YXItdGVzdC9pbnRlcnAtY21kLWluZGljZXMpCihlc2gtdmFyLXRlc3QvcXVvdGVk LWludGVycC1jbWQtaW5kaWNlcyk6IFVzZSAnbGlzdGlmeScgaW5zdGVhZCBvZgonbGlzdCcu Ci0tLQogdGVzdC9saXNwL2VzaGVsbC9lc2gtdmFyLXRlc3RzLmVsIHwgNSArKystLQogMSBm aWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1n aXQgYS90ZXN0L2xpc3AvZXNoZWxsL2VzaC12YXItdGVzdHMuZWwgYi90ZXN0L2xpc3AvZXNo ZWxsL2VzaC12YXItdGVzdHMuZWwKaW5kZXggYmVlNDk1ZWI2ZS4uMzE4MGZlN2E1ZiAxMDA2 NDQKLS0tIGEvdGVzdC9saXNwL2VzaGVsbC9lc2gtdmFyLXRlc3RzLmVsCisrKyBiL3Rlc3Qv bGlzcC9lc2hlbGwvZXNoLXZhci10ZXN0cy5lbApAQCAtMTQ3LDcgKzE0Nyw3IEBAIGVzaC12 YXItdGVzdC9pbnRlcnAtY21kCiAKIChlcnQtZGVmdGVzdCBlc2gtdmFyLXRlc3QvaW50ZXJw LWNtZC1pbmRpY2VzICgpCiAgICJJbnRlcnBvbGF0ZSBjb21tYW5kIHJlc3VsdCB3aXRoIGlu ZGV4IgotICAoc2hvdWxkIChlcXVhbCAoZXNoZWxsLXRlc3QtY29tbWFuZC1yZXN1bHQgIisg JHtsaXN0IDEgMn1bMV0gMyIpIDUpKSkKKyAgKHNob3VsZCAoZXF1YWwgKGVzaGVsbC10ZXN0 LWNvbW1hbmQtcmVzdWx0ICIrICR7bGlzdGlmeSAxIDJ9WzFdIDMiKSA1KSkpCiAKIChlcnQt ZGVmdGVzdCBlc2gtdmFyLXRlc3QvaW50ZXJwLWNtZC1leHRlcm5hbCAoKQogICAiSW50ZXJw b2xhdGUgY29tbWFuZCByZXN1bHQgZnJvbSBleHRlcm5hbCBjb21tYW5kIgpAQCAtMzI4LDcg KzMyOCw4IEBAIGVzaC12YXItdGVzdC9xdW90ZWQtaW50ZXJwLWNtZAogCiAoZXJ0LWRlZnRl c3QgZXNoLXZhci10ZXN0L3F1b3RlZC1pbnRlcnAtY21kLWluZGljZXMgKCkKICAgIkludGVy cG9sYXRlIGNvbW1hbmQgcmVzdWx0IHdpdGggaW5kZXggaW5zaWRlIGRvdWJsZS1xdW90ZXMi Ci0gIChzaG91bGQgKGVxdWFsIChlc2hlbGwtdGVzdC1jb21tYW5kLXJlc3VsdCAiY29uY2F0 IFwiJHtsaXN0IDEgMn1bMV1cIiBjb29sIikKKyAgKHNob3VsZCAoZXF1YWwgKGVzaGVsbC10 ZXN0LWNvbW1hbmQtcmVzdWx0CisgICAgICAgICAgICAgICAgICAiY29uY2F0IFwiJHtsaXN0 aWZ5IDEgMn1bMV1cIiBjb29sIikKICAgICAgICAgICAgICAgICAgIjJjb29sIikpKQogCiAo ZXJ0LWRlZnRlc3QgZXNoLXZhci10ZXN0L3F1b3RlZC1pbnRlcnAtdGVtcC1jbWQgKCkKLS0g CjIuMjUuMQoK --------------395EB1FE85DAF701C4BB6449--