From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#73484: 31.0.50; Abolishing etags-regen-file-extensions Date: Fri, 4 Oct 2024 04:25:15 +0300 Message-ID: <8d7dc133-9828-4023-821f-e4403f899f81@gutov.dev> References: <87tteaznog.fsf@zephyr.silentflame.com> <8734lrrj4e.fsf@zephyr.silentflame.com> <87o74c1ce1.fsf@zephyr.silentflame.com> <87jzezzg87.fsf_-_@zephyr.silentflame.com> <37e4b3cd-6363-4f55-9921-92a1182679dc@gutov.dev> <86ttdy50ja.fsf@gnu.org> <75fe4289-da41-454d-ba92-22a92ea7002f@gutov.dev> <86frpe2186.fsf@gnu.org> <8e305b6d-8ca8-4437-990f-183ebc007d18@gutov.dev> <865xqa1ggi.fsf@gnu.org> <86ttdtzoof.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3813"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: 73484@debbugs.gnu.org, spwhitton@spwhitton.name To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Oct 04 03:26:17 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1swX5E-0000lA-0l for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 04 Oct 2024 03:26:16 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1swX50-0001sB-0H; Thu, 03 Oct 2024 21:26:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1swX4y-0001rJ-BV for bug-gnu-emacs@gnu.org; Thu, 03 Oct 2024 21:26:00 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1swX4y-0000iH-36 for bug-gnu-emacs@gnu.org; Thu, 03 Oct 2024 21:26:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=In-Reply-To:From:References:MIME-Version:Date:To:Subject; bh=f53wCZtCsi8TOsNqFhXGXZqYI1OXCBtWaTrl88344M0=; b=ul6Fo+9vZItYXWBo8QQaUG0NHvny34okwHAiJ0Icdm+iAPpF8mvN4NA16/zPgKDWqZLM8vOyq2lYSbwrBiTy0TBt5M1Jorc4q6yc8Or0401Xbvh/bkuknIXZ/zpM/pOjxOAbUNTcINyaMx2k1fuV4dMQ3sPRCngj9KHzns1oj35AL+qsxIFOywxHOW1wXiuBIeLICwxsqWCa8IXH1indER6FHl+NARHFCOTE1rGRlZnmV+9CiZ4hkKFWdkjJW7uMdxnH9tS3D8TH/u74S9tpLl4dspjpQ693zXQzqrafDUy6EDhNqV7bNLRp9yMCR9so8f9OlO9pOX1ZsfYc+VZwFA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1swX50-0000xb-B5 for bug-gnu-emacs@gnu.org; Thu, 03 Oct 2024 21:26:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 04 Oct 2024 01:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73484 X-GNU-PR-Package: emacs Original-Received: via spool by 73484-submit@debbugs.gnu.org id=B73484.17280051303647 (code B ref 73484); Fri, 04 Oct 2024 01:26:02 +0000 Original-Received: (at 73484) by debbugs.gnu.org; 4 Oct 2024 01:25:30 +0000 Original-Received: from localhost ([127.0.0.1]:34149 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1swX4T-0000wl-UU for submit@debbugs.gnu.org; Thu, 03 Oct 2024 21:25:30 -0400 Original-Received: from fout-a1-smtp.messagingengine.com ([103.168.172.144]:46269) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1swX4S-0000wV-3p for 73484@debbugs.gnu.org; Thu, 03 Oct 2024 21:25:28 -0400 Original-Received: from phl-compute-10.internal (phl-compute-10.phl.internal [10.202.2.50]) by mailfout.phl.internal (Postfix) with ESMTP id 252F11380228; Thu, 3 Oct 2024 21:25:20 -0400 (EDT) Original-Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-10.internal (MEProxy); Thu, 03 Oct 2024 21:25:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1728005120; x=1728091520; bh=f53wCZtCsi8TOsNqFhXGXZqYI1OXCBtWaTrl88344M0=; b= ga/itDE/d9BVynxLygO5IS7j0hsNl6DwuRLW/7Ra2EcGkTGyqj/PNGYEQpE7S+C1 EcjBQAXGe4AVtjftxxmaMCzUBSQXYe+OZhBrHWLcudIMyZolu0lE2qUWWxFFRgGh ExPEIS/BwuOCpR5umDd7VVTSSi7CGbt3yTsX1AV6yOmg5f+HraOyf3yu97PHNzTK Z0Fi9Iysq9uLPMuNsYzmnh7EBcElRmmAa1SU8AKdQGwhsHk8+RI/7RbLOPs5448j q/3Py9IB0p01YEUT5kOwqacWDaGwegPCPUxg+n5RdSCVZwvw1Wf9UO3SWgPILEIc 1axUtkeOpa+61Rmj/l3jHg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1728005120; x= 1728091520; bh=f53wCZtCsi8TOsNqFhXGXZqYI1OXCBtWaTrl88344M0=; b=j 8g+Qs0Iy3nJcg6LLEB7uOLXKZA21yafvv/Ui6k2HeznFcjLAFgJZE8GlpzkQucqy K95QAGrjnTQxN48/3GjEXF8H0D4DZ+05mSgewngL3mjAN4KfjvC+vV1XNbNSCaIK NWBWAiV9+o1rTvJDKyyqA9sOU4Qqdi9eZIghoMwl/MlyEtJgPIyYopUOIOZc3fQg 9vcGLMrpesihXApjIQ5eFG/sKIpm/GXMFak9MuX6KVs0UVw1BOfQ3JH5DmsGRnqD WGaARjf61TJi0vcJabrdQrmPUIFmdglwt3uEbgIXg8HahTd0YCYjvThms3lFuzCQ oxnYgWJtlXduD83aQ/14A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvddvvddggeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtvdej necuhfhrohhmpeffmhhithhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdrug gvvheqnecuggftrfgrthhtvghrnhepteduleejgeehtefgheegjeekueehvdevieekueef tddvtdevfefhvdevgedujeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpe hmrghilhhfrhhomhepughmihhtrhihsehguhhtohhvrdguvghvpdhnsggprhgtphhtthho peefpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopegvlhhiiiesghhnuhdrohhrgh dprhgtphhtthhopehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvgdprhgt phhtthhopeejfeegkeegseguvggssghughhsrdhgnhhurdhorhhg X-ME-Proxy: Feedback-ID: i07de48aa:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 3 Oct 2024 21:25:18 -0400 (EDT) Content-Language: en-US In-Reply-To: <86ttdtzoof.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:292938 Archived-At: On 03/10/2024 09:27, Eli Zaretskii wrote: >> But here's how I'm looking at it: >> >> Imagine a straightforward C project, one that has .c files, .h, maybe >> .y, and also a bunch of docs, build artefacts (some of them checked in), >> and maybe other data files as well. Also README, ChangeLog, Makefile, >> config.bat, some .txt files, many other files without extensions, etc. >> >> Previously, when building a TAGS file manually, a developer in such a >> project specified a list of file globs by hand. One that would be >> limited to .[ch] files, and maybe .y as well, but not all the files in >> the directory. > > If they definitely do NOT want the other files to be present in TAGS, > they can keep using those globs. Nothing will change in that case. a) They would have to produce the same list of file extensions that we are using now, and they will need to find out which variable to customize, to set to that list. b) They won't get the shebang detection capability, unless we add a new option where they will have to enumerate all their shebang-enabled file names as well. So it seems like they would have to choose between the one and the other, with the end behavior that I'm describing not being supported even any combination of user options. >> To use Emacs itself as an example, the 'tags' target in our own Makefile >> only includes .[hc], .m, .cc, .el and (surprising to me) .texi files. >> But not any of the others. The number of such files is ~3K, if I'm >> counting correctly. >> >> The total number of all non-ignored files in our repo is ~5K. That's 2K >> more files that would be present in the 'M-x tags-search' or 'M-x >> list-tags' outputs, if an Emacs developer simply switches to using >> etags-regen-mode, and etags-regen-mode drops the file extensions >> whitelist, and etags keeps all passed files' names in its output. > > OTOH, if a file with a known extension has no taggable symbols, you > still get its file name in TAGS. So omitting files whose language we > could not recognize would be an incompatible change in behavior. Incompatible change in etags' behavior, but likely a more compatible change in the behavior of the default Emacs. For etags, though, we could an opt-in flag. > The fact that in the scenario you describe above 2K more files will > appear in tags-search is, from my POV, an argument _for_ including > them, not against: we have no reason to assume that users don't want > to search those files for some regexp, because regexps specified in > tags-search don't necessarily have anything to do with the identifiers > we tag. A valid case in point is to look up all references to some > file when the file is deleted, or references to some version when the > version is updated: we definitely want files like README and INSTALL > to be included in the search. I would hope that project-find-regexp works well enough for that. Or 'M-x project-search' for the fans of the classic interface. README and INSTALL are not currently included in TAGS. You seem to be making a case that all files in our dev repository should be included, but for some reason the current build rules are very different?