unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#56095: Patch
       [not found] <27290ad8-4f51-41e5-9317-46e4b3c5dd6c@Spark>
@ 2022-06-19 17:32 ` Gerd Möllmann
  2022-06-19 17:42   ` Eli Zaretskii
                     ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Gerd Möllmann @ 2022-06-19 17:32 UTC (permalink / raw)
  To: 56095


[-- Attachment #1.1: Type: text/plain, Size: 185 bytes --]

I'm now using the patch attached.

Why the window pointer  is needed in EmacsScroller at all escapes me, ATM. Someone who knows nsterm.c should probably check if it is needed.



[-- Attachment #1.2: Type: text/html, Size: 404 bytes --]

[-- Attachment #2: patch --]
[-- Type: application/octet-stream, Size: 861 bytes --]

diff --git a/src/nsterm.m b/src/nsterm.m
index 891d52ea3f..514b790b15 100644
--- a/src/nsterm.m
+++ b/src/nsterm.m
@@ -9869,14 +9869,6 @@ - (void)setFrame: (NSRect)newRect
 - (void)dealloc
 {
   NSTRACE ("[EmacsScroller dealloc]");
-  if (window)
-    {
-      if (horizontal)
-        wset_horizontal_scroll_bar (window, Qnil);
-      else
-        wset_vertical_scroll_bar (window, Qnil);
-    }
-  window = 0;
   [super dealloc];
 }
 
@@ -9909,13 +9901,6 @@ -(bool)judge
       view = (EmacsView *)FRAME_NS_VIEW (frame);
       if (view != nil)
         view->scrollbarsNeedingUpdate++;
-      if (window)
-        {
-          if (horizontal)
-            wset_horizontal_scroll_bar (window, Qnil);
-          else
-            wset_vertical_scroll_bar (window, Qnil);
-        }
       window = 0;
       [self removeFromSuperview];
       [self release];

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* bug#56095: Patch
  2022-06-19 17:32 ` bug#56095: Patch Gerd Möllmann
@ 2022-06-19 17:42   ` Eli Zaretskii
  2022-06-19 18:02     ` Gerd Möllmann
  2022-06-19 22:51   ` bug#56095: 29.0.50; nsterm.m, use after free Lars Ingebrigtsen
  2022-06-20  1:02   ` bug#56095: Patch Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
  2 siblings, 1 reply; 6+ messages in thread
From: Eli Zaretskii @ 2022-06-19 17:42 UTC (permalink / raw)
  To: Gerd Möllmann; +Cc: 56095

> Date: Sun, 19 Jun 2022 19:32:01 +0200
> From: Gerd Möllmann <gerd.moellmann@gmail.com>
> 
> Why the window pointer  is needed in EmacsScroller at all escapes me, ATM. Someone who knows
> nsterm.c should probably check if it is needed.

You mean, nsterm.m, right?

Someone who knows their way around macOS will probably look into this
soon.

Thanks.





^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#56095: Patch
  2022-06-19 17:42   ` Eli Zaretskii
@ 2022-06-19 18:02     ` Gerd Möllmann
  0 siblings, 0 replies; 6+ messages in thread
From: Gerd Möllmann @ 2022-06-19 18:02 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: 56095

[-- Attachment #1: Type: text/plain, Size: 492 bytes --]

Yes, nsterm.m of course.  Sorry

On Sun, 19 Jun 2022, 19:42 Eli Zaretskii, <eliz@gnu.org> wrote:

> > Date: Sun, 19 Jun 2022 19:32:01 +0200
> > From: Gerd Möllmann <gerd.moellmann@gmail.com>
> >
> > Why the window pointer  is needed in EmacsScroller at all escapes me,
> ATM. Someone who knows
> > nsterm.c should probably check if it is needed.
>
> You mean, nsterm.m, right?
>
> Someone who knows their way around macOS will probably look into this
> soon.
>
> Thanks.
>

[-- Attachment #2: Type: text/html, Size: 866 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#56095: 29.0.50; nsterm.m, use after free
  2022-06-19 17:32 ` bug#56095: Patch Gerd Möllmann
  2022-06-19 17:42   ` Eli Zaretskii
@ 2022-06-19 22:51   ` Lars Ingebrigtsen
  2022-06-20  1:02   ` bug#56095: Patch Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
  2 siblings, 0 replies; 6+ messages in thread
From: Lars Ingebrigtsen @ 2022-06-19 22:51 UTC (permalink / raw)
  To: Gerd Möllmann; +Cc: 56095, Alan Third

Gerd Möllmann <gerd.moellmann@gmail.com> writes:

> I'm now using the patch attached.
>
> Why the window pointer  is needed in EmacsScroller at all escapes me, ATM.
> Someone who knows nsterm.c should probably check if it is needed.

I've added Alan to the CCs; perhaps he knows.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#56095: Patch
  2022-06-19 17:32 ` bug#56095: Patch Gerd Möllmann
  2022-06-19 17:42   ` Eli Zaretskii
  2022-06-19 22:51   ` bug#56095: 29.0.50; nsterm.m, use after free Lars Ingebrigtsen
@ 2022-06-20  1:02   ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
  2022-06-20  6:00     ` Gerd Möllmann
  2 siblings, 1 reply; 6+ messages in thread
From: Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2022-06-20  1:02 UTC (permalink / raw)
  To: Gerd Möllmann; +Cc: 56095

Gerd Möllmann <gerd.moellmann@gmail.com> writes:

> Why the window pointer is needed in EmacsScroller at all escapes me,
> ATM. Someone who knows nsterm.c should probably check if it is needed.

It's the scroll bar class, and naturally needs a reference to the window
it scrolls.  Otherwise, how will it set ie.frame_or_window in
sendScrollEventAtLoc?





^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#56095: Patch
  2022-06-20  1:02   ` bug#56095: Patch Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2022-06-20  6:00     ` Gerd Möllmann
  0 siblings, 0 replies; 6+ messages in thread
From: Gerd Möllmann @ 2022-06-20  6:00 UTC (permalink / raw)
  To: Po Lu; +Cc: 56095

[-- Attachment #1: Type: text/plain, Size: 465 bytes --]

On 20. Jun 2022, 03:02 +0200, Po Lu <luangruo@yahoo.com>, wrote:
> Gerd Möllmann <gerd.moellmann@gmail.com> writes:
>
> > Why the window pointer is needed in EmacsScroller at all escapes me,
> > ATM. Someone who knows nsterm.c should probably check if it is needed.
>
> It's the scroll bar class, and naturally needs a reference to the window
> it scrolls. Otherwise, how will it set ie.frame_or_window in
> sendScrollEventAtLoc?

Ah, I see.  Thanks.

[-- Attachment #2: Type: text/html, Size: 1010 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2022-06-20  6:00 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <27290ad8-4f51-41e5-9317-46e4b3c5dd6c@Spark>
2022-06-19 17:32 ` bug#56095: Patch Gerd Möllmann
2022-06-19 17:42   ` Eli Zaretskii
2022-06-19 18:02     ` Gerd Möllmann
2022-06-19 22:51   ` bug#56095: 29.0.50; nsterm.m, use after free Lars Ingebrigtsen
2022-06-20  1:02   ` bug#56095: Patch Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-20  6:00     ` Gerd Möllmann

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).