From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#31350: 27.0; `pcase' message: "Redundant pcase pattern" Date: Sat, 3 Oct 2020 15:58:34 -0700 (PDT) Message-ID: <8bcc3be5-c9db-4015-8f0f-4efe77ff27ee@default> References: <86d352f4-5fa7-4bee-b72c-17e58aace43f@default> <87364hs46h.fsf@gnus.org> <87sgaudiss.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17025"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 31350@debbugs.gnu.org To: Michael Heerdegen , Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 04 00:59:20 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kOqUp-0004LM-Ss for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 04 Oct 2020 00:59:19 +0200 Original-Received: from localhost ([::1]:47722 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kOqUo-0002NY-Tu for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 03 Oct 2020 18:59:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54934) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kOqUY-0002Jo-Cu for bug-gnu-emacs@gnu.org; Sat, 03 Oct 2020 18:59:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33054) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kOqUY-0000TS-2Q for bug-gnu-emacs@gnu.org; Sat, 03 Oct 2020 18:59:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kOqUY-0001Nd-24 for bug-gnu-emacs@gnu.org; Sat, 03 Oct 2020 18:59:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 03 Oct 2020 22:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31350 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 31350-submit@debbugs.gnu.org id=B31350.16017659265283 (code B ref 31350); Sat, 03 Oct 2020 22:59:02 +0000 Original-Received: (at 31350) by debbugs.gnu.org; 3 Oct 2020 22:58:46 +0000 Original-Received: from localhost ([127.0.0.1]:44600 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kOqUH-0001N8-Sw for submit@debbugs.gnu.org; Sat, 03 Oct 2020 18:58:46 -0400 Original-Received: from aserp2120.oracle.com ([141.146.126.78]:38502) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kOqUG-0001Mv-QM for 31350@debbugs.gnu.org; Sat, 03 Oct 2020 18:58:45 -0400 Original-Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 093MsWR9117205; Sat, 3 Oct 2020 22:58:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=DEwNJJQVKWLQzMuwMKwEWLr9RIZCTgC17OBY60Si9pc=; b=Jpk4J+YkaaNI1JbI9yKUBkvhruEkxMUg1I3b8ynU/NNg2q57tNb8JAz+jkXafMaCgsnU kOuAeZhwY4tTgk3EYLT4jItpoPOvY3YSr3f5ZOAt+od9Umr8BJ3uGaF9L99qSFJu/pi8 gNmQcy7Z2Nx90TdyOPjaBv2vdHEr5kRmOEseQWmGrY49dDxtiKfPKOQlWLh7yPCe3Xwl XWKUbm8/QwXc8fm0vobowTmHqMx2H/URntvI1NuE19BZLNKStpU6l36GCXlVUILd6A5c KqhUL7hu0p2QNPjOkkebVAwu5ws3e2l9KLww6Op17sK0cJphFfxq7Uh3kSURkW70srhf iw== Original-Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by aserp2120.oracle.com with ESMTP id 33xh8khfp2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Sat, 03 Oct 2020 22:58:38 +0000 Original-Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 093MswIl075608; Sat, 3 Oct 2020 22:58:37 GMT Original-Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userp3020.oracle.com with ESMTP id 33xgmh5eaa-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 03 Oct 2020 22:58:37 +0000 Original-Received: from abhmp0020.oracle.com (abhmp0020.oracle.com [141.146.116.26]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 093MwZmI017844; Sat, 3 Oct 2020 22:58:36 GMT In-Reply-To: <87sgaudiss.fsf@web.de> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.5056.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9763 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxscore=0 suspectscore=0 bulkscore=0 mlxlogscore=999 phishscore=0 malwarescore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2010030194 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9763 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 mlxscore=0 suspectscore=0 impostorscore=0 priorityscore=1501 clxscore=1011 phishscore=0 malwarescore=0 spamscore=0 bulkscore=0 lowpriorityscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2010030194 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:189729 Archived-At: > Well, when we compile something like >=20 > (defun test (foo recursivep) > (pcase foo > (a `(not ,a)) > ((and a (guard recursivep)) > `(not ,a)))) >=20 > the message Drew means says >=20 > Redundant pcase pattern: (and a (guard recursivep)) >=20 > I'm happy with that, I think it tells anything I need to know. I'm not > happy about the fact that I missed the `message' because it's only a > message and I only see it when I look into the *Messages* buffer because > it's overwritten very soon in the echo area. >=20 > The compiler log only shows >=20 > Compiling file /home/micha/today/pctest.el at Sun Oct 4 00:44:51 2020 > pctest.el:46:1: Warning: Unused lexical argument `recursivep' >=20 > which is confusing if you missed the message about the redundant > pattern. The ephemeral (so hidden) message is another problem. I'll repeat the request, which is what I think a user would like to know: Can the messaging at least tell you: (1) all of a set of clauses that are mutually redundant and (2) which one of them will actually be used by the compiled code, the others presumably having been pruned? IOW, what's the actual effect, for users? How does pcase deal with the redundancy? Can that at least be documented somewhere (maybe it is already)?