From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Phillip Lord" Newsgroups: gmane.emacs.bugs Subject: bug#23632: 25.1.50; Gratuitous undo boundary in latex-insert-block Date: Sat, 4 Jun 2016 18:17:57 +0100 Message-ID: <8b9b4630b1282ed76fe26452b4a8fbb6.squirrel@cloud103.planethippo.com> References: <87lh2vo7s6.fsf@gmail.com> <87shx23830.fsf@gmail.com> <87wpmcwn13.fsf@russet.org.uk> <87wpm9q4z7.fsf@russet.org.uk> <87vb1rbbg1.fsf@russet.org.uk> <87shwutfmo.fsf@russet.org.uk> <87porxrk4v.fsf@russet.org.uk> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain;charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1465060766 6202 80.91.229.3 (4 Jun 2016 17:19:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 4 Jun 2016 17:19:26 +0000 (UTC) Cc: Chong Yidong , 23632@debbugs.gnu.org, Phillip Lord To: "Stefan Monnier" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jun 04 19:19:15 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1b9FE9-0008NB-6F for geb-bug-gnu-emacs@m.gmane.org; Sat, 04 Jun 2016 19:19:13 +0200 Original-Received: from localhost ([::1]:33518 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b9FE8-0007hn-0h for geb-bug-gnu-emacs@m.gmane.org; Sat, 04 Jun 2016 13:19:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43997) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b9FE2-0007hD-R5 for bug-gnu-emacs@gnu.org; Sat, 04 Jun 2016 13:19:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b9FDx-0006mp-QK for bug-gnu-emacs@gnu.org; Sat, 04 Jun 2016 13:19:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:42264) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b9FDx-0006mh-Ma for bug-gnu-emacs@gnu.org; Sat, 04 Jun 2016 13:19:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1b9FDx-0003PC-Ix for bug-gnu-emacs@gnu.org; Sat, 04 Jun 2016 13:19:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Phillip Lord" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 Jun 2016 17:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23632 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 23632-submit@debbugs.gnu.org id=B23632.146506068413016 (code B ref 23632); Sat, 04 Jun 2016 17:19:01 +0000 Original-Received: (at 23632) by debbugs.gnu.org; 4 Jun 2016 17:18:04 +0000 Original-Received: from localhost ([127.0.0.1]:54598 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b9FD2-0003Ns-I2 for submit@debbugs.gnu.org; Sat, 04 Jun 2016 13:18:04 -0400 Original-Received: from cloud103.planethippo.com ([31.216.48.48]:40078) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b9FD1-0003NN-He for 23632@debbugs.gnu.org; Sat, 04 Jun 2016 13:18:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=russet.org.uk; s=default; h=Content-Transfer-Encoding:Content-Type: MIME-Version:Cc:To:From:Subject:Date:References:In-Reply-To:Message-ID; bh=M9gzTWXqpGQ3xatkqvmw6dSxkUhXWqLWBD9jb81fzaI=; b=eksce6Raa8A6B+nZUsFsbq+ShY SkiPXbB1fi/A52FtC/LoNDVQDB1TaVzEwBuYcI8H3tUZpclarRlPXjJ9YR6rWLOGSYz53tk2H9NIk cRvSPlXXmynbw/GHhuhVABqvQrMbPy4VI8bza2YV56prVSvqE9s7BuczpFn6qcVpbkfzI9NCXBnDu Ef5TfivGFhkXQrV+ZqQRpG1a7SGQea1YLGdL7n00Nv2yi/iyqcp7MDRZ9IVhuI/DlHLpxShUO5TVJ vni7UJFfHWsUmEDjunQL3Zd/IGCfBMaudC8owNt6OLaW9nMVCYiiTzpnxcSwSEIVSEMz4E8Yv9GpI 7/rxfouQ==; Original-Received: from [127.0.0.1] (port=57702 helo=cloud103.planethippo.com) by cloud103.planethippo.com with esmtpa (Exim 4.86_1) (envelope-from ) id 1b9FCv-000sb1-C3; Sat, 04 Jun 2016 18:17:57 +0100 Original-Received: from 78.147.208.164 ([78.147.208.164]) (SquirrelMail authenticated user phillip.lord@russet.org.uk) by cloud103.planethippo.com with HTTP; Sat, 4 Jun 2016 18:17:57 +0100 In-Reply-To: User-Agent: SquirrelMail/1.5.2 [SVN] X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - cloud103.planethippo.com X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - russet.org.uk X-Get-Message-Sender-Via: cloud103.planethippo.com: authenticated_id: phillip.lord@russet.org.uk X-Authenticated-Sender: cloud103.planethippo.com: phillip.lord@russet.org.uk X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:119070 Archived-At: On Sat, June 4, 2016 5:49 pm, Stefan Monnier wrote: >> Yes. This is assuming that commands *both* change recursion depth *and* >> change a buffer. > > Yes, it's like a fairly rare occurrence, where a command does both: > - modify some buffer(s) > - exit a recursive edit > So maybe we can live without paying attention to it. > > >>>> -- once when we capture the undoable changes (which happens >>>> often) and once on at the end of each command. >>> Right. I see no need for any changes there. >>> >> Really? I have to know the recursion depth at this point >> > > No, let-bind the var to nil around each recursive edit should take care > of "everything" so you don't need to change anything else (including, non > need to pay any attention to the recursion depth). > >> To be clear, though, to do this I need to augment recursive-edit in C? >> I >> need the let binding to last the life of the recursive edit? > > That's right. A call to `specbind' at the right spot might even be all > it takes. Okay, I will take a good look -- I've not done this before, but can try. I guess "recursive-edit" is the only way to enter a recursive edit?