From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#36780: 26.1; request: savehist should also save log-edit-comment-ring by default Date: Fri, 23 Aug 2019 11:04:01 -0700 (PDT) Message-ID: <8b952d4c-6a04-404e-83c3-a5d2362f08c9@default> References: <> <<87blwgforq.fsf@gnus.org>> <<83blwgb6ni.fsf@gnu.org>> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="23338"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacsuser@freemail.hu, 36780@debbugs.gnu.org To: Eli Zaretskii , Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Aug 23 20:05:13 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i1Dw0-0005xY-Or for geb-bug-gnu-emacs@m.gmane.org; Fri, 23 Aug 2019 20:05:12 +0200 Original-Received: from localhost ([::1]:60644 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i1Dvz-00063A-CV for geb-bug-gnu-emacs@m.gmane.org; Fri, 23 Aug 2019 14:05:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35650) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i1Dvr-00062x-HH for bug-gnu-emacs@gnu.org; Fri, 23 Aug 2019 14:05:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i1Dvq-0003hC-IH for bug-gnu-emacs@gnu.org; Fri, 23 Aug 2019 14:05:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60564) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i1Dvq-0003h5-Ey for bug-gnu-emacs@gnu.org; Fri, 23 Aug 2019 14:05:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1i1Dvq-0006gW-9S for bug-gnu-emacs@gnu.org; Fri, 23 Aug 2019 14:05:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 23 Aug 2019 18:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36780 X-GNU-PR-Package: emacs Original-Received: via spool by 36780-submit@debbugs.gnu.org id=B36780.156658346025620 (code B ref 36780); Fri, 23 Aug 2019 18:05:02 +0000 Original-Received: (at 36780) by debbugs.gnu.org; 23 Aug 2019 18:04:20 +0000 Original-Received: from localhost ([127.0.0.1]:41148 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i1Dv9-0006f7-Io for submit@debbugs.gnu.org; Fri, 23 Aug 2019 14:04:20 -0400 Original-Received: from userp2120.oracle.com ([156.151.31.85]:59466) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i1Dv6-0006es-Ei for 36780@debbugs.gnu.org; Fri, 23 Aug 2019 14:04:17 -0400 Original-Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x7NI3vq7107030; Fri, 23 Aug 2019 18:04:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2019-08-05; bh=xBngANIYQOgJe0hdrtSPJLc4aOT7gqE1nHGJlY7jEE8=; b=ToVqhjf7EdOL5Yzew0o0ZX0uopIR64py4IcBpcp9FBUGNPCSPWQJwp1VuY5XMULB7xUA +Ka7G6bON8/UCUB7pv12F6t86GnEIvDj84nduRBfLCNx7f1QCYMyPHcLOc6cepdBBW00 Lo5OCiu2xRrE//JgN5E22vcWEn09XPVmbng6LCIdM62Z87D+doQDnlubTjVhEabfwDn8 cmk4fhB1Ad6p/7xjzpqlySY5h9Dj+4TZlov906KTGMdUw2WLd8N3YvwSKnZ0jWw1Y6K3 WWZ+QtMdNGF/xSNSFfILpxjD5xMP8g//3tmt9+O3vpQJqIfvT7vYUV6fJ9vLD8H5rhqn yg== Original-Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2120.oracle.com with ESMTP id 2uea7reahk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 23 Aug 2019 18:04:09 +0000 Original-Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x7NI40oT179618; Fri, 23 Aug 2019 18:04:09 GMT Original-Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserp3030.oracle.com with ESMTP id 2uhusfxjm6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 23 Aug 2019 18:04:08 +0000 Original-Received: from abhmp0010.oracle.com (abhmp0010.oracle.com [141.146.116.16]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x7NI42lg005511; Fri, 23 Aug 2019 18:04:02 GMT In-Reply-To: <<83blwgb6ni.fsf@gnu.org>> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4873.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9358 signatures=668684 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1908230171 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9358 signatures=668684 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1908230171 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:165712 Archived-At: > > `savehist-additional-variables' is explicitly reserved for users to > > add stuff to, so I don't think it'd be appropriate for log-edit.el > > to add anything to it. +1 > I don't see why the solution of customizing > savehist-additional-variables by the user is not the right one. > After all, we are not talking about minibuffer history here. +1 > The savehist package defines itself as being for "saving the > minibuffer history". What you suggest makes it a much more general > facility, and we then would need to review many other variables and > decide whether they are candidates for saving (some of them are > already saved by separate features). Maybe we should do that, but > that's a much broader issue than this particular bug report. YAGNI. Emacs doesn't need to pre-populate a list of variables to save. `savehist-additional-variables' is the right way (for users) to save variables, IMO.