From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#61302: 29.0.60; rust-ts-mode does not show function-invocation on field-properties Date: Thu, 16 Feb 2023 03:53:12 +0200 Message-ID: <8b3e632b-18de-f23c-675a-24905bbfbc23@yandex.ru> References: <6209c097-0369-828a-7513-d8afb73fd7f0@secure.kjonigsen.net> <33cec9a6-7e69-2eb3-a8a6-58ce23a5c185@yandex.ru> <61cb2b34-0be2-1f69-e72d-5351fbe9e48f@yandex.ru> <5075852e-480b-7ca9-ba46-8de230ed8df5@secure.kjonigsen.net> <6b75a99f-05fd-cde9-e9fe-7191f12d72e1@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24927"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Cc: eliz@gnu.org, Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= , Yuan Fu , 61302@debbugs.gnu.org To: Randy Taylor Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Feb 16 02:54:38 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pSTTq-0006NF-9W for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 16 Feb 2023 02:54:38 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pSTTH-0004OU-Sx; Wed, 15 Feb 2023 20:54:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSTTG-0004Nz-Iu for bug-gnu-emacs@gnu.org; Wed, 15 Feb 2023 20:54:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pSTTG-0005wN-AA for bug-gnu-emacs@gnu.org; Wed, 15 Feb 2023 20:54:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pSTTF-0007T0-LR for bug-gnu-emacs@gnu.org; Wed, 15 Feb 2023 20:54:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 16 Feb 2023 01:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61302 X-GNU-PR-Package: emacs Original-Received: via spool by 61302-submit@debbugs.gnu.org id=B61302.167651240528655 (code B ref 61302); Thu, 16 Feb 2023 01:54:01 +0000 Original-Received: (at 61302) by debbugs.gnu.org; 16 Feb 2023 01:53:25 +0000 Original-Received: from localhost ([127.0.0.1]:34533 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSTSf-0007S7-2s for submit@debbugs.gnu.org; Wed, 15 Feb 2023 20:53:25 -0500 Original-Received: from mail-wm1-f49.google.com ([209.85.128.49]:45909) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSTSb-0007Rq-U5 for 61302@debbugs.gnu.org; Wed, 15 Feb 2023 20:53:23 -0500 Original-Received: by mail-wm1-f49.google.com with SMTP id m16-20020a05600c3b1000b003dc4050c94aso451222wms.4 for <61302@debbugs.gnu.org>; Wed, 15 Feb 2023 17:53:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=sMOKWzzRT7iOSZbAw/7Sfu8mSJVPqbsxC37WN08K5WY=; b=WDGDpsCG1eUb56iuoguXZTW3A/VqC1xAEbDxXYtqVxjqjzXDAnRV9ouRCscRjC3omN cq77otzstEgSYCVWe9nz6tEaR75Hu6rUYHPc0f5rk5EJNTDNraMBDWWsylSIAEijFurg 5peSF3V4gipEjTiyIKtBkZTwWAmVuiNMxu9SMVEmJ1v1QDeNXfMXGR3/3kRm1C6NQu/h yWRD6kbnqE8vqIq+zBPABhF+RxYZBb53kNwdiEIiKNelcchex4VhPMpMextTxf223B0J EHz006fjkqzbykQ1JGJLqGEanHSBkmLu/xZfoIs3tm+Y6QoT5hq4SzgsW8xjNhmBYlzh inFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=sMOKWzzRT7iOSZbAw/7Sfu8mSJVPqbsxC37WN08K5WY=; b=aEBI4C+gFEZURnwBV1Ld7SboRxrw1OqA88/ekkpAX8mJRWogIDGtbqSxn/oDbAYxmQ XM5x8EzFmYu38GREIrvN2ZWNpEV/phpdQeFBBrt4qaFriAMHKTNbzNyCRrHjPoJBAre8 cIrr2MU39UjiMveu/zMB8Y3lCg7lK8HLE8lIX5ty125/XDRiWgh1xXk2kcABu1AV2rsF +BCeIKfA/XUzSEuoaacJNefHoUEI3QjBJoHNp2/eDp0mOnVKagfduiGExdHTHHfO860U d9YeZCWKXWlJLa+UDdhBYrxme4liC9Qtqb8HNreMKnk6bSGsY62WRkkePCIfYHmXBemR oUBQ== X-Gm-Message-State: AO0yUKWB8iD90wGQ2C30ZqyHlAaAE8p1sE7kEO2fTkcTEecx/Drd+z5X k/FqzFPmfaYTjJmrM6FIxjU= X-Google-Smtp-Source: AK7set8Ox83X1qx9DJoTxeno47c7dGZZAwHsb3ZAkwrj6EqTjOHt6tbgHBp6LHRllns7UkuwZhB4EA== X-Received: by 2002:a05:600c:1c25:b0:3dc:5a13:c7d1 with SMTP id j37-20020a05600c1c2500b003dc5a13c7d1mr4166475wms.16.1676512394994; Wed, 15 Feb 2023 17:53:14 -0800 (PST) Original-Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id p15-20020a7bcdef000000b003e21356bddcsm48429wmj.33.2023.02.15.17.53.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Feb 2023 17:53:14 -0800 (PST) Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:255787 Archived-At: On 15/02/2023 04:07, Randy Taylor wrote: > Basically what we have here are general scoped_identifier queries that we want to apply only to the actual code (i.e. not imports). However, these scoped_identifiers also exist in the imports and the same highlighting semantics don't apply there, so we have specific queries for the different kinds of imports that specify how they want their scoped_identifier stuff highlighted. The only option I've been thinking of (and described in some related report), is to replace the face name with a highlighter in Lisp. See rust-ts-mode--fontify-pattern as an example of such function. But the new one will need to check that the parent is 'scoped_identifier', and the grandparent is not a 'call_expression' node, or 'use_as_clause', or 'use_declaration', etc, and the name itself is lowercase -- when so, skip highlighting. And highlight with one of the two faces when otherwise. Shouldn't be too hard to do, but I'm wary about the additional cost at runtime.