From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jens Schmidt via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#63627: Improve plstore.el and fix various issues of it Date: Thu, 31 Aug 2023 12:21:38 +0200 Message-ID: <8b00a564-c0d2-3072-50bc-530c50fa25b2@vodafonemail.de> References: <2063d5d2-ae9e-020a-3c19-54508ddbabab@vodafonemail.de> <37949bc5-c572-ff98-ebe6-9217ab7067cc@vodafonemail.de> <83cz2gfypg.fsf@gnu.org> <0101e7f1-970b-297c-836f-e9c0aa5e38a0@vodafonemail.de> <83cyz3g6oc.fsf@gnu.org> Reply-To: Jens Schmidt Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29502"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Cc: 63627@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 31 12:23:06 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qbepO-0007Sj-0E for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 31 Aug 2023 12:23:06 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qbepE-0006qV-HH; Thu, 31 Aug 2023 06:22:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qbepC-0006q3-Ot for bug-gnu-emacs@gnu.org; Thu, 31 Aug 2023 06:22:54 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qbepC-0007It-GU for bug-gnu-emacs@gnu.org; Thu, 31 Aug 2023 06:22:54 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qbepK-0006iH-64 for bug-gnu-emacs@gnu.org; Thu, 31 Aug 2023 06:23:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jens Schmidt Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 31 Aug 2023 10:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63627 X-GNU-PR-Package: emacs Original-Received: via spool by 63627-submit@debbugs.gnu.org id=B63627.169347735825772 (code B ref 63627); Thu, 31 Aug 2023 10:23:02 +0000 Original-Received: (at 63627) by debbugs.gnu.org; 31 Aug 2023 10:22:38 +0000 Original-Received: from localhost ([127.0.0.1]:54977 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbeov-0006hc-S2 for submit@debbugs.gnu.org; Thu, 31 Aug 2023 06:22:38 -0400 Original-Received: from mr3.vodafonemail.de ([145.253.228.163]:35162) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbeoq-0006hI-3G for 63627@debbugs.gnu.org; Thu, 31 Aug 2023 06:22:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vodafonemail.de; s=vfde-mb-mr2-21dec; t=1693477337; bh=PIHMVK7JuXIVfvbB3ICskq+Pr3ENRDbrOYRSpYg7Ung=; h=Message-ID:Date:User-Agent:Subject:Content-Language:To:References: From:In-Reply-To:Content-Type:From; b=dF4CsIn98nBXebp23h2GDACx5UxGtHrxfDmgBvAHIXcQEl4+C97fd+FcsR/Mjln0i zBFRk9BX8yZnLZKp2rCGJtBthy6++/c4fjnosD+KvQSEIA97Kv5btwYOlaVA94XkRO IbHDvlrQNjMRmRhKZJvXFeNX7ugfYVIaqmN3Czjo= Original-Received: from smtp.vodafone.de (unknown [10.0.0.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by mr3.vodafonemail.de (Postfix) with ESMTPS id 4Rbxzs6yBgz203B; Thu, 31 Aug 2023 10:22:17 +0000 (UTC) Original-Received: from [192.168.0.138] (unknown [86.33.72.162]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp.vodafone.de (Postfix) with ESMTPSA id 4Rbxzj4bvbzMkrv; Thu, 31 Aug 2023 10:22:06 +0000 (UTC) Content-Language: de-DE-frami, en-US In-Reply-To: <83cyz3g6oc.fsf@gnu.org> X-purgate-type: clean X-purgate: clean X-purgate-size: 1377 X-purgate-ID: 155817::1693477333-F77FCE6D-10934858/0/0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:268808 Archived-At: On 2023-08-31 06:46, Eli Zaretskii wrote: >> Date: Wed, 30 Aug 2023 21:28:10 +0200 >> Cc: 63627@debbugs.gnu.org >> From: Jens Schmidt >> Next set of patches, I hope they are still eligible for emacs-29. >> >> The first patch fixes more documentation and terminology issues in >> plstore.el, still without touching any code. The second patch >> comprise ERT tests for plstore.el. Since that requires interaction >> with GnuPG, these tests are rather platform-dependent. Test setup >> should ensure that all tests are skipped if GnuPG is missing or not >> appropriate for the tests. > > Documentation fixes are always welcome on the release branch. > > As for tests: I don't really object, but what would be the purpose of > extending the test suite on the release branch? why not install that > on master instead? I thought about adding tests for 1-2 pending bugs in plstore.el in near future. But OTOH, these bugs are really not that significant, so probably it makes indeed more sense to add the tests to master only. >> Please check. > > What would you like me to check? Nothing in particular. Like: "Please check whatever you must check before committing such changes." Actually, it *would* be interesting to know what you check in such a situation, if it could be easily described. Thanks.