From: Drew Adams <drew.adams@oracle.com>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 18203@debbugs.gnu.org
Subject: bug#18203: 24.4.50; `ffap-url-p' should NOT be a defsubst
Date: Fri, 25 Dec 2015 14:44:16 -0800 (PST) [thread overview]
Message-ID: <8a81156c-8e23-4a2b-993f-d7b6f8f52a52@default> (raw)
In-Reply-To: <87io3muxdc.fsf@gnus.org>
> > There is NO reason for this to be a defsubst. There is no reason for
> > users not to take advantage of this function generally.
>
> I changed it to a defun,
Thank you.
> but I don't know what you mean by "There is no
> reason for users not to take advantage of this function generally.".
> You can use a defsubst just as you would a defun.
No, you cannot.
If existing code invokes a defsubst and you have only the compiled
version of that code, then you have no access to the function
defined by that defsubst. The function _does not exist_ at runtime.
You cannot advise it or debug it, and redefining it has no effect.
Taking advantage of the function _"generally"_ includes having it
available at runtime - it requires its existence _as a function_.
`defsubst's are almost a misfeature nowadays. In any case, they
be used should rarely, and only with good justification.
prev parent reply other threads:[~2015-12-25 22:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-05 20:21 bug#18203: 24.4.50; `ffap-url-p' should NOT be a defsubst Drew Adams
2015-12-25 19:44 ` Lars Ingebrigtsen
2015-12-25 22:44 ` Drew Adams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a81156c-8e23-4a2b-993f-d7b6f8f52a52@default \
--to=drew.adams@oracle.com \
--cc=18203@debbugs.gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).