From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Kirill A. Korinsky" via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#50534: 28.0.50; Toolbar shows despite tool-bar-mode being disabled on macOS Date: Tue, 14 Sep 2021 16:17:15 +0200 Message-ID: <8F5214BE-6F8B-46EE-9E02-537226186EE9@korins.ky> References: <43E37DDD-8314-4A12-8111-A7C48F625BD7@korins.ky> <16F124DC-AFCD-41D6-B039-CB1BD715FBFE@korins.ky> <34066D3F-0684-43B4-9460-44EC98806E28@korins.ky> Reply-To: "Kirill A. Korinsky" Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Content-Type: multipart/signed; boundary="Apple-Mail=_D4CE78D5-87EF-483A-BA30-868696120266"; protocol="application/pgp-signature"; micalg=pgp-sha512 Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26015"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 50534@debbugs.gnu.org To: Alan Third Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Sep 14 16:18:19 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mQ9GM-0006WZ-MR for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 14 Sep 2021 16:18:18 +0200 Original-Received: from localhost ([::1]:60964 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mQ9GL-0003Ub-C2 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 14 Sep 2021 10:18:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60960) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQ9G7-0003Nc-Ce for bug-gnu-emacs@gnu.org; Tue, 14 Sep 2021 10:18:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38176) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mQ9G7-0000nG-4J for bug-gnu-emacs@gnu.org; Tue, 14 Sep 2021 10:18:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mQ9G5-00070n-JX for bug-gnu-emacs@gnu.org; Tue, 14 Sep 2021 10:18:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Kirill A. Korinsky" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 14 Sep 2021 14:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50534 X-GNU-PR-Package: emacs Original-Received: via spool by 50534-submit@debbugs.gnu.org id=B50534.163162905426915 (code B ref 50534); Tue, 14 Sep 2021 14:18:01 +0000 Original-Received: (at 50534) by debbugs.gnu.org; 14 Sep 2021 14:17:34 +0000 Original-Received: from localhost ([127.0.0.1]:49722 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mQ9Fd-000703-Sf for submit@debbugs.gnu.org; Tue, 14 Sep 2021 10:17:34 -0400 Original-Received: from sender4-op-o12.zoho.com ([136.143.188.12]:17203) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mQ9Fc-0006zu-CJ for 50534@debbugs.gnu.org; Tue, 14 Sep 2021 10:17:33 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1631629049; cv=none; d=zohomail.com; s=zohoarc; b=Yrowr31JMpxxq/7zDaXm+VSudHH0cBG9oDwDztRaOyrc2ls9jnSCZMAKAOSOtXYXgRYTsxhIbcuCCFNf/IuwYevdB4og+eGkgfBdKWU5rzdzlidlVeG8ZmPkKbjsvvRigKACybTUyf8bhFvK6bTZbe4ngWQgQKZtnKaX90ts3pY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1631629049; h=Content-Type:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=5NpmV2GVVeVybEpDHuT4owh8SoUjz3BH6PI4BLi6S9I=; b=bisNuFjKsCOPL21cnevqRmxpxwVNSCTrN2Wea7kp4TtL+7Wsg0XB1y3lYoW7/waqZ5i0+VRdzPBRiMYO/Hral6MVP3IYlzoRVKvdlz2Gn1Y1eEivYSz6YKpeCwIVPa3RgEZaWTmFPO2cDSfFy+6YJt7D7NHivUCQxWkyVjXuKUs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=korins.ky; spf=pass smtp.mailfrom=kirill@korins.ky; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1631629049; s=april2018zoho; d=korins.ky; i=kirill@korins.ky; h=Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc:Message-Id:References:To; bh=5NpmV2GVVeVybEpDHuT4owh8SoUjz3BH6PI4BLi6S9I=; b=X40+oSJyoT6QyiCYzKTozFwwT6BLxjjsOW64J3QB7eH4nxhQJ5xce9RX2mCgzow2 Xous8ovIJYLL0cLOfZkkoG8zPXy86QXFvpu1x5zR5r+1McOCQBwe4rraoLfdX59a/TE bQd5LAw/5aDgPuv9oa3OagPUSccMenySF7WoQYIk= Original-Received: from smtpclient.apple (sa31.catap.net [90.187.54.213]) by mx.zohomail.com with SMTPS id 1631629039456349.70616304236535; Tue, 14 Sep 2021 07:17:19 -0700 (PDT) In-Reply-To: X-Mailer: Apple Mail (2.3654.120.0.1.13) X-Zoho-Virus-Status: 1 X-ZohoMailClient: External X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:214312 Archived-At: --Apple-Mail=_D4CE78D5-87EF-483A-BA30-868696120266 Content-Type: multipart/alternative; boundary="Apple-Mail=_6CE37DCF-86F4-4655-99D8-13A119C545E6" --Apple-Mail=_6CE37DCF-86F4-4655-99D8-13A119C545E6 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii Hey, I can't broke the nuclear option anymore. Seems it fixing everything. -- wbr, Kirill > On 14. Sep 2021, at 14:13, Alan Third wrote: > > On Tue, Sep 14, 2021 at 01:26:44PM +0200, Kirill A. Korinsky wrote: >> I have one bad news: it still exists but less often. >> >> I can reproduce it one time in 10 starts of my emacs. > > The *only* place that should modify FRAME_EXTERNAL_TOOL_BAR is > ns_set_tool_bar_lines, which should be called *every time* the number > of lines is changed. > > It would be nice to know what the value of FRAME_EXTERNAL_TOOL_BAR and > tool-bar-lines are when the toolbar is wrongly visible, because I > can't find a single location in the code that sets the visibility > without first checking FRAME_EXTERNAL_TOOL_BAR, and it should *always* > be set by ns_set_tool_bar_lines. > > *sigh* I've no idea. > > Attached is the nuclear option. If this doesn't work then > FRAME_EXTERNAL_TOOL_BAR is wrong. > > -- > Alan Third > <0001-A-further-fix-for-toolbar-visibility-problems-on-mac.patch> --Apple-Mail=_6CE37DCF-86F4-4655-99D8-13A119C545E6 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=us-ascii Hey,

I = can't broke the nuclear option anymore.

Seems it fixing everything.

-- 
wbr, Kirill

On 14. Sep 2021, at 14:13, Alan Third <alan@idiocy.org> = wrote:

On Tue, Sep 14, 2021 at 01:26:44PM +0200, Kirill A. Korinsky = wrote:
I have one bad = news: it still exists but less often.

I can = reproduce it one time in 10 starts of my emacs.

The *only* place that should = modify FRAME_EXTERNAL_TOOL_BAR is
ns_set_tool_bar_lines, = which should be called *every time* the number
of lines is = changed.

It would be nice to know what the = value of FRAME_EXTERNAL_TOOL_BAR and
tool-bar-lines are = when the toolbar is wrongly visible, because I
can't find = a single location in the code that sets the visibility
without first checking FRAME_EXTERNAL_TOOL_BAR, and it should = *always*
be set by ns_set_tool_bar_lines.

*sigh* I've no idea.

Attached is = the nuclear option. If this doesn't work then
FRAME_EXTERNAL_TOOL_BAR is wrong.

--
Alan Third
<0001-A-further-fix-for= -toolbar-visibility-problems-on-mac.patch>

= --Apple-Mail=_6CE37DCF-86F4-4655-99D8-13A119C545E6-- --Apple-Mail=_D4CE78D5-87EF-483A-BA30-868696120266 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE3/KLNtcfWfLw7JxqmNjZhndZIm4FAmFArusACgkQmNjZhndZ Im7dFxAAhZ22DLAiFdYS7o5j4rNldgnNrjJewsF0MkpkpSP9rLJLyeAE3RtXaP49 f3NlsB3rdjxIA5b+dekQ4deSxWEWUas5HAAkXR3bVlEh1MUaHR2rEQo4mUzajThn u2IVxOGZLsJLab4be+Jhy3xrbwlk6PIKo7eMr1+BIP5/P/cuEwxNJui4ohynqeDs uyAsIlUqCUAwfJmubPoVgcJYGMhRBT7Kq0MnwcEJ26JDMVDzNIrKz2XtYsgQ0sqg 4XL4lEP8QiNOQ6A43tQm4rmMgn0Vh0BqqSIsWdU1tTIwzxEbaz1jyFWZB/u/Atnn 9ZeVxdlZQa6BJClga0tHKfRtFBce4qArfum4AmYTAy/+mSdPIaORC3lIeSrW/ABM 4b/BFaXpCqdA9PY0zRJf+ahmvd0sYoBU+AfvlCxFqtV54ricUYRea9Mr4sGZ3YMW 6d6Pf5k8A+i8oMsa4li4i4yOcBScnTTNA+hesvni6gRxMWCLJG7Vx8CkNzj02Axa GLbYeG63rRonmiJyev6xbbIEmbryy1vLHWWm2IOm5B57TBhiCHIoNmZndyQMOnui DcabUSNCMczsmc/vKrBajSUVrMywwIGt8xMo9pSxDROE2xgjo2XxMJ7mJXSfbm5V Z7uH18fatLwMO4KLbcoc0UJSvrLMaD76/WEuPclPsJsLayMHjtw= =EQ3H -----END PGP SIGNATURE----- --Apple-Mail=_D4CE78D5-87EF-483A-BA30-868696120266--