From: "Drew Adams" <drew.adams@oracle.com>
To: "'Chong Yidong'" <cyd@stupidchicken.com>
Cc: 4835@emacsbugs.donarmstrong.com
Subject: bug#4835: 23.1; Improper `Invalid face reference' messages. Performance degraded.
Date: Sat, 31 Oct 2009 14:10:01 -0700 [thread overview]
Message-ID: <8F2C3E771C104B03B9926AB1AAFD02A5@us.oracle.com> (raw)
In-Reply-To: <87pr83th6b.fsf@stupidchicken.com>
> > We should make the right fix, not the easiest one based on our not
> > being sure what the code does or why.
>
> It's pretty clear, from the doc string plus the various parts of
> font-lock code that assume function names, that the code was not
> intended to work with lambda expressions. It would be nice
> if it worked with lambda expressions, but that would be a new
> feature, not a bug fix.
Nonsense. You could say that it's crystal clear from the Elisp manual that
_function_ was meant (since that's what is says) and not symbol function or
"function name" (which would be a string). The code is bugged wrt its mission as
documented in the manual, which is the closest thing we have to a spec.
Kidding aside, this is a chance to DTRT, not just sidestep the problem because
the code might be unclear or it takes some studying to understand it.
At any rate, as I said, the bug (`Invalid face reference' messages and the
attendant slowdown) seems to be there even when I use a symbol function. Unless
I'm doing something wrong (which is why I asked for help).
next prev parent reply other threads:[~2009-10-31 21:10 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-31 18:59 bug#4835: 23.1; Improper `Invalid face reference' messages. Performance degraded Chong Yidong
2009-10-31 19:09 ` Drew Adams
2009-10-31 19:37 ` Chong Yidong
2009-10-31 19:51 ` Drew Adams
2009-10-31 20:57 ` Chong Yidong
2009-10-31 21:10 ` Drew Adams [this message]
2009-10-31 22:05 ` Chong Yidong
2009-10-31 22:40 ` Drew Adams
2009-10-31 23:42 ` Chong Yidong
2009-11-01 0:04 ` Drew Adams
2009-11-09 23:44 ` Drew Adams
2009-12-09 18:23 ` Drew Adams
2009-12-09 23:12 ` bojohan+news
2009-12-10 17:36 ` Drew Adams
2009-12-11 4:49 ` Kevin Rodgers
2009-12-12 4:48 ` Stefan Monnier
2016-04-27 20:20 ` Lars Ingebrigtsen
2016-04-27 21:19 ` Drew Adams
-- strict thread matches above, loose matches on Subject: below --
2009-10-30 22:48 Drew Adams
2009-10-31 3:26 ` Stefan Monnier
2009-10-31 7:41 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8F2C3E771C104B03B9926AB1AAFD02A5@us.oracle.com \
--to=drew.adams@oracle.com \
--cc=4835@emacsbugs.donarmstrong.com \
--cc=cyd@stupidchicken.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).