From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Kai Ma Newsgroups: gmane.emacs.bugs Subject: bug#59794: 29.0.60; NSport segfaults when a fullscreen frame is being closed) Date: Sun, 4 Dec 2022 22:04:05 +0800 Message-ID: <8F149CA1-348B-477A-AF9E-47A5D438E262@gmail.com> References: <835yerd5gb.fsf@gnu.org> <87ilirr0uq.fsf@yahoo.com> <83ilirbh68.fsf@gnu.org> <87a643qt09.fsf@yahoo.com> <838rjnbbqc.fsf@gnu.org> <0137C1CC-0AEC-4790-85E6-D1AD987A63E1@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.200.110.1.12\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25534"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Po Lu , Gerd =?UTF-8?Q?M=C3=B6llmann?= , Eli Zaretskii , 59794@debbugs.gnu.org To: Daniel =?UTF-8?Q?Mart=C3=ADn?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 04 15:05:18 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p1pcM-0006Pv-Su for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 04 Dec 2022 15:05:18 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p1pc9-0005Su-JT; Sun, 04 Dec 2022 09:05:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p1pc6-0005Sc-Ia for bug-gnu-emacs@gnu.org; Sun, 04 Dec 2022 09:05:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p1pc6-0003Kr-0R for bug-gnu-emacs@gnu.org; Sun, 04 Dec 2022 09:05:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p1pc5-00006S-QH for bug-gnu-emacs@gnu.org; Sun, 04 Dec 2022 09:05:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Kai Ma Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 04 Dec 2022 14:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59794 X-GNU-PR-Package: emacs Original-Received: via spool by 59794-submit@debbugs.gnu.org id=B59794.1670162670372 (code B ref 59794); Sun, 04 Dec 2022 14:05:01 +0000 Original-Received: (at 59794) by debbugs.gnu.org; 4 Dec 2022 14:04:30 +0000 Original-Received: from localhost ([127.0.0.1]:57863 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p1pba-00005r-C9 for submit@debbugs.gnu.org; Sun, 04 Dec 2022 09:04:30 -0500 Original-Received: from mail-pj1-f65.google.com ([209.85.216.65]:37509) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p1pbW-00005i-BX for 59794@debbugs.gnu.org; Sun, 04 Dec 2022 09:04:28 -0500 Original-Received: by mail-pj1-f65.google.com with SMTP id o1-20020a17090a678100b00219cf69e5f0so551556pjj.2 for <59794@debbugs.gnu.org>; Sun, 04 Dec 2022 06:04:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ycFdovQfQhscCu0j9TsssZ0XkSVJzBAKaNwnuxfqLtA=; b=HkrD4Hb61l0BrLS9/HLnf3KHVsF7+O+nxKnhdCQh3gzQkdZ3XbEwue5Z0uiX7XJ2sK dSkNXvgm3fSgUb2srgOKMC0ZfpPhqnQkj3N2k6rDM3lF5jo1842QtPkBT1uEc2peMJv+ v29bIfzOMP3W7q80Iun5gVqVau5UizggYPqfqAEewG1MFRZ+ZHk8VfRik5A5lgg+UWAI ZWUbfzI6wqsNjk+OyD0oimqhbVZVi/LwWyDhqqQtZVSICi967nJxVPJYtF0CRcPML3Al d8xbkFlkx5renjPBXFPqLz85nzNc6se9HpK3qQSCsFCKyn6diLTDTbxb74J5mbjHP0Kh J/Gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ycFdovQfQhscCu0j9TsssZ0XkSVJzBAKaNwnuxfqLtA=; b=Xd4E3rNFW1BLBWClZevXgkuMDOc3z8DA725HBIjIAnWb8D/5jQ46CnwZBjorxURn/8 xNjm96SjgBoxmlopRNnL07D1pKDU0aPV7FPuiTnfxlH+YFH29YeOZQPhIQwA8zyG6gJO s+K7v/Xeehy6MQ+UMOAu1Ba4tsp6z8mo1eZq0w+pLEiu8pKoiv9TpNjHpCIt9GsYpXBW HpGSPARffTKsSmoeWgDhKga0jYi++5fIft72L76i+g4PMi9zzzG9fMF9ZF1kjJ8WamzV toCE404KR7VUblp4SYD4Ez9puyJKpJ4XVeuzj8tk5vXjzVySDC0etVMQpg3TUNrDMgg7 jRRw== X-Gm-Message-State: ANoB5pmifbl6vKhiIzFpY8VkgX9yowLMQq1VkQFRiPzrECfZrt9XGfAr rUO838C+Ux3SDoqCOnimfPA= X-Google-Smtp-Source: AA0mqf69oOJvet0CFhh/1Zh9F5XQvlwcBAW4eRKLgA5NViDorTPmfxqnaVX6ZaxtsYGk4fxQV4X5Xw== X-Received: by 2002:a17:903:228a:b0:189:d82e:79d1 with SMTP id b10-20020a170903228a00b00189d82e79d1mr689421plh.70.1670162660517; Sun, 04 Dec 2022 06:04:20 -0800 (PST) Original-Received: from smtpclient.apple (n058153170106.netvigator.com. [58.153.170.106]) by smtp.gmail.com with ESMTPSA id b15-20020a170902d50f00b00174f61a7d09sm8819363plg.247.2022.12.04.06.04.18 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 04 Dec 2022 06:04:20 -0800 (PST) In-Reply-To: X-Mailer: Apple Mail (2.3731.200.110.1.12) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:249943 Archived-At: > On Dec 4, 2022, at 21:53, Daniel Mart=C3=ADn = wrote: >=20 > Kai Ma writes: >=20 >>=20 >> diff --git a/src/nsterm.m b/src/nsterm.m >> index 507f2a9e7d..f99d7cde3c 100644 >> --- a/src/nsterm.m >> +++ b/src/nsterm.m >> @@ -6703,8 +6703,18 @@ - (BOOL)acceptsFirstResponder >>=20 >> - (void)resetCursorRects >> { >> - NSRect visible =3D [self visibleRect]; >> - NSCursor *currentCursor =3D FRAME_POINTER_TYPE (emacsframe); >> + NSRect visible; >> + NSCursor *currentCursor; >> + >> + /* FIXME: [resetCursorRects:] can be called from the event loop >> + after the frame is deleted. When this happens, >> + emacsframe->output_data is NULL. This means there is an >> + underlying leak of the EmacsView object! (bug#59794) */ >> + if (! emacsframe || ! FRAME_OUTPUT_DATA (emacsframe)) >=20 > Wouldn't it be more clear to check !FRAME_LIVE_P (emacsframe) instead? > (I can't reproduce this bug, so I don't know if that would avoid the > crash.) There is a similar check in - (void)windowWillExitFullScreen > and - (void)windowDidExitFullScreen, for example. Indeed! I can confirm this check also fixes the crash here. Kai=