From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#69714: [PATCH] Improve ert-font-lock assertion parser Date: Sat, 30 Mar 2024 13:52:05 +0100 Message-ID: <8EAA90DF-C567-4ADA-81DB-F074FE73ADAF@gmail.com> References: Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10069"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 69714@debbugs.gnu.org To: Vladimir Kazanov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Mar 30 13:53:24 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rqYD6-0002PI-9a for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 30 Mar 2024 13:53:24 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rqYCl-0006vf-T9; Sat, 30 Mar 2024 08:53:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rqYCk-0006v6-7G for bug-gnu-emacs@gnu.org; Sat, 30 Mar 2024 08:53:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rqYCj-0003DL-Uu for bug-gnu-emacs@gnu.org; Sat, 30 Mar 2024 08:53:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rqYCl-0006Nm-Pk for bug-gnu-emacs@gnu.org; Sat, 30 Mar 2024 08:53:03 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 30 Mar 2024 12:53:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69714 X-GNU-PR-Package: emacs Original-Received: via spool by 69714-submit@debbugs.gnu.org id=B69714.171180313724361 (code B ref 69714); Sat, 30 Mar 2024 12:53:03 +0000 Original-Received: (at 69714) by debbugs.gnu.org; 30 Mar 2024 12:52:17 +0000 Original-Received: from localhost ([127.0.0.1]:44173 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rqYC0-0006Kq-Um for submit@debbugs.gnu.org; Sat, 30 Mar 2024 08:52:17 -0400 Original-Received: from mail-lf1-x12a.google.com ([2a00:1450:4864:20::12a]:53492) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rqYBz-0006K4-48 for 69714@debbugs.gnu.org; Sat, 30 Mar 2024 08:52:15 -0400 Original-Received: by mail-lf1-x12a.google.com with SMTP id 2adb3069b0e04-513e6777af4so4487076e87.2 for <69714@debbugs.gnu.org>; Sat, 30 Mar 2024 05:52:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711803127; x=1712407927; darn=debbugs.gnu.org; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=dlXsZgEGzxt1FIHYvVpiTDpquaFw+nGPi2U5Bq3ynd0=; b=CMH+Qcw2kZK3ytrrLDyo6MwsdtVxhKzOc9POFdv/2OMmQVoWkDdjgBHDiXdjniTfsv 94Kz2iFZdowjc+9Ek70a7RMOQWp2BXLLrGhJQwRlU2Si/fVT2a5NH/bbiT2aK16QDJS+ ifD8ZG7Gol3WZES8jzR9VEUZoYNJC/W7o+79VTGiDfhmXHn1Caq9hQsDFDUyEes5/chJ v5f/zT1Dtzc2r6CUaq88yaXJbawFp7gr1YdSOVlXoqh5mF/EjctATTF7WKvFbBemuVxd xqfd5N1vm3odNItc5HEAiJ/HgtEIiNH0p9bMiAhSwO1Omc/3FgXUYpN0entyFQ5YaI7s +9pQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711803127; x=1712407927; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dlXsZgEGzxt1FIHYvVpiTDpquaFw+nGPi2U5Bq3ynd0=; b=rZEP/5shtv7QUvEWQkDwMJlflGkm3XUpsGDKw5vzArEkllK+LCWsq9huPI9P1vwmO8 1qCRAMFBPDj33bX/C34UQ91WXo/ItsZa+6huq0pBxcYiamU7Cg9eum6QXVGopykZ0HIx uixG1wbCAtevdaNvSYk5ZhpImJ2U49mCJG9BSC0b3490Twgn1BvNcM2WwCljx84lFN8D LUTBT5Hh48S4JI/Vhphcxy75GUtKo4wZtZWS5MnFUeW83q2fSszuzt5/ewFlez6ivIvF BFXVieZpITlISqwCjU430rArWrYum04PsmwObJa9P8450AcV9weST95KLknPOj2QNFJb bOMw== X-Forwarded-Encrypted: i=1; AJvYcCVn3K8V9KudJT0oZuJ/x2M2LiDOK81xpLvFTRze2R0t6zYysBVVmja3xOWofIhh42icjxCavbl9hodId7Z8IFpDYoq4snY= X-Gm-Message-State: AOJu0YxOlAEdv1WYctr+34vRwrDjyBDVeVhE8PviVTzKlevj29xWFa5P 5ruuh/VUIbZSgZpE4oYAeITsE5UTCAA0bbdBbhU+gXqZBxz1ZeSnjEK5jXul X-Google-Smtp-Source: AGHT+IFpBvmk0a++U3txystmKM9MtUz4QMlg1Uj6wMaLmprC0akpKnS53JYz8HuW4q6BjM2gLPTDWQ== X-Received: by 2002:a05:6512:2389:b0:513:a766:4672 with SMTP id c9-20020a056512238900b00513a7664672mr5176287lfv.4.1711803126937; Sat, 30 Mar 2024 05:52:06 -0700 (PDT) Original-Received: from smtpclient.apple (c80-217-1-132.bredband.tele2.se. [80.217.1.132]) by smtp.gmail.com with ESMTPSA id y4-20020a199144000000b00514b644bfebsm912883lfj.299.2024.03.30.05.52.06 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 30 Mar 2024 05:52:06 -0700 (PDT) X-Mailer: Apple Mail (2.3654.120.0.1.15) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:282357 Archived-At: Vladimir, thank you for your patch. However, this regexp: > (defconst ert-font-lock--face-symbol-re > (rx (one-or-more (or alphanumeric "-" "_" "."))) > "A face symbol matching regex.") >=20 > (defconst ert-font-lock--face-symbol-list-re > (rx "(" > (* whitespace) > (one-or-more > (seq (regexp ert-font-lock--face-symbol-re) > (* whitespace))) > ")") > "A face symbol list matching regex.") is rather inefficient. (Relint complained about it, which is why I am = here). The problem is that (one-or-more (seq (one-or-more (or alphanumeric "-" "_" ".")) (* whitespace))) can match a string that consists of alphanumeric characters, say, in = many different ways because of the nested `one-or-more`; the (* = whitespace) can match the empty string anywhere. Try, for instance: (string-match ert-font-lock--face-symbol-list-re (concat "(" (make-string 20 ?a))) which should return nil as it doesn't match. Now try raising the number from 20 to 25, then 30. If you want the regexp to match a list of one or more symbols, what = about this: (rx "(" (* whitespace) (regexp ert-font-lock--face-symbol-re) (* (+ whitespace) (regexp ert-font-lock--face-symbol-re)) ")")