From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.bugs Subject: bug#13670: 24.3.50; `autoload-generate-file-autoloads' off-by-one bug Date: Sat, 9 Feb 2013 16:03:30 -0800 Message-ID: <8E0945F19B9F4E37BA18A7A2232F6411@us.oracle.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1360454637 6645 80.91.229.3 (10 Feb 2013 00:03:57 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 10 Feb 2013 00:03:57 +0000 (UTC) To: 13670@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Feb 10 01:04:18 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1U4KP2-0005K6-Qk for geb-bug-gnu-emacs@m.gmane.org; Sun, 10 Feb 2013 01:04:17 +0100 Original-Received: from localhost ([::1]:49358 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U4KOj-0004jY-C1 for geb-bug-gnu-emacs@m.gmane.org; Sat, 09 Feb 2013 19:03:57 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:54226) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U4KOf-0004jD-4S for bug-gnu-emacs@gnu.org; Sat, 09 Feb 2013 19:03:55 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U4KOd-0004SC-RS for bug-gnu-emacs@gnu.org; Sat, 09 Feb 2013 19:03:52 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:41967) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U4KOd-0004S8-Oq for bug-gnu-emacs@gnu.org; Sat, 09 Feb 2013 19:03:51 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1U4KOo-0004dy-Gl for bug-gnu-emacs@gnu.org; Sat, 09 Feb 2013 19:04:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 10 Feb 2013 00:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 13670 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: Original-Received: via spool by submit@debbugs.gnu.org id=B.136045463917838 (code B ref -1); Sun, 10 Feb 2013 00:04:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 10 Feb 2013 00:03:59 +0000 Original-Received: from localhost ([127.0.0.1]:47431 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U4KOl-0004df-2x for submit@debbugs.gnu.org; Sat, 09 Feb 2013 19:03:59 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:42844) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U4KOi-0004dW-Rx for submit@debbugs.gnu.org; Sat, 09 Feb 2013 19:03:58 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U4KOV-0004Qa-Be for submit@debbugs.gnu.org; Sat, 09 Feb 2013 19:03:45 -0500 Original-Received: from lists.gnu.org ([208.118.235.17]:58932) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U4KOV-0004QR-8p for submit@debbugs.gnu.org; Sat, 09 Feb 2013 19:03:43 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:54200) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U4KOU-0004jA-3D for bug-gnu-emacs@gnu.org; Sat, 09 Feb 2013 19:03:43 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U4KOS-0004QG-S9 for bug-gnu-emacs@gnu.org; Sat, 09 Feb 2013 19:03:41 -0500 Original-Received: from userp1040.oracle.com ([156.151.31.81]:48227) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U4KOS-0004QC-Kh for bug-gnu-emacs@gnu.org; Sat, 09 Feb 2013 19:03:40 -0500 Original-Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237]) by userp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id r1A03dxn031779 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sun, 10 Feb 2013 00:03:39 GMT Original-Received: from acsmt356.oracle.com (acsmt356.oracle.com [141.146.40.156]) by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r1A03cUh017155 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Sun, 10 Feb 2013 00:03:39 GMT Original-Received: from abhmt112.oracle.com (abhmt112.oracle.com [141.146.116.64]) by acsmt356.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id r1A03ctx002348 for ; Sat, 9 Feb 2013 18:03:38 -0600 Original-Received: from dradamslap1 (/71.202.147.44) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sat, 09 Feb 2013 16:03:38 -0800 X-Mailer: Microsoft Office Outlook 11 Thread-Index: Ac4HIg9BGgOZKMTyTYKnEbiJp5w1BQ== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: acsinet21.oracle.com [141.146.126.237] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:70971 Archived-At: This source code line of `autoload-generate-file-autoloads': (if (= (char-after (1+ (point))) ? ) should be replaced by this: (if (= (char-after (point)) ? ) The aim is to preserve the whitespace that occurs after a separating whitespace character, not to preserve also that separating character. `;;;###autoload' cannot be followed by normal text, or else the cookie is not recognized as such. But you can follow it by a space and then the text that you want. The space is not part of the text to be copied to the output file; it is only a separator for parsing the cookie. E.g. Suppose you want to have a multiline doc string, such as this: "Icicle mode: Toggle minibuffer input completion and cycling. Non-nil prefix ARG turns mode on if ARG > 0, else off. It is a global minor mode. It binds minibuffer keys." You can use cookies like this: ;;;###autoload (autoload 'icicle-mode "icicles" ;;;###autoload"Icicle mode: Toggle minibuffer input completion and cycling. ;;;###autoload Non-nil prefix ARG turns mode on if ARG > 0, else off. ;;;###autoload It is a global minor mode. It binds minibuffer keys." ;;;###autoload t nil) But with the bugged code that preserves the space separator as if it were part of the doc string, the result is this: (autoload 'icicle-mode "icicles" "Icicle mode: Toggle minibuffer input completion and cycling. Non-nil prefix ARG turns mode on if ARG > 0, else off. It is a global minor mode. It binds minibuffer keys." t nil) which gives the erroneous doc string: "Icicle mode: Toggle minibuffer input completion and cycling. Non-nil prefix ARG turns mode on if ARG > 0, else off. It is a global minor mode. It binds minibuffer keys." With the fix, the result is correct: (autoload 'icicle-mode "icicles" "Icicle mode: Toggle minibuffer input completion and cycling. Non-nil prefix ARG turns mode on if ARG > 0, else off. It is a global minor mode. It binds minibuffer keys." t nil) Doc string: "Icicle mode: Toggle minibuffer input completion and cycling. Non-nil prefix ARG turns mode on if ARG > 0, else off. It is a global minor mode. It binds minibuffer keys." However, I see that this bug (as I see it) dates back to at least Emacs 20.7. So if I am wrong that this is a bug, please explain how to get proper multiline doc strings. In GNU Emacs 24.3.50.1 (i386-mingw-nt5.1.2600) of 2013-02-08 on VBOX-W7 Bzr revision: 111700 monnier@iro.umontreal.ca-20130208174209-vpjpdh4qipaceoh5 Windowing system distributor `Microsoft Corp.', version 5.1.2600 Configured using: `configure --with-gcc (4.7) --no-opt --enable-checking --cflags -IC:/emacs/libs/libXpm-3.5.10/include -IC:/emacs/libs/libXpm-3.5.10/src -IC:/emacs/libs/libpng-dev_1.4.3-1_win32/include -IC:/emacs/libs/zlib-dev_1.2.5-2_win32/include -IC:/emacs/libs/giflib-4.1.4-1-lib/include -IC:/emacs/libs/jpeg-6b-4-lib/include -IC:/emacs/libs/tiff-3.8.2-1-lib/include -IC:/emacs/libs/libxml2-2.7.8-w32-bin/include/libxml2 -IC:/emacs/libs/gnutls-3.1.5-w32/include -IC:/emacs/libs/libiconv-1.14-2-mingw32-dev/include'