bug#2836:

bug#2836:

[David Reitter]

First, I reproduce this only when the system and Emacs are set up to  
switch off antialiasing for a font as small as that.
With antialiasing on, the error doesn't occur.  (Can be reproduced  
with Emacs -Q, which seems to use special settings for antialiasing,  
or with
(setq ns-antialias-text nil)).

Reintroducing line spacing (which was removed for a reason) not only  
fixes this bug, but has global consequences.

So I don't think this is the right way to fix this bug.  I think we  
have to look at the code that draws the non-antialiased text.

For now, the workaround for this is

(set-frame-parameter nil 'line-spacing 2)
(or setting defaut-frame-alist accordingly).

bug#2836:

[David Caldwell]

On 4/27/09 3:52 PM, David Reitter wrote:

>> Reintroducing line spacing (which was removed for a reason) not only
>> fixes this bug, but has global consequences.

I'm curious what the reasons are since it wasn't really explained in the
check-in comments. I've been running with my patch now for 3 months and
haven't seen any visual oddities. But perhaps my anti-aliasing settings
are masking what the original change was for...

>> So I don't think this is the right way to fix this bug.  I think we
>> have to look at the code that draws the non-antialiased text.
>>
>> For now, the workaround for this is
>>
>> (set-frame-parameter nil 'line-spacing 2)
>> (or setting defaut-frame-alist accordingly).

This does fix the descenders being chopped off, but ends up making the
block cursor not cover the whole glyph it's highlighting--it's really ugly.

Any idea if we'll get a real fix (or one our workarounds) into CVS
before emacs 23.1 is released?

-David

bug#2836:

[David Reitter]

[-- Attachment #1: Type: text/plain, Size: 1238 bytes --]

On Jul 17, 2009, at 12:49 AM, David Caldwell wrote:
> I'm curious what the reasons are since it wasn't really explained in  
> the
> check-in comments. I've been running with my patch now for 3 months  
> and
> haven't seen any visual oddities. But perhaps my anti-aliasing  
> settings
> are masking what the original change was for...

One reason was that markings in the fringe are oddly divided if line  
spacing is used, rather than continuous.  The other one was to use the  
standard line spacing on the system, and the same line spacing as in  
Emacs 22 (Carbon).

>>> For now, the workaround for this is
>>>
>>> (set-frame-parameter nil 'line-spacing 2)
>>> (or setting defaut-frame-alist accordingly).
>
> This does fix the descenders being chopped off, but ends up making the
> block cursor not cover the whole glyph it's highlighting--it's  
> really ugly.

That per se is a bug and should be changed.  It's probably easier to  
fix.

> Any idea if we'll get a real fix (or one our workarounds) into CVS
> before emacs 23.1 is released?

If someone provides one and it is considered safe, maybe yes.
But I wouldn't worry too much about the release, given the long list  
of NS specific bugs that the release will have anyways.

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 2193 bytes --]