From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Theodor Thornhill via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#60961: 29.0.60; Compiling emacs-29 without treesitter outputs warnings Date: Fri, 20 Jan 2023 17:07:28 +0100 Message-ID: <8A47E6B6-BE4F-44F4-9BC5-55B6051CDCD4@thornhill.no> References: <878rhx1os6.fsf@gmail.com> <831qnpnx9g.fsf@gnu.org> <87o7qtuxgh.fsf@thornhill.no> <83tu0lmgv6.fsf@gnu.org> <87h6wll10q.fsf@thornhill.no> <83r0vpme0t.fsf@gnu.org> Reply-To: Theodor Thornhill Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18606"; mail-complaints-to="usenet@ciao.gmane.io" Cc: rpluim@gmail.com, casouri@gmail.com, 60961@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jan 20 17:09:16 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pItx6-0004aE-FF for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 20 Jan 2023 17:09:16 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pItwu-000788-My; Fri, 20 Jan 2023 11:09:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pItws-00077a-Id for bug-gnu-emacs@gnu.org; Fri, 20 Jan 2023 11:09:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pItws-0000HK-Ap for bug-gnu-emacs@gnu.org; Fri, 20 Jan 2023 11:09:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pItwr-00073W-Mp for bug-gnu-emacs@gnu.org; Fri, 20 Jan 2023 11:09:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Theodor Thornhill Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 Jan 2023 16:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60961 X-GNU-PR-Package: emacs Original-Received: via spool by 60961-submit@debbugs.gnu.org id=B60961.167423093527110 (code B ref 60961); Fri, 20 Jan 2023 16:09:01 +0000 Original-Received: (at 60961) by debbugs.gnu.org; 20 Jan 2023 16:08:55 +0000 Original-Received: from localhost ([127.0.0.1]:46937 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pItwk-00073B-QO for submit@debbugs.gnu.org; Fri, 20 Jan 2023 11:08:55 -0500 Original-Received: from out0.migadu.com ([94.23.1.103]:63152) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pItwi-000732-W1 for 60961@debbugs.gnu.org; Fri, 20 Jan 2023 11:08:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1674230930; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3H+YWvTFPahc/ZFQtR/uHKmEfTlPfwUfoRITLRokK8A=; b=rZscHL0G75mbKf3IUkMGYCzbbvn3czhGHLtUnQiqkejmAwF80Uc2aQ55WQCAkbcS63b/Bx bgLUe2dDjmzX9kdvN3H9c0Xke54FE2VzK6QIYiodTvjk8A0DdHnY1Z6159ZcvNOWHCvpMt q04bmxWuEm3yQSN2163HC8FRHwTHYcx2M6k0HiZT8/5dXqVdtH4oqsHI3Gpp+j3VDkRgsh kGcKyWn62YVMeOCJkllfFOwqXyr/VukwOH6b80YbKBklQVroYJ/eU7h3nFTxwus7iSRpNG uJuvMPGACUUDGSvGcQPXqOtCe1NQMwY0Ysb4leJjEH2IPND+AAV9KF9w2UH6BQ== X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. In-Reply-To: <83r0vpme0t.fsf@gnu.org> X-Migadu-Flow: FLOW_OUT X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:253784 Archived-At: On 20 January 2023 16:17:22 CET, Eli Zaretskii wrote: >> From: Theodor Thornhill >> Cc: rpluim@gmail=2Ecom, casouri@gmail=2Ecom, 60961@debbugs=2Egnu=2Eorg >> Date: Fri, 20 Jan 2023 15:43:33 +0100 >>=20 >> Eli Zaretskii writes: >>=20 >> >> So I can either just make sure that no modes require across modes, o= r >> >> make that "lib" right now=2E What do you think? >> > >> > I tend to the "lib" method=2E Mostly because several modes, includin= g >> > some that are unrelated to C, want the code which was written for >> > C/C++, and so it is possible that there's some general feature here >> > waiting for us to refactor the code -- in which case perhaps the code >> > should be in treesit=2Eel? >> > >> > IOW, how come JS, Rust, and Typescript all want comment-related setup >> > that was written for C? If this is just a coincidence, then perhaps >> > duplicating the code is a better idea, but if there's some underlying >> > commonality, we should have common code in treesit=2Eel, or maybe in >> > some c-ts-common=2Eel? >>=20 >> I can start by moving it into treesit=2Eel, then we can maybe extract >> something out later=2E Sounds good? I can do it tonight, unless any o= f >> you object :) > >SGTM, but let's hear from Yuan before you start working on this=2E > >Thanks=2E Thumbs up