unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Theodor Thornhill via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: rpluim@gmail.com, casouri@gmail.com, 60961@debbugs.gnu.org
Subject: bug#60961: 29.0.60; Compiling emacs-29 without treesitter outputs warnings
Date: Fri, 20 Jan 2023 17:07:28 +0100	[thread overview]
Message-ID: <8A47E6B6-BE4F-44F4-9BC5-55B6051CDCD4@thornhill.no> (raw)
In-Reply-To: <83r0vpme0t.fsf@gnu.org>



On 20 January 2023 16:17:22 CET, Eli Zaretskii <eliz@gnu.org> wrote:
>> From: Theodor Thornhill <theo@thornhill.no>
>> Cc: rpluim@gmail.com, casouri@gmail.com, 60961@debbugs.gnu.org
>> Date: Fri, 20 Jan 2023 15:43:33 +0100
>> 
>> Eli Zaretskii <eliz@gnu.org> writes:
>> 
>> >> So I can either just make sure that no modes require across modes, or
>> >> make that "lib" right now.  What do you think?
>> >
>> > I tend to the "lib" method.  Mostly because several modes, including
>> > some that are unrelated to C, want the code which was written for
>> > C/C++, and so it is possible that there's some general feature here
>> > waiting for us to refactor the code -- in which case perhaps the code
>> > should be in treesit.el?
>> >
>> > IOW, how come JS, Rust, and Typescript all want comment-related setup
>> > that was written for C?  If this is just a coincidence, then perhaps
>> > duplicating the code is a better idea, but if there's some underlying
>> > commonality, we should have common code in treesit.el, or maybe in
>> > some c-ts-common.el?
>> 
>> I can start by moving it into treesit.el, then we can maybe extract
>> something out later.  Sounds good?  I can do it tonight, unless any of
>> you object :)
>
>SGTM, but let's hear from Yuan before you start working on this.
>
>Thanks.

Thumbs up





  reply	other threads:[~2023-01-20 16:07 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-20 10:30 bug#60961: 29.0.60; Compiling emacs-29 without treesitter outputs warnings Robert Pluim
2023-01-20 13:36 ` Eli Zaretskii
2023-01-20 13:50   ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-20 14:15     ` Eli Zaretskii
2023-01-20 14:43       ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-20 15:17         ` Eli Zaretskii
2023-01-20 16:07           ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-01-20 22:11             ` Yuan Fu
2023-01-20 22:30               ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-20 22:36                 ` Yuan Fu
2023-01-21  4:18               ` Eli Zaretskii
2023-01-21 12:24                 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-21 12:38                   ` Eli Zaretskii
2023-01-21 12:46                     ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8A47E6B6-BE4F-44F4-9BC5-55B6051CDCD4@thornhill.no \
    --to=bug-gnu-emacs@gnu.org \
    --cc=60961@debbugs.gnu.org \
    --cc=casouri@gmail.com \
    --cc=eliz@gnu.org \
    --cc=rpluim@gmail.com \
    --cc=theo@thornhill.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).