From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: David Ponce Newsgroups: gmane.emacs.bugs Subject: bug#66846: 30.0.50; unexpected behavior of icon with non-existing image file? Date: Tue, 31 Oct 2023 16:28:21 +0100 Message-ID: <89c6f6a5-d35e-4363-a04a-995dab69a361@orange.fr> References: <6a6a88f4-dc7c-44a4-9f09-5b3f184df971@orange.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12499"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird To: 66846@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Oct 31 16:28:53 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qxqfk-00036p-Rh for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 31 Oct 2023 16:28:52 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qxqfX-0003xE-1T; Tue, 31 Oct 2023 11:28:41 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qxqfN-0003vy-JI for bug-gnu-emacs@gnu.org; Tue, 31 Oct 2023 11:28:29 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qxqfM-0001ou-LJ for bug-gnu-emacs@gnu.org; Tue, 31 Oct 2023 11:28:29 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qxqfu-0007lS-8p for bug-gnu-emacs@gnu.org; Tue, 31 Oct 2023 11:29:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: David Ponce Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 31 Oct 2023 15:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66846 X-GNU-PR-Package: emacs Original-Received: via spool by 66846-submit@debbugs.gnu.org id=B66846.169876614029838 (code B ref 66846); Tue, 31 Oct 2023 15:29:02 +0000 Original-Received: (at 66846) by debbugs.gnu.org; 31 Oct 2023 15:29:00 +0000 Original-Received: from localhost ([127.0.0.1]:48997 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qxqfr-0007lC-K5 for submit@debbugs.gnu.org; Tue, 31 Oct 2023 11:28:59 -0400 Original-Received: from smtp-27.smtpout.orange.fr ([80.12.242.27]:52429 helo=smtp.smtpout.orange.fr) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qxqfp-0007l1-Kg for 66846@debbugs.gnu.org; Tue, 31 Oct 2023 11:28:58 -0400 Original-Received: from [192.168.1.15] ([2.7.71.181]) by smtp.orange.fr with ESMTPA id xqfFqZInSaLS1xqfGqUHRh; Tue, 31 Oct 2023 16:28:22 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=orange.fr; s=t20230301; t=1698766102; bh=dxi0vCFJp487BnGx9rXsf0bmKQ/1xgyCEcShYF1KwxM=; h=Date:Subject:From:To:References:In-Reply-To; b=Y/swVYI0BbLC2omZDqi+d/WoPBTtPIlFDRHlJNg9+3Z0hwcojUeA6b2CXeJUISOat 0InDBEHqHHlpzW7YdBe+j8ia6FrpZvK5dt9z4jZ/YKf7Sfg27Un90lFV7aI3/OvjKd QlHOqt6gtF0Rh5s5hM3UgJLrj752/YofPuf8bL0t2Ql1avJg1B7FPMbMyFiPa74Xi5 CnRO6QgkrGIsrpW0jyTI1F7U7QXjrg8dARjE7E8ywDnI0cbvzmEl/7qFtvngzPrpV3 3YPwa+CwXzmchAtAOM19wkhJiNG26tFG4LW74BK7aTBEDFU3tRQ4OWX772x19dyWdX ELh5iGFepNing== X-ME-Helo: [192.168.1.15] X-ME-Auth: ZGFfdmlkQHdhbmFkb28uZnI= X-ME-Date: Tue, 31 Oct 2023 16:28:22 +0100 X-ME-IP: 2.7.71.181 Content-Language: fr, en-US In-Reply-To: <6a6a88f4-dc7c-44a4-9f09-5b3f184df971@orange.fr> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:273565 Archived-At: In fact, I wonder if a better implementation of the `icons--create' method could be to delegate image creation to `find-image'? Something like this: (cl-defmethod icons--create ((_type (eql 'image)) icon keywords) (when-let ((image (find-image `(( :file ,icon ,@(append (if-let ((val (plist-get keywords :height))) (list :height (if (eq val 'line) (window-default-line-height) val))) (if-let ((val (plist-get keywords :width))) (list :width (if (eq val 'font) (default-font-width) val))) '(:scale 1) (if-let ((val (plist-get keywords :rotation))) (list :rotation val)) (if-let ((val (plist-get keywords :margin))) (list :margin val)) (list :ascent (or (plist-get keywords :ascent) 'center)))))))) (propertize " " 'display image)))