From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#60096: 29.0.60; Crash in format_mode_line_unwind_data Date: Sat, 17 Dec 2022 18:05:58 +0100 Message-ID: <89b63947-5b2d-8bd1-4e9a-7da6cf114ffe@gmx.at> References: <86a63oen2m.fsf@mail.linkov.net> <83sfhgjqd7.fsf@gnu.org> <86cz8jls87.fsf@mail.linkov.net> <83k02rk1vk.fsf@gnu.org> <83ilibjttu.fsf@gnu.org> <83fsdfjsq9.fsf@gnu.org> <325aaa94-74fa-cf94-b66c-b87c69ebe386@gmx.at> <838rj6ic34.fsf@gnu.org> <83pmciggwn.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20869"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60096@debbugs.gnu.org, juri@linkov.net To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 17 18:07:13 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p6aeW-0005Hy-O6 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 17 Dec 2022 18:07:12 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p6aeO-0005Gr-Ly; Sat, 17 Dec 2022 12:07:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p6aeM-0005GS-Lg for bug-gnu-emacs@gnu.org; Sat, 17 Dec 2022 12:07:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p6aeM-0006tP-Dx for bug-gnu-emacs@gnu.org; Sat, 17 Dec 2022 12:07:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p6aeL-0005QZ-Sw for bug-gnu-emacs@gnu.org; Sat, 17 Dec 2022 12:07:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Dec 2022 17:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60096 X-GNU-PR-Package: emacs Original-Received: via spool by 60096-submit@debbugs.gnu.org id=B60096.167129677120845 (code B ref 60096); Sat, 17 Dec 2022 17:07:01 +0000 Original-Received: (at 60096) by debbugs.gnu.org; 17 Dec 2022 17:06:11 +0000 Original-Received: from localhost ([127.0.0.1]:56933 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6adX-0005Q9-9t for submit@debbugs.gnu.org; Sat, 17 Dec 2022 12:06:11 -0500 Original-Received: from mout.gmx.net ([212.227.15.18]:36755) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6adS-0005Pl-Da for 60096@debbugs.gnu.org; Sat, 17 Dec 2022 12:06:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.at; s=s31663417; t=1671296759; bh=SVqvj78ZGSXYXrYJNqQ/p6h6FVcTXM5G60PN/LDgcww=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=L44PrlnrHjQb9EGIoZdBjDioEInrUjMIbtJo2/l5O7skpAAD/8xjWMAB4KKuGMhwF r3G/SYr4iQuOjQEaQKuX2tfxOygopabpWmatEYG3hxFhHzC3BxUqbJIwF+c/wqRUde STXFgQF4ihRLR4HD59fnscK4WxS68DbhvpzHx0r1pTKSzErq0ge47BlSUHPvot6qTp xwwmyBnBUE+nRws94OHQ601qOBIe5oDSMwLLsCpxx4X3nLeY61na/0Fe6eJcQU7XiF NhOqcwzm/Ed71CZ6iSAsv1SBDcAhEQ0iuw73MvhHNIyscHP1gBr5/vEruQGT6u7jjd /fYiesf7YFctQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from [192.168.1.102] ([212.95.5.50]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1Mw9Q6-1ongCh2KV2-00s3EQ; Sat, 17 Dec 2022 18:05:59 +0100 Content-Language: en-US In-Reply-To: <83pmciggwn.fsf@gnu.org> X-Provags-ID: V03:K1:UVgMkNDbuIZrI4BYKrbz+BGmYZuSUHCxM2pgUnpQ8ruBGJC8muw 5g1tod1MlahnV3//qSQdIcEU7QfdDAddLpgCBQAHRA20qVstp+w/cgFMo+J2B/cDFljpCce JBM/5KBMggUnzjto3t0ikZHeqaJYa8UyJ61FKAVeH0dY0FimEsfubMA+v8oraeTDFXan/eQ l3CtCJ9HDN4QvVfpCuwGA== UI-OutboundReport: notjunk:1;M01:P0:/MaH+kKmJrE=;cYJFvKvU6mc1BuhnZrGxRMDA5XA uBCVLOyvY3dPerYhgyKHV3fOlbYucunng+8NTLL/W2t3pnhrKK7qvV49X4f1kkIJL4heD8iOD 2ZqhzRTnTbw5/rf/+kw3KL+ueM9XzRnQElYCA40czV3v7g1DvS8utnA3hEUEfrclaD0SUIR43 waTxCO0wK0GoPMP7qm/R69UUpXKHAnMQViWwEKLe9ZB6hFEdaez2hGbNZebRZMz1GDtamK64N holktzchGiq90YRITdt7bjIrdXYk56ep4qjx4UUQqLmSgD6E/jt4IVaFOHUsAeEe3Dp4PVIjI YkuDvraxyTlCvv/4pe1KYAzgk/ad/0dP+hdpHekxIw76uiZeoObqLmTF9wFqhlTGoGs2McZwu uoL7wYq2SCnUSAHZr3z3PQwrbl+uVznpBr1GtFIXlKUUPOy5fnZojXVqjuJZ0xb1bXtOAa2le BimmLHLfZffiogCHANwFXDomYyPyMhx0MnzD94QtaBfYyrWrxP8sfxpmHhLhjIv61AZ5frIJc TGBASINOvog4w3yizIBgWxYEZ8BmMYxawUb3qsnwneyfuwBSGPUHJ5gFNzSHXZfsAw0/nMol4 8Y9vugxKwdtI3J8aPPSYOqT0F9TPcJC781sKyk36Xyy8qqpKaUiV5l+5oi9cbjKPmgeZOne1D mzi5Vp1EhDOec2orBU0D3n5WGmp5gb+JE3TydVx5AlPy9cPV4Al8agMP9wZP8TWisuGafm9Hb Szzo28RWfAlFpt762ZpLSnaFsDLcDpuxpOoN6gtIZx+IzZOP1dIG040eYrWJ9eRVMLYcfs7o X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:251291 Archived-At: >> Alternatively, we could exclude windows with a nil buffer in >> add_window_to_list (think of the case that within the blurb >> producing code someone wants to consult the window list). > > Maybe we should try this on master. I indeed expected > add_window_to_list to filter such invalid windows and was surprised > that it didn't. Basically, I don't understand how we never had such > windows in the list before, since there's no code which actively > removes them and thus protects the list from holding such windows. I > think we just have been lucky. Probably so far we never tried to call 'kill-buffer' from within 'set-window-configuration'. If the only "live" window shows *scratch*, *scratch* gets killed and we kill a temporary buffer before we were able to recreate *scratch*, window_list will return the empty list. >> Principally, we should never run 'replace-buffer-in-windows' from within >> 'set-window-configuration'. > > This can no longer be guaranteed, given that other_buffer_safely calls > into Lisp, and so do a few other primitives. What if such a call into Lisp tries to run 'set-window-configuration'? > You are right in principle, but other_buffer_safely was doing the > above for many years before we acquired get-scratch-buffer-create and > started calling it from here. So I think we are relatively safe > (again, maybe by pure chance). Then not calling 'get-scratch-buffer-create' from other_window_safely would be more safe. martin