From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#63829: 29.0.90; project-find-file's future history breaks with common-parent-directory Date: Mon, 21 Aug 2023 04:15:56 +0300 Message-ID: <8991f72e-80ec-f653-38f6-dc90d316e9c0@gutov.dev> References: <16b64d95-35e9-ef94-2c54-17b670111f0f@gutov.dev> <86h6rnw7gm.fsf@mail.linkov.net> <3e404df1-b3a9-f9e3-4270-f42df8b704c7@gutov.dev> <87a5uti6mo.fsf@catern.com> <73a695f3-7c6a-0e50-41dd-61f8269f6ecf@gutov.dev> <875y5fitiq.fsf@catern.com> <86ttstlsf4.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21816"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Cc: sbaugh@catern.com, 63829@debbugs.gnu.org To: Juri Linkov , Spencer Baugh Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Aug 21 03:17:22 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qXtXk-0005Rp-RU for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 21 Aug 2023 03:17:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qXtXT-0000kK-79; Sun, 20 Aug 2023 21:17:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qXtXR-0000k9-By for bug-gnu-emacs@gnu.org; Sun, 20 Aug 2023 21:17:01 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qXtXR-00089z-4H for bug-gnu-emacs@gnu.org; Sun, 20 Aug 2023 21:17:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qXtXS-0007yS-8m for bug-gnu-emacs@gnu.org; Sun, 20 Aug 2023 21:17:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 21 Aug 2023 01:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63829 X-GNU-PR-Package: emacs Original-Received: via spool by 63829-submit@debbugs.gnu.org id=B63829.169258057530591 (code B ref 63829); Mon, 21 Aug 2023 01:17:02 +0000 Original-Received: (at 63829) by debbugs.gnu.org; 21 Aug 2023 01:16:15 +0000 Original-Received: from localhost ([127.0.0.1]:55088 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXtWh-0007xL-8p for submit@debbugs.gnu.org; Sun, 20 Aug 2023 21:16:15 -0400 Original-Received: from wout5-smtp.messagingengine.com ([64.147.123.21]:42769) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXtWc-0007wv-DW for 63829@debbugs.gnu.org; Sun, 20 Aug 2023 21:16:14 -0400 Original-Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 59E0B320083A; Sun, 20 Aug 2023 21:16:01 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sun, 20 Aug 2023 21:16:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1692580560; x=1692666960; bh=u8UIkzeG0MblDleKmF9wC55/HVSyXSuzrXh ZztIngtM=; b=X8ivzjypCFIQHenx1fabFq02B0eHW5pml1IR93sBkZZWxQYxYXI E1xt6QMdPXaSML4YnxPsCZ1eeCbYmzZPfFeF+AA0fO6pcNYk3whzo7GG+NkGkoRh x59zPWb9tgGBPAd39WJz6JklBo4pSsGcSZL42zvwdOIma2GmWqL0Rip4NufQcxVh J1sBlLbOYVgHur0gmtpDRPCT8+AnUXDqgz8gZI3q3Ii70JaXrNv7Cz4Yqb4RwD0P WFEsuandvw6Ii/oET5RFBsheFIBUI/ZRGLJbrO474Zas0d9YbSuyGNXp+ZEp3vDH ffw8qaRnnZicJDh07sd2XgODL8fzh2tvZ0A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1692580560; x=1692666960; bh=u8UIkzeG0MblDleKmF9wC55/HVSyXSuzrXh ZztIngtM=; b=CNRrT7hgnXKcJX/yRXPaxiSTW5cfl6Qgqx/gIY98IrhuoAv7YhT S0uyq/G4YCtumIiXtDnMOynWOrsApJbD8JPPteh4SbkvukBVj2ydiB3J6hxYm4ly Gu6c8wh3FerJajAg/+vS8pwXYEGiDaRebXeoF8QFYiCEHYP9HtpexGrkBJFaURK/ P2owwGtG+z5/9UBf2h7mFGKa8GKqiUmD5qqETWbEjJTuhVz8AjbSqJGLSwM+N6S+ 3eEuSWeg8JF7TQoVenzaIrl9MyQaZ2K0TIcK+p+TRrGE+EztP5cYh+DsgSYxZjQv 3Qg96P7J4zhBiNqrcZDqPT/TKQlkkxG6xcw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedruddukedggeehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhepiefgteevheevveffheeltdeukeeiieekueefgedugfefgefhudelgfefveel vdevnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 20 Aug 2023 21:15:59 -0400 (EDT) Content-Language: en-US In-Reply-To: <86ttstlsf4.fsf@mail.linkov.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:268049 Archived-At: On 20/08/2023 20:16, Juri Linkov wrote: >> + (if-let (filename-proj (and project-current-directory-override >> + (project-current nil default-directory))) >> + ;; file-name-concat requires Emacs 28+ >> + (concat (file-name-as-directory (project-root project)) >> + (file-relative-name filename (project-root filename-proj))) >> + filename)) > > I wonder why you prepend (file-name-as-directory (project-root project))? > This is unnecessary because the project root is already displayed > in the prompt, so only a relative file name is sufficient in the minibuffer: > > Find file in /project/root/: relative/file.name The absolute name is required down in the callee because that distinguishes it from a file name fragment picked up by things-at-point.