From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#14926: 24.3.50; Warning "`make-variable-buffer-local' should be called at toplevel" Date: Sun, 21 Jul 2013 21:31:26 -0700 (PDT) Message-ID: <893be673-2c77-4803-8c09-dbaf87521c54@default> References: <2aaa3bfa-1556-4135-b70a-1308e6cc7cdd@default> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1374467539 10219 80.91.229.3 (22 Jul 2013 04:32:19 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 22 Jul 2013 04:32:19 +0000 (UTC) Cc: 14926@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jul 22 06:32:17 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1V17n6-0002LV-K2 for geb-bug-gnu-emacs@m.gmane.org; Mon, 22 Jul 2013 06:32:08 +0200 Original-Received: from localhost ([::1]:41913 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V17n6-0006g0-0O for geb-bug-gnu-emacs@m.gmane.org; Mon, 22 Jul 2013 00:32:08 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49064) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V17n2-0006fi-JF for bug-gnu-emacs@gnu.org; Mon, 22 Jul 2013 00:32:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V17n1-0006xe-6D for bug-gnu-emacs@gnu.org; Mon, 22 Jul 2013 00:32:04 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:47450) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V17n1-0006xa-3b for bug-gnu-emacs@gnu.org; Mon, 22 Jul 2013 00:32:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1V17n0-0003nh-Qb for bug-gnu-emacs@gnu.org; Mon, 22 Jul 2013 00:32:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 22 Jul 2013 04:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14926 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 14926-submit@debbugs.gnu.org id=B14926.137446749714537 (code B ref 14926); Mon, 22 Jul 2013 04:32:02 +0000 Original-Received: (at 14926) by debbugs.gnu.org; 22 Jul 2013 04:31:37 +0000 Original-Received: from localhost ([127.0.0.1]:41766 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V17ma-0003mM-DJ for submit@debbugs.gnu.org; Mon, 22 Jul 2013 00:31:36 -0400 Original-Received: from aserp1040.oracle.com ([141.146.126.69]:31832) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V17mW-0003lW-TJ for 14926@debbugs.gnu.org; Mon, 22 Jul 2013 00:31:33 -0400 Original-Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237]) by aserp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id r6M4VPtQ005569 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 22 Jul 2013 04:31:26 GMT Original-Received: from aserz7022.oracle.com (aserz7022.oracle.com [141.146.126.231]) by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r6M4VP51008198 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 22 Jul 2013 04:31:25 GMT Original-Received: from abhmt114.oracle.com (abhmt114.oracle.com [141.146.116.66]) by aserz7022.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r6M4VOSF002716; Mon, 22 Jul 2013 04:31:24 GMT In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.7 (607090) [OL 12.0.6668.5000 (x86)] X-Source-IP: acsinet21.oracle.com [141.146.126.237] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:76558 Archived-At: > > 2. What is wrong with code such as this at top level? >=20 > Nothing. But most of the cases I bumped into (all of which have > been fixed now, AFAIK) I guess you mean problems in the distributed code (?). > were cases where the author had confused make-local-variable > and make-variable-buffer-local. Fair enough. That is worth trying to help users with. And it has long been something needing reminding. For things like that, I don't tend to favor compiler warnings. I tend to favor improving the doc or adding a wiki page or a tutorial video or... Anyway, is the current approach (warning about anything not at top level) the best way? I think it confuses more than it helps. I understand that it is well-intentioned. But I don't think the resulting noise and confusion are worth it. If the lesson is not clear and accurate then the course isn't worth taking or giving. Can you characterize better the case where we want people to use (or not to use) `make-variable-buffer-local'? IOW, just saying you should use this at top level is too gross (and not correct). Can you improve the spec a bit and then the implementation so the warning appears only when it should (or almost only then)?