From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#42272: 27.0.91; [PATCH] Fix doc-view rescale Date: Fri, 14 Aug 2020 11:02:58 -0400 Message-ID: <89267A16-E930-479E-B4FA-4CFE61CE9FEC@psu.edu> References: <222D27A6-231C-4B9C-9577-E28F75A80869@psu.edu> <87imdxjfcw.fsf@gnus.org> <16D7DB04-C504-4E23-9BC0-C79B71C58433@psu.edu> <87r1sj6idm.fsf@gnus.org> <874kp5a1fk.fsf@gnus.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="Apple-Mail=_A6B22A99-A705-4F3A-9B1A-9E1DDFAD3CF2" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15124"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "42272@debbugs.gnu.org" <42272@debbugs.gnu.org> To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 14 17:04:19 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k6bFi-0003nz-TX for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 14 Aug 2020 17:04:19 +0200 Original-Received: from localhost ([::1]:35812 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k6bFh-0000q1-Sf for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 14 Aug 2020 11:04:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45848) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k6bFS-0000nf-F5 for bug-gnu-emacs@gnu.org; Fri, 14 Aug 2020 11:04:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41997) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k6bFS-0004iY-4y for bug-gnu-emacs@gnu.org; Fri, 14 Aug 2020 11:04:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k6bFS-0006Ko-0T for bug-gnu-emacs@gnu.org; Fri, 14 Aug 2020 11:04:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 14 Aug 2020 15:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42272 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 42272-submit@debbugs.gnu.org id=B42272.159741739224291 (code B ref 42272); Fri, 14 Aug 2020 15:04:01 +0000 Original-Received: (at 42272) by debbugs.gnu.org; 14 Aug 2020 15:03:12 +0000 Original-Received: from localhost ([127.0.0.1]:53543 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6bEd-0006Jj-QQ for submit@debbugs.gnu.org; Fri, 14 Aug 2020 11:03:11 -0400 Original-Received: from mail-bn8nam12on2137.outbound.protection.outlook.com ([40.107.237.137]:41025 helo=NAM12-BN8-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6bEa-0006JV-W6 for 42272@debbugs.gnu.org; Fri, 14 Aug 2020 11:03:10 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NIYwgg6oNLAtbGDOUxXk3Sn1TtT4DMFKgCswWLB3A1L4yyKwXc3Ez7LmxcaKcCIuUAuH/WPp0qkGCkMehCk6fKN1R/57do3EVK2ZPXHPJUUsdydJHs8VAGVlmJOvyT4niQeqR1QWgiN0mIbD5LCnDTMfJyliJLyj/0sgoQVeBCmPXc9jvyVFI+VU7XKwS/1MET61pcRCtzEOo59Bp9zka3mgUDuxnPNnpcepQLjfCOLniVLM4ClpKtC5nQZo39+m0pP7T9zrqAmEvpAJOLNq8C4pz9fPA1Os/dlQIQ0ux02WyY5KIIxJBrbgAlwy9wCxAoLZMOi7nMM5qgAg4Ch/Yw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cGrrgP4miZd4NErYqPyF+6ohBjing/sbDNOMZnveDfM=; b=cURTxu0JjA31suhyYPntupHuitdMJQvAb0qb6nt4ZkPMXo3BpYo7NuA4hlmA8YdNBe7GIAHUJc9z8O04OAIijHL7j2lD+nYAdq492TX/jfDpaGcPOHWvkPxvQKt7Doyo1ORmqhK8e5GhNgGZOVx7dA0NQ9DUV1UKaowOhBZZHrjBrYTihZfHlJfziGT8E2pdRRFjo9bznCRfcnhYzQqtc/nN1AM5FMC6YWSofAtwbjIS7+gWNlCDquaCPdA7KHnCTKXy8MP6Piu/CcxwTXgP1sNwxXAR0iXblN/JTTmnIXugSZZNJAZ/Ndy4jV+G1D61FDflvDPrdzixBrNceRgAwQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=psu.edu; dmarc=pass action=none header.from=psu.edu; dkim=pass header.d=psu.edu; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=PennStateOffice365.onmicrosoft.com; s=selector2-PennStateOffice365-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cGrrgP4miZd4NErYqPyF+6ohBjing/sbDNOMZnveDfM=; b=0kIsimryVmIfOGzIAfO9u4mORHRXgRDz+mrY9ebus+kaGxf9h1YYli6VAeBqDwiR/Zb5mOS9WJfovce6ZgfLthzWj2+OT9DaIBwC8nTpBN98+BgO5Dpkw5QQ7DoCjBUwk3VnP7F/ew+LBRAo14L9TgBo7OBW4DkciCnISviLTa8= Authentication-Results: gnus.org; dkim=none (message not signed) header.d=none;gnus.org; dmarc=none action=none header.from=psu.edu; Original-Received: from CY4PR02MB3192.namprd02.prod.outlook.com (2603:10b6:910:7f::12) by CY4PR02MB2616.namprd02.prod.outlook.com (2603:10b6:903:70::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3283.16; Fri, 14 Aug 2020 15:03:02 +0000 Original-Received: from CY4PR02MB3192.namprd02.prod.outlook.com ([fe80::fd6e:d716:3dd3:380]) by CY4PR02MB3192.namprd02.prod.outlook.com ([fe80::fd6e:d716:3dd3:380%5]) with mapi id 15.20.3283.022; Fri, 14 Aug 2020 15:03:01 +0000 In-Reply-To: <874kp5a1fk.fsf@gnus.org> X-Mailer: Apple Mail (2.3608.120.23.2.1) X-ClientProxiedBy: BL0PR05CA0001.namprd05.prod.outlook.com (2603:10b6:208:91::11) To CY4PR02MB3192.namprd02.prod.outlook.com (2603:10b6:910:7f::12) X-MS-Exchange-MessageSentRepresentingType: 1 Original-Received: from [IPv6:2601:98a:4200:9210:943e:209:8c5:4e98] (2601:98a:4200:9210:943e:209:8c5:4e98) by BL0PR05CA0001.namprd05.prod.outlook.com (2603:10b6:208:91::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3305.10 via Frontend Transport; Fri, 14 Aug 2020 15:03:01 +0000 X-Mailer: Apple Mail (2.3608.120.23.2.1) X-Originating-IP: [2601:98a:4200:9210:943e:209:8c5:4e98] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 508bc900-b8d7-4406-1f56-08d840632372 X-MS-TrafficTypeDiagnostic: CY4PR02MB2616: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7219; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY4PR02MB3192.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(396003)(39860400002)(346002)(366004)(376002)(186003)(316002)(4326008)(235185007)(16526019)(66946007)(66556008)(66476007)(66616009)(8676002)(33656002)(5660300002)(53546011)(786003)(52116002)(6916009)(2906002)(6486002)(75432002)(8936002)(478600001)(2616005)(86362001)(564344004)(36756003)(6666004); DIR:OUT; SFP:1102; X-OriginatorOrg: psu.edu X-MS-Exchange-CrossTenant-Network-Message-Id: 508bc900-b8d7-4406-1f56-08d840632372 X-MS-Exchange-CrossTenant-AuthSource: CY4PR02MB3192.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Aug 2020 15:03:01.6695 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7cf48d45-3ddb-4389-a9c1-c115526eb52e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hfcJ5AMKHLJb8hFO4oqztMbzoDvzwiHEZ64nBYXQhcxoPqBgUtrZ1TmHwLf7jaYl X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR02MB2616 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:185132 Archived-At: --Apple-Mail=_A6B22A99-A705-4F3A-9B1A-9E1DDFAD3CF2 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii > On Aug 14, 2020, at 7:53 AM, Lars Ingebrigtsen wrote: > > "Fu, Yuan" writes: > >> Here is the fix patch: > > Thanks; applied to Emacs 28. Cool! Here is the centering patch. Yuan --Apple-Mail=_A6B22A99-A705-4F3A-9B1A-9E1DDFAD3CF2 Content-Disposition: attachment; filename=doc-view-center.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="doc-view-center.patch" Content-Transfer-Encoding: quoted-printable >From 216f20f3628900c5dc4ea98a14f38b326a71c480 Mon Sep 17 00:00:00 2001=0A= From: Yuan Fu =0A= Date: Thu, 13 Aug 2020 15:57:47 -0400=0A= Subject: [PATCH] Add centering commands to doc-view.el=0A= =0A= * lisp/doc-view.el (doc-view-mode-map): Add binding for centering=0A= commands.=0A= (doc-view-center-page-horizontally, doc-view-center-page-vertically):=0A= New functions.=0A= ---=0A= lisp/doc-view.el | 29 +++++++++++++++++++++++++++++=0A= 1 file changed, 29 insertions(+)=0A= =0A= diff --git a/lisp/doc-view.el b/lisp/doc-view.el=0A= index 3e2b244326..77c06a8eaf 100644=0A= --- a/lisp/doc-view.el=0A= +++ b/lisp/doc-view.el=0A= @@ -435,6 +435,9 @@ doc-view-mode-map=0A= (define-key map (kbd "c m") 'doc-view-set-slice-using-mouse)=0A= (define-key map (kbd "c b") 'doc-view-set-slice-from-bounding-bo= x)=0A= (define-key map (kbd "c r") 'doc-view-reset-slice)=0A= + ;; Centering the image=0A= + (define-key map (kbd "c h") 'doc-view-center-page-horizontally)= =0A= + (define-key map (kbd "c v") 'doc-view-center-page-vertically)=0A= ;; Searching=0A= (define-key map (kbd "C-s") 'doc-view-search)=0A= (define-key map (kbd "") 'doc-view-search)=0A= @@ -921,6 +924,32 @@ doc-view-fit-window-to-page=0A= (when new-frame-params=0A= (modify-frame-parameters (selected-frame) new-frame-params))))=0A= =0A= +(defun doc-view-center-page-horizontally ()=0A= + "Center page horizontally when page is wider than window."=0A= + (interactive)=0A= + (let ((page-width (car (image-size (doc-view-current-image) 'pixel)))=0A= + (window-width (window-body-width nil 'pixel))=0A= + ;; How much do we scroll in order to center the page?=0A= + (pixel-hscroll 0)=0A= + ;; How many pixels are there in a column?=0A= + (col-in-pixel (/ (window-body-width nil 'pixel)=0A= + (window-body-width nil))))=0A= + (when (> page-width window-width)=0A= + (setq pixel-hscroll (/ (- page-width window-width) 2))=0A= + (set-window-hscroll (selected-window)=0A= + (/ pixel-hscroll col-in-pixel)))))=0A= +=0A= +(defun doc-view-center-page-vertically ()=0A= + "Center page vertically when page is wider than window."=0A= + (interactive)=0A= + (let ((page-height (cdr (image-size (doc-view-current-image) 'pixel)))= =0A= + (window-height (window-body-height nil 'pixel))=0A= + ;; How much do we scroll in order to center the page?=0A= + (pixel-scroll 0))=0A= + (when (> page-height window-height)=0A= + (setq pixel-scroll (/ (- page-height window-height) 2))=0A= + (set-window-vscroll (selected-window) pixel-scroll 'pixel))))=0A= +=0A= (defun doc-view-reconvert-doc ()=0A= "Reconvert the current document.=0A= Should be invoked when the cached images aren't up-to-date."=0A= -- =0A= 2.27.0=0A= =0A= --Apple-Mail=_A6B22A99-A705-4F3A-9B1A-9E1DDFAD3CF2--