From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.bugs Subject: bug#51993: 29.0.50; [PATCH] Killing emacsclient terminal with `server-stop-automatically' doesn't prompt to save files Date: Tue, 23 Nov 2021 20:37:04 +0000 Message-ID: <890d44ded2fa8ff77ab2@heytings.org> References: <9e47c871-a2c3-d764-bec9-d87abf3efe83@gmail.com> <83pmqvti49.fsf@gnu.org> <890d44ded2b56811ceff@heytings.org> <64c7eb70-d941-9c98-4513-a2bdc44e7953@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29500"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 51993@debbugs.gnu.org, larsi@gnus.org To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 23 21:38:10 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mpcYL-0007W3-EO for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 23 Nov 2021 21:38:09 +0100 Original-Received: from localhost ([::1]:52088 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mpcYK-0003p8-HD for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 23 Nov 2021 15:38:08 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:35372) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mpcYE-0003ou-ND for bug-gnu-emacs@gnu.org; Tue, 23 Nov 2021 15:38:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40798) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mpcYE-0003Sh-Es for bug-gnu-emacs@gnu.org; Tue, 23 Nov 2021 15:38:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mpcYE-0005CS-7l for bug-gnu-emacs@gnu.org; Tue, 23 Nov 2021 15:38:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 23 Nov 2021 20:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51993 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51993-submit@debbugs.gnu.org id=B51993.163769983019913 (code B ref 51993); Tue, 23 Nov 2021 20:38:02 +0000 Original-Received: (at 51993) by debbugs.gnu.org; 23 Nov 2021 20:37:10 +0000 Original-Received: from localhost ([127.0.0.1]:52344 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mpcXO-0005B6-9F for submit@debbugs.gnu.org; Tue, 23 Nov 2021 15:37:10 -0500 Original-Received: from heytings.org ([95.142.160.155]:46418) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mpcXK-0005Aw-PF for 51993@debbugs.gnu.org; Tue, 23 Nov 2021 15:37:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20210101; t=1637699825; bh=aYShTjc2Ra1ChBBptYGsIIBDNnODmTfB0X4HfrLVZ8E=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=LDjq6nelwfMiKR5IXdMBeJIl7gVz5mAmxVXXaI4jtfPt6Acaw5A+xDaIhJYPta9GN 73Df0X8mK7t8SE2Z6xYRbjBlzmDw0Ls1ar125EO1ogdr3qOnebVVrMTuoQF1MT3gNB CA94QHAKsrVEcTQq6nPrukmZVLj0HR5xz+UNZLaKPjPTpcMyOzKqjJ4iV2Vhedc5l+ AuW/eQg9l3X6Ax31B54qvOdXoKLQ0Euu3ANRx3pVR/3SL5RlukaknT1f3ZA0HSTU9/ s0TNCnhszdxwHnBREIaL4aakaSuEVGGlSAHeJy1ExRfXdxPwV9m/0KjlG75hVdtyno oby+tuZL78ijw== In-Reply-To: <64c7eb70-d941-9c98-4513-a2bdc44e7953@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:220689 Archived-At: >> This is not a bug, this is the intented behavior of that feature > > I started that discussion (and participated throughout it), and I don't > think we actually agreed that this was the intended behavior. > This is the behavior I intended (and described in the docstring and manual), if you prefer. And you did not make further comments in bug#51377, which can be interpreted as a kind of agreement. > > I should stress that the case I brought up above is just a > counterexample to show a problem with a previous implementation strategy > Which problem? > > The current behavior on Emacs 29 certainly isn't what I personally > intended when bringing the idea up on emacs-devel. > Is the current behavior of Emacs 29 with my patch and (server-stop-automatically 'kill-terminal) still not what you want? If not, what is missing? > > I'm concerned that we're now up to 4 different behaviors, when I think > two of them are just the result of a miscommunication between the two of > us. > They are not, AFAICS. The four behaviors are four reasonable options, each of which can (and is) described in a short paragraph, and corresponds to a different user preference. I see no reason to remove any of the current three behaviors because of an unspecified "problem". Especially given that all these behaviors are implemented in only ~50 lines of Lisp.