From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#54603: 29.0.50; [PATCH] Eshell's external pipe module interferes with other argument parsing hooks Date: Thu, 31 Mar 2022 09:26:28 -0700 Message-ID: <88e92487-f116-6d4f-e075-9cfb8f8edef6@gmail.com> References: <70677cd2-f741-16d1-b38f-c39b507cc95e@gmail.com> <87ilru73b2.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40919"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 54603@debbugs.gnu.org, John Wiegley , Sean Whitton To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Mar 31 18:27:12 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZxdf-000AVQ-Cn for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 31 Mar 2022 18:27:11 +0200 Original-Received: from localhost ([::1]:39968 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nZxde-0002a1-BL for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 31 Mar 2022 12:27:10 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:46000) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nZxdW-0002Vi-3h for bug-gnu-emacs@gnu.org; Thu, 31 Mar 2022 12:27:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45725) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nZxdV-0003u3-R7 for bug-gnu-emacs@gnu.org; Thu, 31 Mar 2022 12:27:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nZxdV-0002dT-Hc for bug-gnu-emacs@gnu.org; Thu, 31 Mar 2022 12:27:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 31 Mar 2022 16:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54603 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 54603-submit@debbugs.gnu.org id=B54603.164874399510092 (code B ref 54603); Thu, 31 Mar 2022 16:27:01 +0000 Original-Received: (at 54603) by debbugs.gnu.org; 31 Mar 2022 16:26:35 +0000 Original-Received: from localhost ([127.0.0.1]:39622 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nZxd4-0002cg-MY for submit@debbugs.gnu.org; Thu, 31 Mar 2022 12:26:34 -0400 Original-Received: from mail-pj1-f51.google.com ([209.85.216.51]:36691) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nZxd3-0002cU-Rt for 54603@debbugs.gnu.org; Thu, 31 Mar 2022 12:26:34 -0400 Original-Received: by mail-pj1-f51.google.com with SMTP id p4-20020a17090ad30400b001c7ca87c05bso2835337pju.1 for <54603@debbugs.gnu.org>; Thu, 31 Mar 2022 09:26:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=WejVH0VOuDzxf5zXZLzQ/uZCv1NTfU7ufwkUuPeQ6ms=; b=PPnZvSFxYQyWkovgIZW1j/VylNdE1rTA4Ey4D4ZuF8C3EMggRRX2tl0t0vh2UIBb/e xi87ebIXLi0XU/ajF0o0LMDbS009ut+nYF19wK3DScTpPkkAw/HQzCG7Dofce9WzqU3H p1daMCXrc+NuAw3jainVDqJ313m3v14pf2cAui+d/vhZlGcXC2xX89mHvqI4FwIVql13 52swCIWwjaF/YI2jQccFTZektXNdrYrb8DW+MHKycUTqrjtrDTDFhJUu+XysJ06dzVNz uynuX8ddF6NvBHaVij/Y/n/NUcn9pkK3j3Rlz0gWB0N+TtWmGJ0jjwpSYG2HDoV3RhqP YP1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=WejVH0VOuDzxf5zXZLzQ/uZCv1NTfU7ufwkUuPeQ6ms=; b=2A41SQlvvykzr7RUya0iOJAc4S7asYvkSVfjRZhoFwFA7Ow6VuH/anh+Ij29SD/3Jo N9ReijUTUBGKDdQn8A8rIPxX8wqvwSacjprxPiM+IXCOS1KXuXT84zJ4zQeiPbTsJUy1 SRAIVifnJe+mXDmNVdychajq3xXbDNjWpZv4XKZJKZInzW+ooMr7sdL5rdZwNJo6zbWw Irud+reCK6Xy+QLPrK2CXxZwutjLvUU36y/v1mMYUDagw855eM554SFza3B792ABGS/S 37O+KN7xMgRwi1fUuq9p6+ZtT9BZNE2kuFqwIk2egT0uA39+ANN3zTb4qBwAn6mPbfYl bAJg== X-Gm-Message-State: AOAM532oTMX1TJQ1EHsLFPuF3wGFDeRzl9yuRRFZOeCEsneWIHkf1UuG UEJrGadxIsdd7gTBWYceUT4= X-Google-Smtp-Source: ABdhPJxBwCyGqhZV8icJ0WOALWhuyWMZnV7Q/GLUDGjkT5lsGL6ejATa/Wrl/W47SW+390bDF3SKvg== X-Received: by 2002:a17:902:ac88:b0:153:a34f:5648 with SMTP id h8-20020a170902ac8800b00153a34f5648mr6221567plr.121.1648743987851; Thu, 31 Mar 2022 09:26:27 -0700 (PDT) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id x7-20020a056a00188700b004fae6f0d3e5sm29803351pfh.175.2022.03.31.09.26.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 31 Mar 2022 09:26:27 -0700 (PDT) In-Reply-To: <87ilru73b2.fsf@gnus.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:229167 Archived-At: On 3/31/2022 4:46 AM, Lars Ingebrigtsen wrote: > Jim Porter writes: > >> The attached patch resolves the issue for me, but I'm not sure if it's >> the best strategy. If possible, I think it would be better for >> `eshell-parse-external-pipeline' to solely focus on finding the >> external pipe operators ("*|", "*<", and "*>")[1] and then for >> `eshell-rewrite-external-pipeline' to prepare the command string to >> pass to sh. This would also have the advantage[2] of making it >> possible to support a richer set of Eshell features with external >> pipes, such as the following: > > I think that sounds like a good idea (but I don't use eshell regularly, > so I don't really have much of an opinion here). Perhaps John does; > added to the CCs. CCing Sean as well, who implemented the extpipe module. (I probably should have done that in the initial report, but I'm not sure the right way to CC people when I'm mailing bug-gnu-emacs@; if the CCed person replies normally, wouldn't it make a new bug number? I'm sure this is in the debbugs documentation though, so I should sit down and read it sometime.)