From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#37659: rx additions: anychar, unmatchable, unordered-or Date: Tue, 22 Oct 2019 17:14:08 +0200 Message-ID: <88571301-3F15-428F-82F9-60A23D817EF8@acm.org> References: Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="188783"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 37659@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 22 17:15:13 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iMvsO-000n0a-M8 for geb-bug-gnu-emacs@m.gmane.org; Tue, 22 Oct 2019 17:15:12 +0200 Original-Received: from localhost ([::1]:60854 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iMvsN-00048o-Iu for geb-bug-gnu-emacs@m.gmane.org; Tue, 22 Oct 2019 11:15:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55103) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iMvsG-00048P-3B for bug-gnu-emacs@gnu.org; Tue, 22 Oct 2019 11:15:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iMvsF-0006o9-2L for bug-gnu-emacs@gnu.org; Tue, 22 Oct 2019 11:15:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51504) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iMvsE-0006nL-PC for bug-gnu-emacs@gnu.org; Tue, 22 Oct 2019 11:15:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iMvsE-00062t-Gk for bug-gnu-emacs@gnu.org; Tue, 22 Oct 2019 11:15:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Oct 2019 15:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37659 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 37659-submit@debbugs.gnu.org id=B37659.157175726623180 (code B ref 37659); Tue, 22 Oct 2019 15:15:02 +0000 Original-Received: (at 37659) by debbugs.gnu.org; 22 Oct 2019 15:14:26 +0000 Original-Received: from localhost ([127.0.0.1]:60325 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iMvre-00061o-HQ for submit@debbugs.gnu.org; Tue, 22 Oct 2019 11:14:26 -0400 Original-Received: from mail158c50.megamailservers.eu ([91.136.10.168]:47612 helo=mail51c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iMvrc-00061f-04 for 37659@debbugs.gnu.org; Tue, 22 Oct 2019 11:14:25 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1571757251; bh=CzHEMjZd+KZ3iR82Lcro7M3SqnKRFAZ1BfwCN46Oqvs=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=qowtTWKfW01Iw71gARP6diLpHLajTmIpMhCr57CK64E1nNQqQBkKUks7VpfmjfUYw 8xWVZKXIZOyDspVdQxS673LOpi18+jLiH5brqhzxBQ6ew8u4TvMF2YtZ4GrDrAHrJB Z+ZIE54Mlqpsh5J3XnORH/7lDIsWUITaiBo40lYE= Feedback-ID: mattiase@acm.or Original-Received: from [192.168.0.4] (c188-150-171-71.bredband.comhem.se [188.150.171.71]) (authenticated bits=0) by mail51c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x9MFE9pf003218; Tue, 22 Oct 2019 15:14:11 +0000 In-Reply-To: X-Mailer: Apple Mail (2.3445.104.11) X-CTCH-RefID: str=0001.0A0B020F.5DAF1CC3.0029, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=LO0Yv6e9 c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=VFZyZ26j0jTyNYFfgNcA:9 a=CjuIK1q_8ugA:10 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:169987 Archived-At: 'regexp-opt' always generates a regexp preferring long matches. This is = undocumented, but useful enough that I would be surprised if this = property wasn't exploited (perhaps unknowingly) by callers. It's quite = natural: given a set of strings, surely the caller want them all to be = candidates for a match, even if there is no following anchoring pattern. Thus, instead of 'unordered-or', define the operator in terms of long = matches: 'or-max' (working name) would work like 'or' but guarantee a = longest match, and only permit strings and 'or-max' forms as arguments. = Thus, the rx user gets all the benefits from 'regexp-opt' in a = composable way, without a need to sort the strings or otherwise prepare = them. (The old 'or' behaviour always used 'regexp-opt' when possible, which = was very fragile: (or "a" "ab") would match "ab", but (or "a" "ab" = digit) would just match "a". 'or-max' is robust, without surprises.) Of course, we should also guarantee the maximum-matching property of = regexp-opt. This is just a matter of documentation (and test); it does = not restrict optimisations as far as I can tell. Again, I'm open to suggestions about a better name than 'or-max'. The other patches (anychar, unmatchable, and [^z-a]) have been pushed to = master.