From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#21112: 25; Patch: show minibuffer messages with a face Date: Thu, 27 Jun 2019 14:19:45 -0700 (PDT) Message-ID: <884006f4-2f66-42c5-9737-4038a72c0d4a@default> References: <55AF90B9.5040401@gmail.com> <87si0jvkgv.fsf@gnus.org> <87pnn11nm5.fsf@mail.linkov.net> <87y31orqm1.fsf@mail.linkov.net> <2cf332e4-b80e-43f1-82e5-7d1610f72362@default> <87y31n9btf.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="60820"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Lars Ingebrigtsen , Raffaele Ricciardi , 21112@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jun 27 23:20:20 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hgboa-000Fil-0e for geb-bug-gnu-emacs@m.gmane.org; Thu, 27 Jun 2019 23:20:20 +0200 Original-Received: from localhost ([::1]:54762 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hgboZ-0008Lf-1U for geb-bug-gnu-emacs@m.gmane.org; Thu, 27 Jun 2019 17:20:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57849) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hgboQ-0008Hp-44 for bug-gnu-emacs@gnu.org; Thu, 27 Jun 2019 17:20:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hgboM-0005aM-7U for bug-gnu-emacs@gnu.org; Thu, 27 Jun 2019 17:20:09 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54604) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hgboI-0005Vj-TT for bug-gnu-emacs@gnu.org; Thu, 27 Jun 2019 17:20:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hgboI-0005g8-JT for bug-gnu-emacs@gnu.org; Thu, 27 Jun 2019 17:20:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 27 Jun 2019 21:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21112 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: wontfix patch Original-Received: via spool by 21112-submit@debbugs.gnu.org id=B21112.156167039721810 (code B ref 21112); Thu, 27 Jun 2019 21:20:02 +0000 Original-Received: (at 21112) by debbugs.gnu.org; 27 Jun 2019 21:19:57 +0000 Original-Received: from localhost ([127.0.0.1]:39915 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hgboD-0005fh-Ad for submit@debbugs.gnu.org; Thu, 27 Jun 2019 17:19:57 -0400 Original-Received: from userp2120.oracle.com ([156.151.31.85]:40846) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hgboA-0005fN-HA for 21112@debbugs.gnu.org; Thu, 27 Jun 2019 17:19:55 -0400 Original-Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x5RL9b17153387; Thu, 27 Jun 2019 21:19:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=zRUF3zQ3atfyoeD7UY/c+T6UfeuLwQpH481m25clUBA=; b=XdJN3kW69vYtqr0jshKvciwQssaXf0j1DKM8XItfOOIyWl8BEw5udSVHRzoQtxKWVtbY Je1B3Jl9DtIdji3MZ6UiUy7iuAPePOtqKgepz2hNSuBdKAJi/Yc9D5gt13UkJXbV5hlg 7x4M4yEqOZF00mBXfBhG9HCrYpheODPwcvm52Z8TacVHNy57A25qd3e88DmXi54PSHB5 VTMetlShueanEqGQMSwtO7GG/Pyc5CunbEKoG73q/ie6zTsJbdx1c9w30P7CFGkaRtpe 0+c4R4b9SHQ+1RFrL46F0kEUS1yhnqd5tuYcABr+0mi3dPasfjxLIV7DKhp3OkIEP8PM eg== Original-Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by userp2120.oracle.com with ESMTP id 2t9cyqtemy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 27 Jun 2019 21:19:48 +0000 Original-Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x5RLJWhJ188226; Thu, 27 Jun 2019 21:19:48 GMT Original-Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userp3020.oracle.com with ESMTP id 2tat7dm05h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 27 Jun 2019 21:19:48 +0000 Original-Received: from abhmp0018.oracle.com (abhmp0018.oracle.com [141.146.116.24]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x5RLJkmJ002326; Thu, 27 Jun 2019 21:19:46 GMT In-Reply-To: <87y31n9btf.fsf@mail.linkov.net> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4861.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9301 signatures=668688 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906270244 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9301 signatures=668688 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906270244 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:161661 Archived-At: > >> I'm not really convinced that there should be any face properties on t= he > >> minibuffer messages at all, though. :-) > > > > Yes, and a caller can always add whatever properties > > it wants/needs. It's not hard to pass a propertized > > string to `minibuffer-message'. >=20 > It makes no sense for a caller of a particular command > to decide whether to highlight the message or not. Why would you decide that for everyone? Can't you imagine that it might make sense for some calling code to do that? Who said "command"? Why shouldn't some code that calls `minibuffer-message' propertize parts of that message any way its author sees fit? The caller can choose the text to display; why shouldn't it be able to choose how to emphasize (or whatever) particular parts of it? > It should be user's preference whether to highlight > all messages from all commands, or none at all. All or nothing, eh? Why so limited? In any case, a user should also be able to choose to use some library or other code that highlights some text displayed by `minibuffer-message' in a way deemed appropriate (by that code and that user). User choices are not limited to user options and faces. A one-size-fits-all outlook is not Emacsy. It "makes no sense" for Emacs design to do that. Emacs typically gives users (including coders) enough rope to hang themselves on - on purpose, because it tries to be flexible and maximize their possibilities. > If the user decided "I don't want caller's highlighting", > a caller should not have the right to override user's preference. If a user decides to use code that does the kind of highlighting s?he wants, s?he should be able to do that. Customize is not the only knob users have, to express choices. Among the most common ways to express choice are choosing to turn on particular modes and load particular libraries. > So we should not allow a caller to overwrite the default > face properties, and I retract that part of my previous patch. Whatever. Many users are also code writers. Most code writers are also users. Give users the ability to adapt and adopt whatever they want to, however they want to.