From: Dmitry Gutov <dgutov@yandex.ru>
To: Alan Mackenzie <acm@muc.de>
Cc: John Wiegley <jwiegley@gmail.com>,
Philipp Stephani <p.stephani2@gmail.com>,
22983@debbugs.gnu.org
Subject: bug#22983: [ Patch ] Re: bug#22983: syntax-ppss returns wrong result.
Date: Fri, 22 Sep 2017 17:09:03 +0300 [thread overview]
Message-ID: <8819156d-b58f-f87f-14b1-5e347202c752@yandex.ru> (raw)
In-Reply-To: <20170919204753.GD19168@ACM>
Hi Alan,
On 9/19/17 11:47 PM, Alan Mackenzie wrote:
> I have done now, without the slightest cause for concern (see below).
Thank you. Should you commit the patch (with any documentation tweaks
you deem necessary), or should I?
> I've done some semi-formal testing on it. My semi-formal test log is:
>
> (ii) Do some testing, using xdisp.c as test file. A file.c will not have
> other calls to syntax-ppss interfering with the tests.
> o - 1. Normal working: check both caches stay empty. They don't, because
> syntax-ppss is used, I think, by font locking.
> o - 2. Normal work in a narrowed buffer. Seems OK.
> o - 3. Switch back to widened. Seems OK.
> o - 4. Switch back to narrowed, same point-min. Check the caches. They
> look OK.
> o - 5. Switch to a different narrowing and (syntax-ppss (point-min)). This
> does indeed empty the syntax-ppss-narrow, as it should. s-p-wide looks
> unchanged. Good.
> o - 6. Get well filled caches for both narrow and wide regions. With the
> buffer wide, make a buffer change early in the buffer. Check both caches
> are properly trimmed. They are.
> o - 7. Repeat 6, but trim with the buffer narrow. Both caches look OK, the
> narrow cache being (nil).
Yes, this sounds fine. I've tried out most of those myself too, except
usually without checking the cache contents. Just the syntax-ppss results.
It would be nice to have 2 or 3 of those added as automated tests, BTW.
> Maybe I should also try some heavy hacking in, say, Emacs Lisp mode as a
> kind of soak test, since elisp mode uses syntax-ppss quite a bit, I
> believe.
Sure, except emacs-lisp-mode seems to still retain certain
indentation-related problems, even without this change.
I don't really expect to uncover problems from this patch much later.
That's been the point of making the change as simple as possible.
next prev parent reply other threads:[~2017-09-22 14:09 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-11 15:15 bug#22983: syntax-ppss returns wrong result Alan Mackenzie
2016-03-11 20:31 ` Dmitry Gutov
2016-03-11 21:24 ` Alan Mackenzie
2016-03-11 21:35 ` Dmitry Gutov
2016-03-11 22:15 ` Alan Mackenzie
2016-03-11 22:38 ` Dmitry Gutov
2016-03-13 17:37 ` Stefan Monnier
2016-03-13 18:57 ` Alan Mackenzie
2016-03-14 0:47 ` Dmitry Gutov
2016-03-14 1:04 ` Drew Adams
2016-04-03 22:55 ` John Wiegley
2016-03-14 1:49 ` Stefan Monnier
2016-03-13 17:32 ` Stefan Monnier
2016-03-13 18:52 ` Andreas Röhler
2016-03-13 18:56 ` Dmitry Gutov
2016-03-18 0:49 ` Dmitry Gutov
2016-03-19 12:27 ` Alan Mackenzie
2016-03-19 18:47 ` Dmitry Gutov
2016-03-27 0:51 ` John Wiegley
2016-03-27 1:14 ` Dmitry Gutov
2016-04-03 22:58 ` John Wiegley
2016-04-03 23:15 ` Dmitry Gutov
2017-09-02 13:12 ` Eli Zaretskii
2017-09-02 17:40 ` Alan Mackenzie
2017-09-02 17:53 ` Eli Zaretskii
2017-09-03 20:44 ` John Wiegley
2017-09-04 23:34 ` Dmitry Gutov
2017-09-05 6:57 ` Andreas Röhler
2017-09-05 12:28 ` John Wiegley
2017-09-07 20:45 ` Alan Mackenzie
2017-09-08 16:04 ` Andreas Röhler
2017-09-10 18:26 ` Alan Mackenzie
2017-09-09 9:44 ` Dmitry Gutov
2017-09-09 10:20 ` Alan Mackenzie
2017-09-09 12:18 ` Dmitry Gutov
2017-09-10 11:42 ` Alan Mackenzie
2017-09-10 11:36 ` bug#22983: [ Patch ] " Alan Mackenzie
2017-09-10 22:53 ` Stefan Monnier
2017-09-10 23:36 ` Dmitry Gutov
2017-09-11 11:10 ` Stefan Monnier
2017-09-12 0:11 ` Dmitry Gutov
2017-09-12 22:12 ` Richard Stallman
2017-09-11 19:42 ` Alan Mackenzie
2017-09-11 20:20 ` Stefan Monnier
2017-09-11 0:11 ` Dmitry Gutov
2017-09-11 20:12 ` Alan Mackenzie
2017-09-12 0:24 ` Dmitry Gutov
2017-09-17 10:29 ` Alan Mackenzie
2017-09-17 23:43 ` Dmitry Gutov
2017-09-18 19:08 ` Alan Mackenzie
2017-09-19 0:02 ` Dmitry Gutov
2017-09-19 20:47 ` Alan Mackenzie
2017-09-22 14:09 ` Dmitry Gutov [this message]
2017-09-24 11:26 ` Alan Mackenzie
2017-09-25 23:53 ` Dmitry Gutov
2017-10-01 16:36 ` Alan Mackenzie
2017-10-04 20:07 ` Johan Bockgård
2017-09-17 11:12 ` Philipp Stephani
2017-09-19 20:50 ` Alan Mackenzie
2017-09-07 17:56 ` Alan Mackenzie
2017-09-07 20:36 ` Dmitry Gutov
2016-03-19 23:16 ` Vitalie Spinu
2016-03-19 23:00 ` Vitalie Spinu
2016-03-19 23:20 ` Dmitry Gutov
[not found] ` <mailman.7307.1457709188.843.bug-gnu-emacs@gnu.org>
2017-10-01 16:31 ` Alan Mackenzie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8819156d-b58f-f87f-14b1-5e347202c752@yandex.ru \
--to=dgutov@yandex.ru \
--cc=22983@debbugs.gnu.org \
--cc=acm@muc.de \
--cc=jwiegley@gmail.com \
--cc=p.stephani2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).