From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#56682: feature/improved-locked-narrowing 9dee6df39c: Reworked locked narrowing. Date: Mon, 30 Jan 2023 23:07:22 +0200 Message-ID: <880256a0-4d91-76d7-1237-4866a3652803@yandex.ru> References: <166939872890.18950.12581667269687468681@vcs2.savannah.gnu.org> <20221125175209.51166C004B6@vcs2.savannah.gnu.org> <6c9d91cffc1bfd801530@heytings.org> <6c9d91cffc394613f58a@heytings.org> <83eds0ksev.fsf@gnu.org> <8aadf0ddd54c85c8144a@heytings.org> <831qnhg3d9.fsf@gnu.org> <9757fbea37611e9c44b9@heytings.org> <83cz6yacxt.fsf@gnu.org> <6943e04e30e5a02a52e6@heytings.org> <838rhk5fy1.fsf@gnu.org> <6943e04e30a40824e107@heytings.org> <83k0143q37.fsf@gnu.org> <012b781c-d4dd-0ec5-4c15-a997879690e9@yandex.ru> <83v8kn3kya.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21518"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Cc: 56682@debbugs.gnu.org, gregory@heytings.org, monnier@iro.umontreal.ca To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jan 30 22:08:13 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pMbNr-0005Nq-7z for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 30 Jan 2023 22:08:11 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pMbNo-0002Nf-SX; Mon, 30 Jan 2023 16:08:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMbNi-0002GN-F0 for bug-gnu-emacs@gnu.org; Mon, 30 Jan 2023 16:08:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pMbNi-0006is-6E for bug-gnu-emacs@gnu.org; Mon, 30 Jan 2023 16:08:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pMbNh-0006wj-PX for bug-gnu-emacs@gnu.org; Mon, 30 Jan 2023 16:08:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 30 Jan 2023 21:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56682 X-GNU-PR-Package: emacs Original-Received: via spool by 56682-submit@debbugs.gnu.org id=B56682.167511285326661 (code B ref 56682); Mon, 30 Jan 2023 21:08:01 +0000 Original-Received: (at 56682) by debbugs.gnu.org; 30 Jan 2023 21:07:33 +0000 Original-Received: from localhost ([127.0.0.1]:50723 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMbNF-0006vw-EQ for submit@debbugs.gnu.org; Mon, 30 Jan 2023 16:07:33 -0500 Original-Received: from mail-ed1-f46.google.com ([209.85.208.46]:37405) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMbND-0006vc-4E for 56682@debbugs.gnu.org; Mon, 30 Jan 2023 16:07:32 -0500 Original-Received: by mail-ed1-f46.google.com with SMTP id be12so1078823edb.4 for <56682@debbugs.gnu.org>; Mon, 30 Jan 2023 13:07:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=OiDvZ6yVWEpi+6AbuDFsACYWgjyzU2pqA/14+bqY/F8=; b=VNes2mvReac5KWUFpHvDxrR8AQjDsl/Lowu8Hzob/3P5qr8qM6ggCBorRaCd8TrIsW 1vCkno2gAdVwkhWUNmQX4is0nBZC6ucJ1gp5tDw9X2YOpbQva69t+ZgTead8xnt01UKw jVDiwkZR14yCejvNpkYuzon6u4jL5DZTiN/9r2kYR+4K2FOObNCp0hekvN7C9RDRt+th giR5hi4FO/d6mMuwxxqVAb8RGoMf24kKsNqzS//YthfwQDhTRR577iWxPSHbPtvT1GjV 8ewRblXv0R97A1rWgPU9LioHXHXezFuYQtNigp8H1Z87wwlhsyBymAUUwQfxp/UWUgng omuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=OiDvZ6yVWEpi+6AbuDFsACYWgjyzU2pqA/14+bqY/F8=; b=XR8FnlEB+UMnrTtBhBrxfO3xAlQu/ctWOSFAId7Csevvn+8lEa5X4XPDZZzgMHeeWU JmzlDBKIkgWGeSbzw/VXLJORhM7umhNx0Dyw8wXzow7U/Ld0xxqB+1vAZGEp4TC3L1sc 1p+48dJEtZz+A6l4t5rx+kWcHe6asIFpzcO7ns27WXuTVQA0MKt8x9J4jTpG6CDa4Udj Re5o9oABTwa1uUvLwa5uTEutKZRwiV0ugOrjlf3idxbl/LF+XSsx3osB3SOzea44USPX QU6ixBK2M4DR1/7t3FyyXVtE+UTDloytPM71reTn5/q50Ce/33jwjxQ8mjLKqm+i4vTx AQog== X-Gm-Message-State: AO0yUKXfSFISylPl4EutsHAAGl0O6MtMqhkoL2W489sFzlLtx/lx5Idz GsESAWCL8CPRc1Phl1vFL7o= X-Google-Smtp-Source: AK7set//llUqypwQ5RuvOlWsAF3HaMQlkVl5HlKogC+4FrzYIAFyB7amw+mlrLaHmNccZfHhEDduTg== X-Received: by 2002:a05:6402:22a7:b0:4a2:2819:ed22 with SMTP id cx7-20020a05640222a700b004a22819ed22mr11062540edb.38.1675112845240; Mon, 30 Jan 2023 13:07:25 -0800 (PST) Original-Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id qu21-20020a170907111500b00884c611145fsm3746534ejb.62.2023.01.30.13.07.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Jan 2023 13:07:24 -0800 (PST) Content-Language: en-US In-Reply-To: <83v8kn3kya.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:254483 Archived-At: On 30/01/2023 21:02, Eli Zaretskii wrote: >> Date: Mon, 30 Jan 2023 20:56:15 +0200 >> Cc:56682@debbugs.gnu.org,monnier@iro.umontreal.ca >> From: Dmitry Gutov >> >> On 30/01/2023 19:11, Eli Zaretskii wrote: >>>> Date: Mon, 30 Jan 2023 15:03:54 +0000 >>>> From: Gregory Heytings >>>> cc:56682@debbugs.gnu.org,monnier@iro.umontreal.ca >>>> >>>>> What exactly will that remove? only what's on the feature branch, or >>>>> also some stuff on the emacs-29 branch? >>>> The "locked narrowing" feature, IOW, the portions of editfns.c in which it >>>> is implemented, and its use around pre-command-hook, post-command-hook and >>>> fontification-functions. >>>> >>>>> And what are your reasons for removing this? It is hard to tell whether >>>>> or not I agree without knowing to what I should agree 😉 >>>>> >>>> The reason is that I'm now convinced that it is not a good solution to the >>>> problem of ill-behaving modes in the presence of long lines. >>> So we are removing all the stuff that prevented font-lock from slowing >>> down redisplay when long lines are in the buffer? IOW, something >>> which we have for several months, and which so far brought up only one >>> complaint? >> More than one, FTR. >> >> I'm not 100% sure what Gregory's plan is, but note that a significant >> part of the redisplay slowdowns wasn't caused by font-lock, and thus the >> removal of locking will not regress those performance improvements. >> >> And for those (potential?) cases where font-lock is a real problem for >> performance, we could stop it from widening using an existing knob. > Yes, this is an old and known disagreement between us. But this is my > decision to make, not anyone else's. With the previous change that Gregory had made (different limits for different features, i.e. font-lock uses much wider narrowing bounds which are also customizable) I don't have that much of a horse in that race anymore. Just helping clear up some misconceptions, if any. Also note that previously, I'd never have suggested that redisplay code changes the value of font-lock-dont-widen.